Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c
On Sun, 3 Feb 2002, Yasuo Ohgaki wrote: Sometimes it takes a while for me to reply, but here it is :) Thanks. I feel it also. Although, I think are better to release 4.1.2 before 4.2.0. What _very_ critical fixes where done in the 4.1 branch? IMO, they certaily do not need a new 'bug-fix' release as was needed for 4.1.0. Therefore there shall not be an 4.1.2. I think we really need developer's web sites to keep these kind of rules. IIRC, when we made a 2 branches, there is one simple rule for MFH. If it's a bug fix, merge it if it's possible. The general 'rule' is (we actually don't have rules for it) is to merge critical fixes to the release branch, to make sure that IF there will be a new release of an already release branch, those very critical fixes are taken into account. I wouldn't merge my massive PostgreSQL changes to release branch, but I would like to merge simple and critical bug fixes to relase branch. What do you define as critical exactly? For me it is a security problem, or a major feature of PHP not working (ie. sessions or a bug in the MySQL module which renders it totally useles.) One think build error is ciritical, but others not :) I wasn't aware that it was a build error. In this case it should be merged of course. Derick - PHP: Scripting the Web - www.php.net - [EMAIL PROTECTED] SRM: Site Resource Manager - www.vl-srm.net - -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c
-Original Message- From: Yasuo Ohgaki [mailto:[EMAIL PROTECTED]] Sent: Sunday, February 03, 2002 1:43 AM To: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c [EMAIL PROTECTED] wrote: Hello, Why are you merging this? This absolutely makes no sense, 1) this branch is proably not used anymore in the future, 2) It's not anyware near a critical thing. Please revert it. It may not be a ciritical bug for users other than Roxen. Why do you care, if this branch is not going to be used? There are many patches applied after 4.1.1 release also, if you want keep branch clean. Yasuo, I don't see the need here to MFH a patch to 4.1.1 -- unless something _really_ major needs fixing, (and it doesn't) this branch is as good as dead.. If someone is using roxen, then we can stick a diff on the website, as a minor patch, and / or they can cvs co from HEAD. my 2 insert currency here james -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c
James Cox wrote: -Original Message- From: Yasuo Ohgaki [mailto:[EMAIL PROTECTED]] Sent: Sunday, February 03, 2002 1:43 AM To: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c [EMAIL PROTECTED] wrote: Hello, Why are you merging this? This absolutely makes no sense, 1) this branch is proably not used anymore in the future, 2) It's not anyware near a critical thing. Please revert it. It may not be a ciritical bug for users other than Roxen. Why do you care, if this branch is not going to be used? There are many patches applied after 4.1.1 release also, if you want keep branch clean. Yasuo, I don't see the need here to MFH a patch to 4.1.1 -- unless something _really_ major needs fixing, (and it doesn't) this branch is as good as dead.. Thanks. I feel it also. Although, I think are better to release 4.1.2 before 4.2.0. If someone is using roxen, then we can stick a diff on the website, as a minor patch, and / or they can cvs co from HEAD. my 2 insert currency here I may not be following previous discussions well. Could you freshen my memory? I think we really need developer's web sites to keep these kind of rules. IIRC, when we made a 2 branches, there is one simple rule for MFH. If it's a bug fix, merge it if it's possible. Do we change this rule after 4.1.0 release? (or I must be missed some rules) I wouldn't merge my massive PostgreSQL changes to release branch, but I would like to merge simple and critical bug fixes to relase branch. If the rule is decided as a result of discussion, I'll follow the rules. Although, it would be really difficult to decide which one is critical or not. One think build error is ciritical, but others not :) -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c
I finally figured out that my commit log is bad. Sorry guys ;) I should have mentioned it fixes build error according to bug reports and user who submitted this patch. Anyway, we are better to release 4.1.2 if we follow release often, release early rule. IMHO. -- Yasuo Ohgaki James Cox wrote: -Original Message- From: Yasuo Ohgaki [mailto:[EMAIL PROTECTED]] Sent: Sunday, February 03, 2002 1:43 AM To: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c [EMAIL PROTECTED] wrote: Hello, Why are you merging this? This absolutely makes no sense, 1) this branch is proably not used anymore in the future, 2) It's not anyware near a critical thing. Please revert it. It may not be a ciritical bug for users other than Roxen. Why do you care, if this branch is not going to be used? There are many patches applied after 4.1.1 release also, if you want keep branch clean. Yasuo, I don't see the need here to MFH a patch to 4.1.1 -- unless something _really_ major needs fixing, (and it doesn't) this branch is as good as dead.. If someone is using roxen, then we can stick a diff on the website, as a minor patch, and / or they can cvs co from HEAD. my 2 insert currency here -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c
[EMAIL PROTECTED] wrote: Hello, Why are you merging this? This absolutely makes no sense, 1) this branch is proably not used anymore in the future, 2) It's not anyware near a critical thing. Please revert it. It may not be a ciritical bug for users other than Roxen. Why do you care, if this branch is not going to be used? There are many patches applied after 4.1.1 release also, if you want keep branch clean. I don't mind revert it, but I just don't see the good reason for it... -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
