Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-20 Thread Moriyoshi Koizumi
Andi Gutmans [EMAIL PROTECTED] wrote: At 01:28 PM 12/19/2002 +, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-20 Thread Andi Gutmans
At 11:57 PM 12/20/2002 +0900, Moriyoshi Koizumi wrote: Andi Gutmans [EMAIL PROTECTED] wrote: At 01:28 PM 12/19/2002 +, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-19 Thread Wez Furlong
Would this solve the problem? Index: main/main.c === RCS file: /repository/php4/main/main.c,v retrieving revision 1.520 diff -u -r1.520 main.c --- main/main.c 16 Dec 2002 15:43:52 - 1.520 +++ main/main.c 19 Dec 2002 13:06:45

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-19 Thread Wez Furlong
Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will get cleaned up by the engine at request shutdown? --Wez. On Wed, 18 Dec 2002, Andi

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-19 Thread Wez Furlong
On Thu, 19 Dec 2002, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-19 Thread Andi Gutmans
At 01:28 PM 12/19/2002 +, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will get cleaned up by the engine at request

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-18 Thread Andi Gutmans
At 11:17 AM 12/17/2002 +0900, Moriyoshi Koizumi wrote: Andi Gutmans [EMAIL PROTECTED] wrote: I didn't understand the explanation. Why do you mind if the resources are destroyed before the constants? That's good, no? Sorry, I'm still unsure if my patch is the correct one, as I said in the

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-18 Thread Edin Kadribasic
Sorry, I'm still unsure if my patch is the correct one, as I said in the first mail. As far as I've looked into it, the streams seem to be destructed and freed twice, once in deactivation and once in shutdown. If you think my patch is bogus, feel free to revert it unless I can give more

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-18 Thread Andi Gutmans
At 12:56 AM 12/19/2002 +0100, Edin Kadribasic wrote: Sorry, I'm still unsure if my patch is the correct one, as I said in the first mail. As far as I've looked into it, the streams seem to be destructed and freed twice, once in deactivation and once in shutdown. If you think my patch is

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-09 Thread Sebastian Bergmann
Sebastian Bergmann wrote: sebastian Mon Dec 9 06:45:47 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Fix build. Index: php4/sapi/cli/php_cli.c diff -u php4/sapi/cli/php_cli.c:1.54 php4/sapi/cli/php_cli.c:1.55 --- php4/sapi/cli/php_cli.c:1.54

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-23 Thread Derick Rethans
On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Derick Rethans wrote: On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. The line was bogus with the current code. Did

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-23 Thread Derick Rethans
On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: BTW, you haven't reply [implicit_flush off] thread. Usually, it means agreed. I might gave you to little time, though. I did a few weeks ago when you was messing with it too. It's useless to repeat every discussion over and over again. See:

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-23 Thread Zeev Suraski
At 07:44 23/10/2002, Yasuo Ohgaki wrote: Andi Gutmans wrote: At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Jani Taskinen
Again..was this agreed upon? --Jani On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: yohgakiTue Oct 22 21:21:40 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Make CLI behave like other moder scripting languages. Index:

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Yasuo Ohgaki
Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. -- Yasuo Ohgaki --Jani On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: yohgaki Tue Oct 22 21:21:40 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Make

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Andi Gutmans
At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need changing. Who cares what perl does? I don't think there's a right or

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Yasuo Ohgaki
Andi Gutmans wrote: At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need changing. Who cares what perl does? I don't

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Derick Rethans
On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. Derick --

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Yasuo Ohgaki
Andi Gutmans wrote: At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need changing. Who cares what perl does? I don't

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Yasuo Ohgaki
Derick Rethans wrote: On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. The line was bogus with the current code.

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-10-22 Thread Yasuo Ohgaki
Yasuo Ohgaki wrote: Derick Rethans wrote: On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. BTW, you haven't

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-05-24 Thread Markus Fischer
+1 ! On Fri, May 24, 2002 at 09:10:26AM +0200, Edin Kadribasic wrote : What this patch does is basically this: define ('STDIN', fopen('php://stdin', 'r'); ... I thinks it's useful to have these file descriptors always present in order to make using cli as a command line pipe filter