Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Andi Gutmans [EMAIL PROTECTED] wrote: At 01:28 PM 12/19/2002 +, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will get cleaned up by the engine at request shutdown? If these are per-request constants then you are correct and the patch was OK. I thought these were constants which survive requests. Well, only in cli are the constants STDIN, STDOUT, and STDERR registered. So can I commit the patch again? Moriyoshi Andi --Wez. On Wed, 18 Dec 2002, Andi Gutmans wrote: I don't like these voodoo patches. I think if the stream is destroyed twice that should be solved and not the constant itself. Unless you have a good reason please revert your patch and talk to Wez about fixing this properly. Thanks, Andi - ic.flags = CONST_CS | CONST_PERSISTENT; + ic.flags = CONST_CS; -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
At 11:57 PM 12/20/2002 +0900, Moriyoshi Koizumi wrote: Andi Gutmans [EMAIL PROTECTED] wrote: At 01:28 PM 12/19/2002 +, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will get cleaned up by the engine at request shutdown? If these are per-request constants then you are correct and the patch was OK. I thought these were constants which survive requests. Well, only in cli are the constants STDIN, STDOUT, and STDERR registered. So can I commit the patch again? Yep. Andi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Would this solve the problem? Index: main/main.c === RCS file: /repository/php4/main/main.c,v retrieving revision 1.520 diff -u -r1.520 main.c --- main/main.c 16 Dec 2002 15:43:52 - 1.520 +++ main/main.c 19 Dec 2002 13:06:45 - @@ -1337,9 +1337,9 @@ php_shutdown_ticks(TSRMLS_C); sapi_flush(TSRMLS_C); + php_shutdown_stream_wrappers(module_number TSRMLS_CC); zend_shutdown(TSRMLS_C); - php_shutdown_stream_wrappers(module_number TSRMLS_CC); php_shutdown_info_logos(); UNREGISTER_INI_ENTRIES(); On Thu, 19 Dec 2002, Edin Kadribasic wrote: Sorry, I'm still unsure if my patch is the correct one, as I said in the first mail. As far as I've looked into it, the streams seem to be destructed and freed twice, once in deactivation and once in shutdown. If you think my patch is bogus, feel free to revert it unless I can give more reasonable explanation. I comitted tha patch and I'll revert it. Just to clarify one thing: constanst throuout PHP should be created as CONST_PERSISTENT? Edin -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php Index: main/main.c === RCS file: /repository/php4/main/main.c,v retrieving revision 1.520 diff -u -r1.520 main.c --- main/main.c 16 Dec 2002 15:43:52 - 1.520 +++ main/main.c 19 Dec 2002 13:07:04 - @@ -1337,9 +1337,9 @@ php_shutdown_ticks(TSRMLS_C); sapi_flush(TSRMLS_C); + php_shutdown_stream_wrappers(module_number TSRMLS_CC); zend_shutdown(TSRMLS_C); - php_shutdown_stream_wrappers(module_number TSRMLS_CC); php_shutdown_info_logos(); UNREGISTER_INI_ENTRIES(); -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will get cleaned up by the engine at request shutdown? --Wez. On Wed, 18 Dec 2002, Andi Gutmans wrote: I don't like these voodoo patches. I think if the stream is destroyed twice that should be solved and not the constant itself. Unless you have a good reason please revert your patch and talk to Wez about fixing this properly. Thanks, Andi - ic.flags = CONST_CS | CONST_PERSISTENT; + ic.flags = CONST_CS; -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
On Thu, 19 Dec 2002, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will ^^^ constants get cleaned up by the engine at request shutdown? --Wez. On Wed, 18 Dec 2002, Andi Gutmans wrote: I don't like these voodoo patches. I think if the stream is destroyed twice that should be solved and not the constant itself. Unless you have a good reason please revert your patch and talk to Wez about fixing this properly. Thanks, Andi - ic.flags = CONST_CS | CONST_PERSISTENT; + ic.flags = CONST_CS; -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
At 01:28 PM 12/19/2002 +, Wez Furlong wrote: Actually, it does seem valid to me; streams based on FILE* are not registered in the persistent list, so does it make sense to have the associated resources registered as persistent resources when they will get cleaned up by the engine at request shutdown? If these are per-request constants then you are correct and the patch was OK. I thought these were constants which survive requests. Andi --Wez. On Wed, 18 Dec 2002, Andi Gutmans wrote: I don't like these voodoo patches. I think if the stream is destroyed twice that should be solved and not the constant itself. Unless you have a good reason please revert your patch and talk to Wez about fixing this properly. Thanks, Andi - ic.flags = CONST_CS | CONST_PERSISTENT; + ic.flags = CONST_CS; -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
At 11:17 AM 12/17/2002 +0900, Moriyoshi Koizumi wrote: Andi Gutmans [EMAIL PROTECTED] wrote: I didn't understand the explanation. Why do you mind if the resources are destroyed before the constants? That's good, no? Sorry, I'm still unsure if my patch is the correct one, as I said in the first mail. As far as I've looked into it, the streams seem to be destructed and freed twice, once in deactivation and once in shutdown. If you think my patch is bogus, feel free to revert it unless I can give more reasonable explanation. Hi, I don't like these voodoo patches. I think if the stream is destroyed twice that should be solved and not the constant itself. Unless you have a good reason please revert your patch and talk to Wez about fixing this properly. Thanks, Andi Moriyoshi Andi At 03:22 PM 12/15/2002 +0900, Moriyoshi Koizumi wrote: It appears that the problem was because stream resources are finalized before the constants that contain those resources are destructed, as php_stream_open_wrapper_ex() doesn't return persistent resources. Moriyoshi Andi Gutmans [EMAIL PROTECTED] wrote: This doesn't look right to me. We always use CONST_PERSISTENT in all of PHP. What is the problem? Andi At 10:24 AM 12/11/2002 +, Edin Kadribasic wrote: edink Wed Dec 11 05:24:03 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Fix for #20539 (patch by Moriyoshi Koizumi). Index: php4/sapi/cli/php_cli.c diff -u php4/sapi/cli/php_cli.c:1.55 php4/sapi/cli/php_cli.c:1.56 --- php4/sapi/cli/php_cli.c:1.55Mon Dec 9 06:45:46 2002 +++ php4/sapi/cli/php_cli.c Wed Dec 11 05:24:02 2002 @@ -375,19 +375,19 @@ php_stream_to_zval(s_err, zerr); ic.value = *zin; - ic.flags = CONST_CS | CONST_PERSISTENT; + ic.flags = CONST_CS; ic.name = zend_strndup(STDIN, 6); ic.name_len = 6; zend_register_constant(ic TSRMLS_CC); oc.value = *zout; - oc.flags = CONST_CS | CONST_PERSISTENT; + oc.flags = CONST_CS; oc.name = zend_strndup(STDOUT, 7); oc.name_len = 7; zend_register_constant(oc TSRMLS_CC); ec.value = *zerr; - ec.flags = CONST_CS | CONST_PERSISTENT; + ec.flags = CONST_CS; ec.name = zend_strndup(STDERR, 7); ec.name_len = 7; zend_register_constant(ec TSRMLS_CC); -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Sorry, I'm still unsure if my patch is the correct one, as I said in the first mail. As far as I've looked into it, the streams seem to be destructed and freed twice, once in deactivation and once in shutdown. If you think my patch is bogus, feel free to revert it unless I can give more reasonable explanation. I comitted tha patch and I'll revert it. Just to clarify one thing: constanst throuout PHP should be created as CONST_PERSISTENT? Edin -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
At 12:56 AM 12/19/2002 +0100, Edin Kadribasic wrote: Sorry, I'm still unsure if my patch is the correct one, as I said in the first mail. As far as I've looked into it, the streams seem to be destructed and freed twice, once in deactivation and once in shutdown. If you think my patch is bogus, feel free to revert it unless I can give more reasonable explanation. I comitted tha patch and I'll revert it. Just to clarify one thing: constanst throuout PHP should be created as CONST_PERSISTENT? Yeah in almost all cases. Andi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Sebastian Bergmann wrote: sebastian Mon Dec 9 06:45:47 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Fix build. Index: php4/sapi/cli/php_cli.c diff -u php4/sapi/cli/php_cli.c:1.54 php4/sapi/cli/php_cli.c:1.55 --- php4/sapi/cli/php_cli.c:1.54Sun Dec 8 05:23:50 2002 +++ php4/sapi/cli/php_cli.c Mon Dec 9 06:45:46 2002 @@ -23,6 +23,7 @@ #include php.h #include php_globals.h #include php_variables.h +#include zend_hash.h #include zend_modules.h #include SAPI.h I committed the patch above because I was getting a php_cli.obj: error LNK2001: Unresolved external symbol __imp___zend_hash_init error when building sapi/cli on Win32. Adding the #include zend_hash.h to php4/sapi/cli/php_cli.c fixed the problem, so I committed. But now I'm getting the same error. Any idea why? Confused, Sebastian -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/ -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Derick Rethans wrote: On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. The line was bogus with the current code. Did you read my email? Yes, i read it. Because you think it's bogus it doesn't mean that others always agree with you on that. I do not for example. Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: BTW, you haven't reply [implicit_flush off] thread. Usually, it means agreed. I might gave you to little time, though. I did a few weeks ago when you was messing with it too. It's useless to repeat every discussion over and over again. See: http://marc.theaimsgroup.com/?l=php-cvsm=103364134021257w=2 Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
At 07:44 23/10/2002, Yasuo Ohgaki wrote: Andi Gutmans wrote: At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need changing. Who cares what perl does? I don't think there's a right or wrong on this issue. Let us know why modern and successful script language, perl, ruby and python, choice is wrong, too. if the setting was good. Yasuo, Why don't YOU tell US why you think the modern and successful scripting language named PHP is wrong. I personally find it not-useful to have to flush() all the time if I don't print out newlines, so having implicit_flush turned on by default in CLI doesn't sound like a very bad thing. Unless you can prove otherwise, please revert. Zeev -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Again..was this agreed upon? --Jani On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: yohgakiTue Oct 22 21:21:40 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Make CLI behave like other moder scripting languages. Index: php4/sapi/cli/php_cli.c diff -u php4/sapi/cli/php_cli.c:1.37 php4/sapi/cli/php_cli.c:1.38 --- php4/sapi/cli/php_cli.c:1.37 Mon Oct 14 07:59:58 2002 +++ php4/sapi/cli/php_cli.cTue Oct 22 21:21:40 2002 -466,7 +466,6 SG(options) |= SAPI_OPTION_NO_CHDIR; zend_alter_ini_entry(register_argc_argv, 19, 1, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); zend_alter_ini_entry(html_errors, 12, 0, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); - zend_alter_ini_entry(implicit_flush, 15, 1, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); zend_alter_ini_entry(max_execution_time, 19, 0, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); zend_uv.html_errors = 0; /* tell the engine we're in non-html mode */ -- - For Sale! - -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. -- Yasuo Ohgaki --Jani On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: yohgaki Tue Oct 22 21:21:40 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Make CLI behave like other moder scripting languages. Index: php4/sapi/cli/php_cli.c diff -u php4/sapi/cli/php_cli.c:1.37 php4/sapi/cli/php_cli.c:1.38 --- php4/sapi/cli/php_cli.c:1.37 Mon Oct 14 07:59:58 2002 +++ php4/sapi/cli/php_cli.c Tue Oct 22 21:21:40 2002 -466,7 +466,6 SG(options) |= SAPI_OPTION_NO_CHDIR; zend_alter_ini_entry(register_argc_argv, 19, 1, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); zend_alter_ini_entry(html_errors, 12, 0, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); - zend_alter_ini_entry(implicit_flush, 15, 1, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); zend_alter_ini_entry(max_execution_time, 19, 0, 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE); zend_uv.html_errors = 0; /* tell the engine we're in non-html mode */ -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need changing. Who cares what perl does? I don't think there's a right or wrong on this issue. Andi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Andi Gutmans wrote: At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need changing. Who cares what perl does? I don't think there's a right or wrong on this issue. Ok. Then start proposing PG(inplicit_flush) be INI_ALL and let us know the implication of the change. -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Andi Gutmans wrote: At 12:20 PM 10/23/2002 +0900, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. It's not a big deal to me but I don't understand why this should need changing. Who cares what perl does? I don't think there's a right or wrong on this issue. Let us know why modern and successful script language, perl, ruby and python, choice is wrong, too. if the setting was good. -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Derick Rethans wrote: On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. The line was bogus with the current code. Did you read my email? -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
Yasuo Ohgaki wrote: Derick Rethans wrote: On Wed, 23 Oct 2002, Yasuo Ohgaki wrote: Jani Taskinen wrote: Again..was this agreed upon? I suppose so. I didn't get any more objections. You got atleast one, and that was mine. I didn't see people agree either. BTW, you haven't reply [implicit_flush off] thread. Usually, it means agreed. I might gave you to little time, though. I don't get objection from Edin, too. Replying to the thread is fine if you would like. -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c
+1 !
On Fri, May 24, 2002 at 09:10:26AM +0200, Edin Kadribasic wrote :
What this patch does is basically this:
define ('STDIN', fopen('php://stdin', 'r');
...
I thinks it's useful to have these file descriptors always present in order
to make using cli as a command line pipe filter easier and more readable. An
example:
php -i | php -r 'while ($l=fgets(STDIN)) echo strip_tags($l);'
Edin
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
Please always Cc to me when replying to me on the lists.
GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc
-
I mean When in doubt, blame mcrypt is more often right than wrong :)
Always right, never wrong :)
- Two PHP developers who want to remain unnamed
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php
