Re: [PHP-DEV] Should I fix this?

2003-01-12 Thread Rickard Andersson
Pierre-Alain Joye wrote: > You do not have to feel like an idiot, I always specify the width&height > for the images. Well, since I had somehow "forgotten" that I could use getimagesize() with every image display, I do, but if it had been a question of using the database to save width&height, I do

Re: [PHP-DEV] Should I fix this?

2003-01-12 Thread Pierre-Alain Joye
On Mon, 13 Jan 2003 00:49:43 +0100 "Rickard Andersson" <[EMAIL PROTECTED]> wrote: > To tell you the truth, I never really thought about running > getimagesize() to get width="x" height="y" when displaying the images. > For some reason I always thought that I would be forced to save the > width and

Re: [PHP-DEV] Should I fix this?

2003-01-12 Thread Rickard Andersson
Melvyn Sopacua wrote: > I don't agree. > An avatar, by nature, has a fixed _image_ size. If you allow variable > avatar image sizes, then you still have the option to use that same > getimagesize() > to set the width and height attributes of the HTML IMG tag and the browser > (any browser), will re

Re: [PHP-DEV] Should I fix this?

2003-01-12 Thread Melvyn Sopacua
At 20:56 12-1-2003, Pierre-Alain Joye wrote: The filesize (with max upload size) will preserve of big image upload. Render the image inside a html image can be fixed with the size properties (which exist for this purpose...). I m against to add this to the current imagesize function, by default

Re: [PHP-DEV] Should I fix this?

2003-01-12 Thread Pierre-Alain Joye
Hello, I do not think this is a good solution, and starting to check the internal data of each images (think about bmp or any 'raw' images format). The filesize (with max upload size) will preserve of big image upload. Render the image inside a html image can be fixed with the size properties (wh

Re: [PHP-DEV] Should I fix this?

2003-01-12 Thread Melvyn Sopacua
At 09:55 7-1-2003, Marcus Börger wrote: At 01:43 07.01.2003, Rickard Andersson wrote: I'd be glad to write a patch for image.c (function php_handle_gif()), but I though I should ask you guys first. I wouldn't want to do it in vain. As it is now I've got PHP code that checks this for me to preven

Re: [PHP-DEV] Should I fix this?

2003-01-08 Thread Marcus Börger
At 04:20 08.01.2003, Rickard Andersson wrote: BTW. I'm kinda new to contributing to large projects as this one. Should I checkout the latest CVS and patch agains that or should I use some other base for my alterations? Please check out HEAD (latest) and send a unified diff (diff -u) to this list

Re: [PHP-DEV] Should I fix this?

2003-01-07 Thread Rickard Andersson
Marcus Börger wrote: > The advantage is that this would retrieve the correct size even for gifs > with multiple images. On the other hand the disadvantage is speed loss. I've been giving this some thought. Shouldn't getimagesize() just return false if the "actual size" (the largest size found in

Re: [PHP-DEV] Should I fix this?

2003-01-07 Thread Marcus Börger
Marcus: could you specify the speed loss? If it's noticeable I would rather suggest to either introduce a new function or another parameter to getimagesize(), no matter what the default is (e.g. let getimagesize() get the "real" size and introduce something like getimagesize_fast()) or the other

Re: [PHP-DEV] Should I fix this?

2003-01-07 Thread Sebastian Nohn
Marcus Börger schrieb: > At 01:43 07.01.2003, Rickard Andersson wrote: > >getimagesize() blindly trusts the width and height > >specified in the header > >of gifs. You can just hexedit the file and set the width > >and height to any > >value and getimagesize() will believe that is the "true > >size

Re: [PHP-DEV] Should I fix this?

2003-01-07 Thread Marcus Börger
At 01:43 07.01.2003, Rickard Andersson wrote: getimagesize() blindly trusts the width and height specified in the header of gifs. You can just hexedit the file and set the width and height to any value and getimagesize() will believe that is the "true size" of the image. Even worse - Internet Expl

[PHP-DEV] Should I fix this?

2003-01-06 Thread Rickard Andersson
My only contribution to PHP thus far is the following bug report/feature request (#18052): getimagesize() blindly trusts the width and height specified in the header of gifs. You can just hexedit the file and set the width and height to any value and getimagesize() will believe that is the "true s