[PHP-DEV] writing test cases
Hi all, please take care if you write test cases. Tests for PHP5/ZE2 only are also in the PHP4 branch, but some of them have no SKIPIF for versions 5.0.0, please use version_compare() to skip these tests for lower versions. Same problem with tests for changed functions (for instance range()). This test failed for 4.3.1-dev, because PHP 5 doesn't know the third parameter. Please don't mix tests across the versions, write a new test with version check for a new parameter/feature. In addition to my yesterday's mail I've found a new broken test: tests/lang/bug21961.phpt Thanks, Kai -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] writing test cases
Kai Schröder [EMAIL PROTECTED] wrote: In addition to my yesterday's mail I've found a new broken test: tests/lang/bug21961.phpt Fixed. Thanks for the notification. Moriyoshi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] writing test cases
that's not true guys, PHP4 is in the PHP_4_3 branch and if you don't explicitely commit the tests to that branch they won't be there. HEAD is PHP5. there's no need for comparing versions or whatever except if you want to make one test work differently for both php versions. harald Moriyoshi Koizumi [EMAIL PROTECTED] schrieb im Newsbeitrag news:20030204015827W=3'[EMAIL PROTECTED]... Kai Schröder [EMAIL PROTECTED] wrote: In addition to my yesterday's mail I've found a new broken test: tests/lang/bug21961.phpt Fixed. Thanks for the notification. Moriyoshi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] writing test cases
I got the same idea in the first place and so I didn't append SKIPIF section. I simply don't know much about Windows testruns. Moriyoshi Harald Radi [EMAIL PROTECTED] wrote: that's not true guys, PHP4 is in the PHP_4_3 branch and if you don't explicitely commit the tests to that branch they won't be there. HEAD is PHP5. there's no need for comparing versions or whatever except if you want to make one test work differently for both php versions. harald Moriyoshi Koizumi [EMAIL PROTECTED] schrieb im Newsbeitrag news:20030204015827W=3'[EMAIL PROTECTED]... Kai Schröder [EMAIL PROTECTED] wrote: In addition to my yesterday's mail I've found a new broken test: tests/lang/bug21961.phpt Fixed. Thanks for the notification. Moriyoshi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] writing test cases
that's not true guys, PHP4 is in the PHP_4_3 branch and if you don't explicitely commit the tests to that branch they won't be there. HEAD is PHP5. Because tests are not in the win32 snaps, I make cvs -z9 -d :pserver:[EMAIL PROTECTED]:/repository co php4 to checkout the PHP4 branch. Is this wrong? Regards, Kai -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] writing test cases
On Mon, 3 Feb 2003, [iso-8859-1] Kai Schröder wrote: that's not true guys, PHP4 is in the PHP_4_3 branch and if you don't explicitely commit the tests to that branch they won't be there. HEAD is PHP5. Because tests are not in the win32 snaps, I make cvs -z9 -d :pserver:[EMAIL PROTECTED]:/repository co php4 to checkout the PHP4 branch. Is this wrong? yes, use: cvs co -r PHP_4_3 php4 or: cvs co php5 Derick -- - Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ - -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] writing test cases
On Mon, 3 Feb 2003, Derick Rethans wrote: On Mon, 3 Feb 2003, [iso-8859-1] Kai Schröder wrote: that's not true guys, PHP4 is in the PHP_4_3 branch and if you don't explicitely commit the tests to that branch they won't be there. HEAD is PHP5. Because tests are not in the win32 snaps, I make cvs -z9 -d :pserver:[EMAIL PROTECTED]:/repository co php4 to checkout the PHP4 branch. Is this wrong? yes, use: cvs co -r PHP_4_3 php4 or: cvs co php5 And don't try to run tests written for HEAD with PHP 4.3.x.. --Jani -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
