[PHP-DEV] Bug #13038 Updated: Cookie Error in Net/Curl.php

2001-10-22 Thread sterling 

ID: 13038
Updated by: sterling
Reported By: [EMAIL PROTECTED]
Old Status: Open
Status: Closed
Bug Type: HTTP related
Operating System: all
PHP Version: 4.0.6
New Comment:

fixed in cvs, thanks.

Previous Comments:


[2001-08-30 08:06:47] [EMAIL PROTECTED]

line 319:   
$ret = curl_setopt($ch, CURLOPT_COOKIE, $cookie_data);   
may cause a warning, if cookies is an empty array.   
Better:   
if(!empty($cookie_data){   
 $ret = curl_setopt($ch, CURLOPT_COOKIE, $cookie_data);   }




[2001-08-29 13:26:03] [EMAIL PROTECTED]

In Curl.php around line 316 multiple cookies are concatenated with newline. Shold be 
semicolon:
if (isset($this-cookies)) {
  foreach ($this-cookies as $name = $value) {
  $cookie_data .= urlencode($name) . :  .\ urlencode($value);
 $cookie_data .= ;; // This is correct, before it was \n
}






Edit this bug report at http://bugs.php.net/?id=13038edit=1


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Bug #13038 Updated: Cookie Error in Net/Curl.php

2001-08-30 Thread olaf 

ID: 13038
User updated by: [EMAIL PROTECTED]
Reported By: [EMAIL PROTECTED]
Status: Open
Bug Type: HTTP related
Operating System: all
PHP Version: 4.0.6
New Comment:

line 319:   
$ret = curl_setopt($ch, CURLOPT_COOKIE, $cookie_data);   
may cause a warning, if cookies is an empty array.   
Better:   
if(!empty($cookie_data){   
 $ret = curl_setopt($ch, CURLOPT_COOKIE, $cookie_data);   }


Previous Comments:


[2001-08-29 13:26:03] [EMAIL PROTECTED]

In Curl.php around line 316 multiple cookies are concatenated with newline. Shold be 
semicolon:
if (isset($this-cookies)) {
  foreach ($this-cookies as $name = $value) {
  $cookie_data .= urlencode($name) . :  .\ urlencode($value);
 $cookie_data .= ;; // This is correct, before it was \n
}






Edit this bug report at http://bugs.php.net/?id=13038edit=1


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]