[PHP-DEV] Bug #13216 Updated: Removal of redundant function call
ID: 13216
User updated by: [EMAIL PROTECTED]
Reported By: [EMAIL PROTECTED]
Status: Open
Bug Type: Feature/Change Request
Operating System: Debian GNU/Linux
PHP Version: 4.0.6
New Comment:
Grr web interface:
http://www.bubblesworth.com/php4.cvs2.diff
Previous Comments:
[2001-09-08 22:38:10] [EMAIL PROTECTED]
Since the webform saw fit to mangle my patch, it's available at a
href=http://www.bubblesworth.com/php4.cvs1.diff;http://www.bubblesworth.com/php4.cvs1.diff/a
[2001-09-08 22:31:18] [EMAIL PROTECTED]
Since encoded_value is set depending only on whether z_value is NULL(0) or not, surely
there's no need to check Z_STRVAL_PP(z_value) before using encoded_value, and it just
adds stuff to the normal execution path. At this point, we know either z_value is
null, or Z_STRLEN_PP(z_value) is not 0.
--- ext/standard/head.c.cvs Sun Sep 9 12:13:27 2001
+++ ext/standard/head.c.new Sun Sep 9 12:32:00 2001
@@ -142,7 +142,7 @@
sprintf(cookie, Set-Cookie: %s=deleted; expires=%s,
Z_STRVAL_PP(z_name), dt);
efree(dt);
} else {
- sprintf(cookie, Set-Cookie: %s=%s, Z_STRVAL_PP(z_name), (z_value
Z_STRVAL_PP(z_value)) ? encoded_value : );
+ sprintf(cookie, Set-Cookie: %s=%s, Z_STRVAL_PP(z_name), z_value ?
+encoded_value : );
if (expires 0) {
strcat(cookie, ; expires=);
dt = php_std_date(expires);
--
Paul TBBle Hampson
Edit this bug report at http://bugs.php.net/?id=13216edit=1
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Bug #13216 Updated: Removal of redundant function call
ID: 13216
User updated by: [EMAIL PROTECTED]
Reported By: [EMAIL PROTECTED]
Status: Open
Bug Type: Feature/Change Request
Operating System: Debian GNU/Linux
PHP Version: 4.0.6
New Comment:
Grr idiot at keyboard. (That other patch is for #13217)
http://www.bubblesworth.com/php4.cvs1.diff
Previous Comments:
[2001-09-08 22:38:45] [EMAIL PROTECTED]
Grr web interface:
http://www.bubblesworth.com/php4.cvs2.diff
[2001-09-08 22:38:10] [EMAIL PROTECTED]
Since the webform saw fit to mangle my patch, it's available at a
href=http://www.bubblesworth.com/php4.cvs1.diff;http://www.bubblesworth.com/php4.cvs1.diff/a
[2001-09-08 22:31:18] [EMAIL PROTECTED]
Since encoded_value is set depending only on whether z_value is NULL(0) or not, surely
there's no need to check Z_STRVAL_PP(z_value) before using encoded_value, and it just
adds stuff to the normal execution path. At this point, we know either z_value is
null, or Z_STRLEN_PP(z_value) is not 0.
--- ext/standard/head.c.cvs Sun Sep 9 12:13:27 2001
+++ ext/standard/head.c.new Sun Sep 9 12:32:00 2001
@@ -142,7 +142,7 @@
sprintf(cookie, Set-Cookie: %s=deleted; expires=%s,
Z_STRVAL_PP(z_name), dt);
efree(dt);
} else {
- sprintf(cookie, Set-Cookie: %s=%s, Z_STRVAL_PP(z_name), (z_value
Z_STRVAL_PP(z_value)) ? encoded_value : );
+ sprintf(cookie, Set-Cookie: %s=%s, Z_STRVAL_PP(z_name), z_value ?
+encoded_value : );
if (expires 0) {
strcat(cookie, ; expires=);
dt = php_std_date(expires);
--
Paul TBBle Hampson
Edit this bug report at http://bugs.php.net/?id=13216edit=1
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
