Re: [PHP-DEV] output/threads aborting

[Shane Caraveo]

Oh, sorry for the last email, didn't see this one yet.  Thanks!
Shane

- Original Message -
From: "Andi Gutmans" <[EMAIL PROTECTED]>
To: "Shane Caraveo" <[EMAIL PROTECTED]>; "php-dev mailinglist"
<[EMAIL PROTECTED]>
Sent: Wednesday, May 23, 2001 9:57 AM
Subject: Re: [PHP-DEV] output/threads aborting


> Shane,
>
> Please try the latest CVS. I commited a patch.
>
> Andi
>
> At 03:48 PM 5/22/2001 -0700, Shane Caraveo wrote:
> >Hello everyone,
> >
> >With the current CVS debug_ts build I'm getting an abort in the TSRM
> >library.  I've tracked this down to php_module_startup() in main.c.  The
> >call to php_output_startup() on line 783 accesses thread specific data,
> >however the output module is not started (thus no thread data alocated)
> >until php_startup_internal_extensions() is called on line 873.  Simply
> >moving the call to php_output_startup, but it looks like this might need
to
> >happen before that point in startup.  I don't want to commit that change
> >without somebody a bit more knowlegable on the output stuff looks into
this.
> >
> >Shane
> >
> >
> >
> >--
> >PHP Development Mailing List <http://www.php.net/>
> >To unsubscribe, e-mail: [EMAIL PROTECTED]
> >For additional commands, e-mail: [EMAIL PROTECTED]
> >To contact the list administrators, e-mail: [EMAIL PROTECTED]
>
>
> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> To contact the list administrators, e-mail: [EMAIL PROTECTED]
>
>


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] output/threads aborting

[Shane Caraveo]

> >With the current CVS debug_ts build I'm getting an abort in the TSRM
> >library.  I've tracked this down to php_module_startup() in main.c.  The
>
> This is probably due to my patch yesterday of moving the output
> initialization from GINIT to MINIT.
> In php_module_startup() can you try moving php_output_startup() after
> php_startup_internal_extensions() and see if things are working.
> If not then please revert my patch from yesterday and I will take another
> look at what can be done.
>

That is what I did to get things working, and for anything I am doing, it is
working, but I have not done any testing to prove it's the best fix.  Shall
I commit the change?

Shane



-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] output/threads aborting

[Andi Gutmans]

Shane,

Please try the latest CVS. I commited a patch.

Andi

At 03:48 PM 5/22/2001 -0700, Shane Caraveo wrote:
>Hello everyone,
>
>With the current CVS debug_ts build I'm getting an abort in the TSRM
>library.  I've tracked this down to php_module_startup() in main.c.  The
>call to php_output_startup() on line 783 accesses thread specific data,
>however the output module is not started (thus no thread data alocated)
>until php_startup_internal_extensions() is called on line 873.  Simply
>moving the call to php_output_startup, but it looks like this might need to
>happen before that point in startup.  I don't want to commit that change
>without somebody a bit more knowlegable on the output stuff looks into this.
>
>Shane
>
>
>
>--
>PHP Development Mailing List 
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>To contact the list administrators, e-mail: [EMAIL PROTECTED]


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] output/threads aborting

[Andi Gutmans]

At 03:48 PM 5/22/2001 -0700, Shane Caraveo wrote:
>Hello everyone,
>
>With the current CVS debug_ts build I'm getting an abort in the TSRM
>library.  I've tracked this down to php_module_startup() in main.c.  The
>call to php_output_startup() on line 783 accesses thread specific data,
>however the output module is not started (thus no thread data alocated)
>until php_startup_internal_extensions() is called on line 873.  Simply
>moving the call to php_output_startup, but it looks like this might need to
>happen before that point in startup.  I don't want to commit that change
>without somebody a bit more knowlegable on the output stuff looks into this.

This is probably due to my patch yesterday of moving the output 
initialization from GINIT to MINIT.
In php_module_startup() can you try moving php_output_startup() after 
php_startup_internal_extensions() and see if things are working.
If not then please revert my patch from yesterday and I will take another 
look at what can be done.

Thanks,

Andi


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] output/threads aborting

[Shane Caraveo]

Hello everyone,

With the current CVS debug_ts build I'm getting an abort in the TSRM
library.  I've tracked this down to php_module_startup() in main.c.  The
call to php_output_startup() on line 783 accesses thread specific data,
however the output module is not started (thus no thread data alocated)
until php_startup_internal_extensions() is called on line 873.  Simply
moving the call to php_output_startup, but it looks like this might need to
happen before that point in startup.  I don't want to commit that change
without somebody a bit more knowlegable on the output stuff looks into this.

Shane



-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]