Re: [PHP-DEV] Re: Register Shutdown Function for Apache

2003-01-28 Thread Derick Rethans
On Tue, 28 Jan 2003, Zeev Suraski wrote:

 Your latest patch seems to be in the right direction (admittedly I haven't 
 reviewed it until now).  A couple of random points:
 
 - It sounds dangerous to me to move php_request_shutdown() to be called 
 from Apache's shutdown without further inspection.  At least one thing 
 comes to mind - won't it screw up output buffers (they're supposed to 
 autoflush on shutdown, and if I'm not mistaken, this autoflush will now 
 happen when the connection is already closed)?  Possibly some other things too.
 - Once we're all happy with the patch, we need to decide what to do with 
 it.  Right now, there are no plans to release any further 4.x versions, 
 except for bug fixes.  And the question arises - should this change be in a 
 bugfix release or not.  It certainly has potential to screw things up.

I don't favor merging this to the PHP_4_3 branch, as it seems a huge 
change. (And it's broken for quite some time anyway).

Derick

-- 

-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-DEV] Re: Register Shutdown Function for Apache

2003-01-28 Thread Brian Moon
You are correct.  The output buffer is not auto-flushed with this patch.

Brian.
dealnews.com

- Original Message -
From: Zeev Suraski [EMAIL PROTECTED]
To: Joseph Tate [EMAIL PROTECTED]
Cc: Php-Dev List [EMAIL PROTECTED]; PHP Group [EMAIL PROTECTED]
Sent: Tuesday, January 28, 2003 3:16 AM
Subject: [PHP-DEV] Re: Register Shutdown Function for Apache


| Joseph,
|
| Your latest patch seems to be in the right direction (admittedly I haven't
| reviewed it until now).  A couple of random points:
|
| - It sounds dangerous to me to move php_request_shutdown() to be called
| from Apache's shutdown without further inspection.  At least one thing
| comes to mind - won't it screw up output buffers (they're supposed to
| autoflush on shutdown, and if I'm not mistaken, this autoflush will now
| happen when the connection is already closed)?  Possibly some other things
too.
| - Once we're all happy with the patch, we need to decide what to do with
| it.  Right now, there are no plans to release any further 4.x versions,
| except for bug fixes.  And the question arises - should this change be in
a
| bugfix release or not.  It certainly has potential to screw things up.
|
| Zeev
|
| At 18:38 23/01/2003, Joseph Tate wrote:
| I can have the patches ready to go in a very short amount of time.  I'll
| work on and post them if I can be reasonably sure they'll be committed.
I'm
| tired of spinning my wheels with this though.  I've got a personally
patched
| version of 4.3.0 that will be going into production in a few weeks, so
I'm
| confident in the changes.  I'd like to not use a personally patched
version
| of PHP the next time a release comes down the pipe though.  As a
reminder,
| this patch will fix bug #15209 without breaking the new functionality of
| register_shutdown_function under !apache systems.
| 
| I've appealed to the [EMAIL PROTECTED] for karma to apply them myself, but
for
| the last two weeks have heard nothing either negative or positive.
| 
| Joseph
|
|
| --
| PHP Development Mailing List http://www.php.net/
| To unsubscribe, visit: http://www.php.net/unsub.php
|
|
|


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-DEV] Re: Register Shutdown Function for Apache

2003-01-28 Thread Brian Moon
It also does not send the headers if there is not content.

?php

header(Location: http://spidey.dealnews.com/;);

exit();

?



Document Contains No Data.



Brian.

dealnews.com


- Original Message -
From: Brian Moon [EMAIL PROTECTED]
To: [EMAIL PROTECTED]; Joseph Tate [EMAIL PROTECTED]
Cc: Php-Dev List [EMAIL PROTECTED]; PHP Group [EMAIL PROTECTED]
Sent: Tuesday, January 28, 2003 10:16 AM
Subject: Re: [PHP-DEV] Re: Register Shutdown Function for Apache


| You are correct.  The output buffer is not auto-flushed with this patch.
|
| Brian.
| dealnews.com
|
| - Original Message -
| From: Zeev Suraski [EMAIL PROTECTED]
| To: Joseph Tate [EMAIL PROTECTED]
| Cc: Php-Dev List [EMAIL PROTECTED]; PHP Group [EMAIL PROTECTED]
| Sent: Tuesday, January 28, 2003 3:16 AM
| Subject: [PHP-DEV] Re: Register Shutdown Function for Apache
|
|
| | Joseph,
| |
| | Your latest patch seems to be in the right direction (admittedly I
haven't
| | reviewed it until now).  A couple of random points:
| |
| | - It sounds dangerous to me to move php_request_shutdown() to be called
| | from Apache's shutdown without further inspection.  At least one thing
| | comes to mind - won't it screw up output buffers (they're supposed to
| | autoflush on shutdown, and if I'm not mistaken, this autoflush will now
| | happen when the connection is already closed)?  Possibly some other
things
| too.
| | - Once we're all happy with the patch, we need to decide what to do with
| | it.  Right now, there are no plans to release any further 4.x versions,
| | except for bug fixes.  And the question arises - should this change be
in
| a
| | bugfix release or not.  It certainly has potential to screw things up.
| |
| | Zeev
| |
| | At 18:38 23/01/2003, Joseph Tate wrote:
| | I can have the patches ready to go in a very short amount of time.
I'll
| | work on and post them if I can be reasonably sure they'll be committed.
| I'm
| | tired of spinning my wheels with this though.  I've got a personally
| patched
| | version of 4.3.0 that will be going into production in a few weeks, so
| I'm
| | confident in the changes.  I'd like to not use a personally patched
| version
| | of PHP the next time a release comes down the pipe though.  As a
| reminder,
| | this patch will fix bug #15209 without breaking the new functionality
of
| | register_shutdown_function under !apache systems.
| | 
| | I've appealed to the [EMAIL PROTECTED] for karma to apply them myself, but
| for
| | the last two weeks have heard nothing either negative or positive.
| | 
| | Joseph
| |
| |
| | --
| | PHP Development Mailing List http://www.php.net/
| | To unsubscribe, visit: http://www.php.net/unsub.php
| |
| |
| |
|
|
| --
| PHP Development Mailing List http://www.php.net/
| To unsubscribe, visit: http://www.php.net/unsub.php
|
|
|


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




RE: [PHP-DEV] Re: Register Shutdown Function for Apache

2003-01-28 Thread Joseph Tate
Then, could we add a sapi_flush()/ob_flush() call at the end of
apache_php_module_main after calling the normal register_shutdown_functions?
What else might have problems?

Joseph

 -Original Message-
 From: Brian Moon [mailto:[EMAIL PROTECTED]]
 Sent: Tuesday, January 28, 2003 11:23 AM
 To: Brian Moon; [EMAIL PROTECTED]; Joseph Tate
 Cc: Php-Dev List; PHP Group
 Subject: Re: [PHP-DEV] Re: Register Shutdown Function for Apache


 It also does not send the headers if there is not content.

 ?php

 header(Location: http://spidey.dealnews.com/;);

 exit();

 ?



 Document Contains No Data.



 Brian.

 dealnews.com




-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




RE: [PHP-DEV] Re: Register Shutdown Function for Apache

2003-01-28 Thread Zeev Suraski
At 19:54 28/01/2003, Joseph Tate wrote:

Then, could we add a sapi_flush()/ob_flush() call at the end of
apache_php_module_main after calling the normal register_shutdown_functions?


Yeah, something along these lines.


What else might have problems?


Might is a powerful word :)

Zeev


--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-DEV] Re: Register Shutdown Function for Apache

2003-01-28 Thread Brian Moon
Give me a patch and I will tell you. ;)

Brian Moon
dealnews.com


- Original Message -
From: Zeev Suraski [EMAIL PROTECTED]
To: Joseph Tate [EMAIL PROTECTED]
Cc: Brian Moon [EMAIL PROTECTED]; Php-Dev List
[EMAIL PROTECTED]; PHP Group [EMAIL PROTECTED]
Sent: Tuesday, January 28, 2003 4:03 PM
Subject: RE: [PHP-DEV] Re: Register Shutdown Function for Apache


| At 19:54 28/01/2003, Joseph Tate wrote:
| Then, could we add a sapi_flush()/ob_flush() call at the end of
| apache_php_module_main after calling the normal
register_shutdown_functions?
|
| Yeah, something along these lines.
|
| What else might have problems?
|
| Might is a powerful word :)
|
| Zeev
|
|
|


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php