Re: [PHP-DEV] RC3
On Thu, 11 Apr 2002, Andrey Hristov wrote: Does the RC3 will be available tonight(GMT+3) or it is scheduled for tommorow's night? At around Friday 12th, 22:00 GMT+2. Derick --- Did I help you? Consider a gift: http://www.amazon.co.uk/exec/obidos/registry/SLCB276UZU8B --- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] RC3
On Wed, Oct 03, 2001 at 11:24:08PM -0700, Rasmus Lerdorf wrote: Ok, I have merged it and tested it on one of my servers. Didn't break Thanks. Now I see your commit and the 4.0.7 branch, maybe I made some silly mistake or the cvsweb page for ldap.c was cached or something. anything. But where exactly is the ldap_result_entry freed? I am guessing that it is actually the same memory as ldap_result points to and when we free ldap_result there is no need to free the nested ldap_result_entry? Is this true for nsldap as well? Seems logical though. Yes, that is my conclusion. I got crashes with OpenLDAP libs when first freeing individual entries and next freeing the entire result. There could be differences between libs but I suspect it is common to not copy result_entries out of the result. For now I would rather see leaks with some libs than crashes with OpenLDAP libs. If there are differences I'll try to make it better for 4.0.8. Thanks Rasmus, Stig -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Thursday 04 October 2001 1:04 am, Zeev Suraski wrote: Finally, it's out. www.php.net/~zeev/php-4.0.7RC3.tar.gz Builds fine on NT4 as cgi (Release_TS_Inline) and phpinfo works ok under IIS. When I try to build the test suite I get the following output - I don't know if this means that things went ok or not! Configuration: testsuite - Win32 Release_TS Build : warning : failed to (or don't know how to) build 'E:\F\php\php-4.0.7RC3\results.txt' Running Testsuite, please wait... testsuite - 0 error(s), 40 warning(s) -- Phil Driscoll -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Thursday 04 October 2001 1:04 am, Zeev Suraski wrote: Finally, it's out. www.php.net/~zeev/php-4.0.7RC3.tar.gz Built and tested on SuSE 7.2 as apache module with Apache 1.3.20 --with-apxs=/usr/local/httpd/bin/apxs --with-mysql=/usr/local/mysql --with-gmp=/usr/local/lib/gmp All my stuff, Phorum and phpMyAdmin seems to work fine. here's the output of the fails in make test Running tests in /home/phil/php-4.0.7RC3//ext/standard/tests/file = File type functions (001.phpt) ... failed Running tests in /home/phil/php-4.0.7RC3//ext/standard/tests/math = Simple math tests (001.phpt) ... failed Various pow() tests (pow.phpt) ... failed Running tests in /home/phil/php-4.0.7RC3//ext/standard/tests/time = microtime() function (001.phpt) ... failed strtotime() function (002.phpt) ... failed Running tests in /home/phil/php-4.0.7RC3//pear/DB/tests === DB_Error/DB_Warning test (db_error.phpt) ... failed DB configurable error handler test (db_error2.phpt) ... failed DB::factory test (db_factory.phpt) ... failed DB::isManip test (db_ismanip.phpt) ... failed DB::parseDSN test (db_parsedsn.phpt) ... failed Running tests in /home/phil/php-4.0.7RC3//pear/XML/tests XML Parser: parse simple string (001.phpt) ... failed XML Parser: parse from file (002.phpt) ... failed XML Parser: parse from file resource (003.phpt) ... failed XML Parser: error class (004.phpt) ... failed XML Parser: mixing character encodings (005.phpt) ... failed Running tests in /home/phil/php-4.0.7RC3//pear/tests PEAR constructor/destructor test (pear1.phpt)... failed PEAR_Error test (pear_error.phpt) ... failed PEAR_Error in die mode (pear_error2.phpt) ... failed PEAR default error handling (pear_error3.phpt) ... failed Running tests in /home/phil/php-4.0.7RC3//tests/lang OO Bug Test (Bug #7515) (029.phpt) ... failed -- Phil Driscoll -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Thursday 04 October 2001 11:29 am, Phil Driscoll wrote: All my stuff, Phorum and phpMyAdmin seems to work fine. This shoulc have read All my stuff, plus Phorum and phpMyAdmin seem to work fine. I wasn't trying to claim credit for Phorum and phpMyAdmin :) -- Phil Driscoll -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
Hi, found one problem compiling the ZIP extension, fixed in CVS. Derick On Thu, 4 Oct 2001, Zeev Suraski wrote: Finally, it's out. www.php.net/~zeev/php-4.0.7RC3.tar.gz -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Thu, Oct 04, 2001 at 02:04:27AM +0200, Zeev Suraski wrote: Finally, it's out. www.php.net/~zeev/php-4.0.7RC3.tar.gz I see that my LDAP fix didn't make it. Can someone please explain how this works? I can't see any tags for ldap.c since May but ldap.c in RC3 is 1.94, I would like 1.96 to be in the release. Could someone other than me please test LDAP in RC3 and also try with ldap.c 1.96? As said earlier I can easily make things crash with 1.94, 1.96 should fix it with no side effects. It would still be good if people tested it though. Stig -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] RC3
Ok, I have merged it and tested it on one of my servers. Didn't break anything. But where exactly is the ldap_result_entry freed? I am guessing that it is actually the same memory as ldap_result points to and when we free ldap_result there is no need to free the nested ldap_result_entry? Is this true for nsldap as well? Seems logical though. -Rasmus On Thu, 4 Oct 2001, Stig Venaas wrote: On Thu, Oct 04, 2001 at 02:04:27AM +0200, Zeev Suraski wrote: Finally, it's out. www.php.net/~zeev/php-4.0.7RC3.tar.gz I see that my LDAP fix didn't make it. Can someone please explain how this works? I can't see any tags for ldap.c since May but ldap.c in RC3 is 1.94, I would like 1.96 to be in the release. Could someone other than me please test LDAP in RC3 and also try with ldap.c 1.96? As said earlier I can easily make things crash with 1.94, 1.96 should fix it with no side effects. It would still be good if people tested it though. Stig -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] RC3
On Mon, Sep 24, 2001 at 10:40:04PM +0200, Zeev Suraski wrote: If it's a bug fix you believe to be important and the chances, in your opinion, of it screwing things up more than it fixes are slim, go ahead and commit it... Maybe I've already done what's needed, I'm not quite sure how this works. I thought there would be a php_4_0_7 tag for ldap.c but I can't find any. Does that mean that what I added will be in? In RC2 1.94 of ldap.c is used, my change is 1.96 and 1.95 is just vim cosmetics, no code change. So, my guess is that latest ldap.c will be in 4.0.7 since no branch. Let me know if I should do anything, and sorry for my poor CVS skills. Are there any LDAP testing done on the RCs? I'm surprised no problem was detected. We do have a set of automated tests, right? I can make some LDAP tests if needed. One problem is that there are many LDAP APIs, the best is perhaps to test with OpenLDAP 2 which I think is the most widely used. Stig -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Wed, Sep 19, 2001 at 10:05:24PM +0200, Stig Venaas wrote: On Tue, Sep 18, 2001 at 06:13:54PM +0300, Zeev Suraski wrote: Does anybody still have anything pending for RC3? There seems to be a serious LDAP bug. For instance the following simple script crashes (you should be able to test it): I never got any feedback on this, what is the right procedure? Do I ask you Zeev or anyone else if this can be done, or am I supposed myself to commit changes with the right tag? At least I think this fix is important, would be nice to get some confirmation that it gets in, or reasons for not doing it. Stig -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] RC3
If it's a bug fix you believe to be important and the chances, in your opinion, of it screwing things up more than it fixes are slim, go ahead and commit it... Zeev At 14:20 24-09-01, Stig Venaas wrote: On Wed, Sep 19, 2001 at 10:05:24PM +0200, Stig Venaas wrote: On Tue, Sep 18, 2001 at 06:13:54PM +0300, Zeev Suraski wrote: Does anybody still have anything pending for RC3? There seems to be a serious LDAP bug. For instance the following simple script crashes (you should be able to test it): I never got any feedback on this, what is the right procedure? Do I ask you Zeev or anyone else if this can be done, or am I supposed myself to commit changes with the right tag? At least I think this fix is important, would be nice to get some confirmation that it gets in, or reasons for not doing it. Stig -- PHP Quality Assurance Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Tue, Sep 18, 2001 at 06:13:54PM +0300, Zeev Suraski wrote: Does anybody still have anything pending for RC3? There seems to be a serious LDAP bug. For instance the following simple script crashes (you should be able to test it): $ds=ldap_connect(garibaldi.venaas.no); ldap_bind($ds,,); $sr=ldap_search($ds,dc=venaas,dc=no, relativeDomainname=www); ldap_first_entry($ds, $sr); I just made the following change in ldap.c (1.96) - le_result_entry = zend_register_list_destructors_ex(_free_ldap_result, NULL, ldap result entry, module_number); + le_result_entry = zend_register_list_destructors_ex(NULL, NULL, ldap result +entry, module_number); to fix it. Someone added the destructor the last few months. It leads to a crash because the same memory is freed twice (or more, depends on script). I don't think it is needed, please let me know if you think otherwise. I would rather have a memory leak than a crash anyway. This should be a safe change, it makes things like they used to be until a few months ago. So, I advise changing this in RC3. Stig -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
Hello, On Tue, Sep 18, 2001 at 06:13:54PM +0300, Zeev Suraski wrote: Does anybody still have anything pending for RC3? I've one little thing with mcrypt, which needs some little investigation. Will have that sorted out before the weekend though. (The prob is that either libmcrypt is opening a .la file, or that the extension does it wrong, there are also bugs about this: failed to initialize mcrypt module). Another small thing I like to change is the level of errors with some functions, but that has of course no impacts on code flow. regards, Derick -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
I'm also investigating (well, fixing) a scanner thread safety issue. At 00:45 20-09-01, Derick Rethans wrote: Hello, On Tue, Sep 18, 2001 at 06:13:54PM +0300, Zeev Suraski wrote: Does anybody still have anything pending for RC3? I've one little thing with mcrypt, which needs some little investigation. Will have that sorted out before the weekend though. (The prob is that either libmcrypt is opening a .la file, or that the extension does it wrong, there are also bugs about this: failed to initialize mcrypt module). Another small thing I like to change is the level of errors with some functions, but that has of course no impacts on code flow. regards, Derick -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Tue, 18 Sep 2001, Zeev Suraski wrote: Does anybody still have anything pending for RC3? Do you want Universe included in RC3? http://universe.2good.nu/ Regards, David -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Tue, 18 Sep 2001, David Eriksson wrote: On Tue, 18 Sep 2001, Zeev Suraski wrote: Does anybody still have anything pending for RC3? Do you want Universe included in RC3? http://universe.2good.nu/ No new features please. RCs are purely intended for cutting down the number of bugs. - Sascha Experience IRCG http://schumann.cx/http://schumann.cx/ircg -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3
On Tue, 18 Sep 2001, Sascha Schumann wrote: No new features please. RCs are purely intended for cutting down the number of bugs. NP. I just realized that it would be nice to have Universe included in PHP 4.0.7... but I know it's a little late now... :-/ -\- David Eriksson -/- An expert in a particular computer language is really an expert in the work-arounds necessary to use this language to perform useful work. - Richard B. Johnson -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3?
Jani Taskinen wrote: Should I merge that fix for arg_separator thingie into the 4_0_5 branch before you create RC3 ? +1 (Jani sent me that patch a week ago or so and I ran into no problems here) -- sebastian bergmann[EMAIL PROTECTED] http://www.sebastian-bergmann.de bonn.phpug.de | www.php.net | www.phpOpenTracker.de | www.titanchat.de -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3?
On Tue, 27 Mar 2001, Sebastian Bergmann wrote: Jani Taskinen wrote: Should I merge that fix for arg_separator thingie into the 4_0_5 branch before you create RC3 ? +1 (Jani sent me that patch a week ago or so and I ran into no problems here) AFAIK he just committed it (today) Derick Rethans - PHP: Scripting the Web - www.php.net - [EMAIL PROTECTED] SRM: Site Resource Manager - www.vl-srm.net - -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] RC3?
Derick Rethans wrote: AFAIK he just committed it (today) Yes, but he sent it tome a week ago or so nevertheless :) -- sebastian bergmann[EMAIL PROTECTED] http://www.sebastian-bergmann.de bonn.phpug.de | www.php.net | www.phpOpenTracker.de | www.titanchat.de -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] RC3?
On Tue, 27 Mar 2001, Sebastian Bergmann wrote: Derick Rethans wrote: AFAIK he just committed it (today) Yes, but he sent it tome a week ago or so nevertheless :) If nobody objects I will merge the fix into the 4_0_5 branch later this evening. (hopefully before Zeev creates the RC3..) --Jani -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
