Re: [PHP-DEV] Re: gmp_init with a base argument

2001-08-05 Thread Stanislav Malyshev
TA>> OK. Here is a suggestion for an adjustment in math.c. The patch TA>> could probably be improved: The check for strings with more than TA>> 31 chars should probably be less hard-coded, but I'm not sure TA>> which contant to use for determining maximum size of a LONG. I have made a bit more ge

Re: [PHP-DEV] Re: gmp_init with a base argument

2001-08-05 Thread Troels Arvin
On Thu, 02 Aug 2001 19:16:26 +0200, "Stanislav Malyshev" <[EMAIL PROTECTED]> wrote: > TA>> By the way: > TA>> I think that the decbin() function should bail out if you pass it > a TA>> value which contains more bits than PHP is able to handle. - > Perhaps TA>> with a hint about using GMP for larg

Re: [PHP-DEV] Re: gmp_init with a base argument

2001-08-05 Thread Troels Arvin
On Thu, 02 Aug 2001 19:16:26 +0200, "Stanislav Malyshev" <[EMAIL PROTECTED]> wrote: > on the quick glance your patch looks OK. OK. It seems that I don't have sufficient karma. I tried to commit the below patch with the following commit message: (gmp_init) Added extra (optional) argument to gmp_i

Re: [PHP-DEV] Re: gmp_init with a base argument

2001-08-02 Thread Stanislav Malyshev
TA>> Does the lack of comments mean that I may commit the patch? (I think TA>> that I still have CVS access.) I was pretty busy last week, sorry, so I couldn't look at it thoroughly. But on the quick glance your patch looks OK. TA>> By the way: TA>> I think that the decbin() function should bail