On Mon, 30 Jul 2001, Colin Viebrock wrote:
>Anyone else here notice that the additional information "blocks" for modules
>compiled into PHP is pretty much sorted in reverse alphabetically order?
>
>Just wondering if we could switch it to forward alpha order, if possible.
>And why zlib seems to come up in the wrong location.
It's not even hard thing to do.. :)
Attached patch does this. It also sorts the './php -m' listing.
--Jani
Index: ext/standard/info.c
===================================================================
RCS file: /repository/php4/ext/standard/info.c,v
retrieving revision 1.147
diff -u -r1.147 info.c
--- ext/standard/info.c 31 Jul 2001 04:53:50 -0000 1.147
+++ ext/standard/info.c 1 Aug 2001 00:33:21 -0000
@@ -243,6 +243,7 @@
}
zend_ini_sort_entries(TSRMLS_C);
+ zend_module_sort_entries(TSRMLS_C);
if (flag & PHP_INFO_CONFIGURATION) {
php_info_print_hr();
Index: sapi/cgi/cgi_main.c
===================================================================
RCS file: /repository/php4/sapi/cgi/cgi_main.c,v
retrieving revision 1.125
diff -u -r1.125 cgi_main.c
--- sapi/cgi/cgi_main.c 31 Jul 2001 07:09:48 -0000 1.125
+++ sapi/cgi/cgi_main.c 1 Aug 2001 00:33:21 -0000
@@ -585,6 +585,7 @@
SG(headers_sent) = 1;
php_printf("Running PHP %s\n%s\n", PHP_VERSION
, get_zend_version());
php_printf("[PHP Modules]\n");
+ zend_module_sort_entries(TSRMLS_C);
zend_hash_apply_with_argument(&module_registry, (apply_func_arg_t) _print_module_info,
NULL TSRMLS_CC);
php_printf("\n[Zend Modules]\n");
/*
zend_llist_apply_with_argument(&zend_extensions, (llist_apply_with_arg_func_t)
_print_module_info, NULL TSRMLS_CC); */
Index: Zend/zend_ini.c
===================================================================
RCS file: /repository/Zend/zend_ini.c,v
retrieving revision 1.15
diff -u -r1.15 zend_ini.c
--- Zend/zend_ini.c 2001/07/31 06:07:25 1.15
+++ Zend/zend_ini.c 2001/08/01 00:33:08
@@ -122,6 +122,11 @@
zend_hash_sort(&EG(ini_directives), qsort, ini_key_compare, 0);
}
+ZEND_API void zend_module_sort_entries(TSRMLS_D)
+{
+ zend_hash_sort(&module_registry, qsort, ini_key_compare, 0);
+}
+
/*
* Registration / unregistration
*/
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
