Re: [PSR 17] Define how the stream is created in http messages

2019-01-29 Thread Rasmus Schultz
I've updated my PR with this commit: https://github.com/php-fig/fig-standards/pull/1134/commits/983002eb09fb961bccb0c77250e39af498c313be Thanks for bringing this up, Oscar! Glad you caught this :-) On Tuesday, January 29, 2019 at 5:01:00 PM UTC+1, Oscar Otero wrote: > > Yes, I think that express

Re: Proposal idea: PDO Provider

2019-01-29 Thread Larry Garfield
I guess I'm unclear what the use case is. What would a consumer of this object do with it, and how, and why? Show us some code examples of how you'd use it in practice. --Larry Garfield On Monday, January 28, 2019 10:05:21 AM CST Rasmus Schultz wrote: > Yes, the username is for debugging purpo

Re: [VOTE][WG] PSR-12 Readiness Vote

2019-01-29 Thread Michael Cullum
+1 -- Michael C On Tue, 29 Jan 2019 at 05:47, Diego S Mota wrote: > +1 > > On Tue, Jan 29, 2019 at 8:46 AM 'Alexander Makarov' via PHP Framework > Interoperability Group wrote: > >> +1 >> >> On Monday, January 28, 2019 at 8:25:37 PM UTC+3, Korvin Szanto wrote: >>> >>> Hi Everyone, >>> After a

Re: [PSR 17] Define how the stream is created in http messages

2019-01-29 Thread Oscar Otero
Yes, I think that expresses it very well. On Tue, 29 Jan 2019 at 16:51, Rasmus Schultz wrote: > > The spec should focus only in the fact that, any new stream created with > PSR-17 (directly using $streamFactory->createStream() or though a request > or response message) must be empty and writable

Re: [PSR 17] Define how the stream is created in http messages

2019-01-29 Thread Rasmus Schultz
> The spec should focus only in the fact that, any new stream created with PSR-17 (directly using $streamFactory->createStream() or though a request or response message) must be empty and writable. Okay, so just this then? "The created instance MUST return an empty body-stream in read/write mode.

Re: Proposal: Adopt Code Manifesto

2019-01-29 Thread Chuck Burgess
Looking over both the manifesto and the covenant, I didn't really notice anything that would conflict between the two, if we wanted to simply include *both*... doing so would just be presenting an intersection of their requirements. Is that too much verbiage overall? Maybe just link to both, sinc

Re: [VOTE][WG] PSR-12 Readiness Vote

2019-01-29 Thread Diego S Mota
+1 On Tue, Jan 29, 2019 at 8:46 AM 'Alexander Makarov' via PHP Framework Interoperability Group wrote: > +1 > > On Monday, January 28, 2019 at 8:25:37 PM UTC+3, Korvin Szanto wrote: >> >> Hi Everyone, >> After a few revisions and additions, the PSR-12 working group is again >> ready to transitio

Re: [PSR 17] Define how the stream is created in http messages

2019-01-29 Thread Oscar Otero
Hi. To me, this is a problem of PSR-17, not PSR-7. What I'm asking is being sure that whenever I create a new response, I can write the body: $response = $factory->createResponse(); $response->getBody()->write('Ok'); Errors like "Fatal Error - Too many open files" are out of scope because it's an

Re: [VOTE][WG] PSR-12 Readiness Vote

2019-01-29 Thread 'Alexander Makarov' via PHP Framework Interoperability Group
+1 On Monday, January 28, 2019 at 8:25:37 PM UTC+3, Korvin Szanto wrote: > > Hi Everyone, > After a few revisions and additions, the PSR-12 working group is again > ready to transition out of draft and into review. > > Please do not vote in this thread unless you are listed as a member of the >

Re: [VOTE][WG] PSR-12 Readiness Vote

2019-01-29 Thread Alessandro Lai
+1 (even if you forgot about me :P) Il giorno lunedì 28 gennaio 2019 18:25:37 UTC+1, Korvin Szanto ha scritto: > > Hi Everyone, > After a few revisions and additions, the PSR-12 working group is again > ready to transition out of draft and into review. > > Please do not vote in this thread unless