Re: [PSR-12] Blank line after trait use import statement

2018-04-23 Thread Larry Garfield
I would concur here. The spec should be adapted to clarify that all blank line rules are single-blank-line rules. --Larry Garfield On Sunday, April 22, 2018 9:24:10 PM CDT Joe T. wrote: > i'm not in the WG, but i always restrict to 1 blank line between any two > structures - aside from line

Re: [PSR-12] Blank line after trait use import statement

2018-04-23 Thread Greg Sherwood
The use group I'm talking about is for importing traits and not the use block in the header of the file. In the example file given in that section, these use statements fall into the area denoted by the comment "// ... additional PHP code ..." so I can't see how that section applies to these

Re: [PSR-12] Blank line after trait use import statement

2018-04-23 Thread Alessandro Lai
No, multiple blank lines are not allowed in the current spec. Section 3 refers to a SINGLE blank line: "The header of a PHP file may consist of a number of different blocks. If present, each of the blocks below MUST be separated by a single blank line, and MUST NOT contain a blank line."

Re: [PSR-12] Blank line after trait use import statement

2018-04-22 Thread Joe T.
i'm not in the WG, but i always restrict to 1 blank line between any two structures - aside from line after opening *{* and before closing *}* where no blank line is permitted. Extra blank lines feel like something wasn't finished. It's just... ew. -jlt On Sunday, 22 April 2018 19:52:02

[PSR-12] Blank line after trait use import statement

2018-04-22 Thread Greg Sherwood
Hi, I wrote the PSR-1 and PSR-2 standards for PHP_CodeSniffer and I'm now writing a PSR-12 standard as well. I have a question about this section: 4.2 Using traits > ... > When the class has nothing after the use import statement, the class > closing brace MUST be on the next line after the