Re: [VOTE][PSR-6][Errata] DateTiemInterface handling

2018-02-01 Thread Larry Garfield
On Tuesday, January 30, 2018 3:26:22 AM CST Alessandro Lai wrote: > Review period was called correctly by Larry two weeks > prior: > https://groups.google.com/forum/?fromgroups#!topic/php-fig/IXFXHqi5NLo > > Unfortunately, the reviews came later, so it's up to Larry to decide if he > want to stop

Re: [VOTE][PSR-6][Errata] DateTiemInterface handling

2018-01-30 Thread Alessandro Lai
Review period was called correctly by Larry two weeks prior: https://groups.google.com/forum/?fromgroups#!topic/php-fig/IXFXHqi5NLo Unfortunately, the reviews came later, so it's up to Larry to decide if he want to stop the vote and address those, or go forward. -- You received this message be

Re: [VOTE][PSR-6][Errata] DateTiemInterface handling

2018-01-29 Thread Matthew Weier O'Phinney
-1 from me. There was feedback on that PR that was never addressed, and I tend to agree with the point that was being made. Further, I noticed a few other areas that I feel need more fleshing out. I think this should have had a REVIEW phase before calling for the vote. On Sun, Jan 28, 2018 at 10

Re: [VOTE][PSR-6][Errata] DateTiemInterface handling

2018-01-28 Thread Larry Garfield
+1 --Larry Garfield On Sunday, January 28, 2018 10:38:41 AM CST Larry Garfield wrote: > Welcome, new CC members! Here's your first official duty. :-) > > I hereby call for a vote on merging the following PR: > > https://github.com/php-fig/fig-standards/pull/915 > > This is an errata update fo

[VOTE][PSR-6][Errata] DateTiemInterface handling

2018-01-28 Thread Larry Garfield
Welcome, new CC members! Here's your first official duty. :-) I hereby call for a vote on merging the following PR: https://github.com/php-fig/fig-standards/pull/915 This is an errata update for PSR-6 to clarify how to handle incorrectly typed parameters when a DateTimeInterface object is expe