Re: Service Provider PSR: enhancing ServiceProviderInterface compatibility and performance for major frameworks

2024-02-01 Thread Rasmus Schultz
Changing them is no problem though, it's only in the idea stage. Rasmus On Thu, 1 Feb 2024, 14.10 Adrien Crivelli, wrote: > My 2 cents are in favor to rename the parameter $id into $key, and leave > the methods names alone. > > On Wednesday 31 January 2024 at 23:33:45 UTC+8 Sergei

Re: Service Provider PSR: enhancing ServiceProviderInterface compatibility and performance for major frameworks

2024-02-01 Thread Adrien Crivelli
My 2 cents are in favor to rename the parameter $id into $key, and leave the methods names alone. On Wednesday 31 January 2024 at 23:33:45 UTC+8 Sergei Predvoditelev wrote: > This proposal looks good, and I would like to make a small clarification. > > Arguments "$id" do not agree with the

Re: Service Provider PSR: enhancing ServiceProviderInterface compatibility and performance for major frameworks

2024-01-31 Thread Sergei Predvoditelev
This proposal looks good, and I would like to make a small clarification. Arguments "$id" do not agree with the methods "getServiceKeys()" and "getExtensionKeys()". Maybe rename methods to "getServiceIds()" and "getExtensionIds()"? On Wednesday, January 31, 2024 at 1:58:14 PM UTC+3 Rasmus