[PHP] going blind for looking...need eyes

2009-02-06 Thread Terion Miller 
Need eyes on this query, it is not inserting, I am going to highlight
what/where  I thought the problem is (there is no  )but when I add the  it
then changes the syntax coloring on the rest of the code  in my editor which
makes me wonder if I'm wrong... argh. and either way it's not inserting ...

-
$sql = INSERT INTO admin (UserName, Password, Name, Email, Property,
Department, AddWorkOrder, ;
$sql .= ViewAllWorkOrders, ViewNewOrders, ViewNewArt,
ViewPendingWorkOrders, ViewPendingArtwork, ViewCompletedArt, ;
$sql .= ViewCompletedWorkOrders, SearchWorkOrder, EditWorkOrder,
DelWorkOrder, ChangeStatus, AddEditAdmin;
$sql .= ) VALUES(  '$UserName', '$Password', '$Name', '$Email',
'$Property', '$Department', '$AddWorkOrder', ;
$sql .= '$ViewAllWorkOrders', '$ViewNewOrders', '$ViewNewArt',
'$ViewPendingWorkOrders', '$ViewPendingArtwork', ;
$sql .= '$ViewCompletedArt', '$ViewCompletedWorkOrders',
'$SearchWorkOrder', '$EditWorkOrder', '$DelWorkOrder',  ;
$sql .= '$ChangeStatus', '$AddEditAdmin', '$ViewMyOrders');
$result = mysql_query($sql);

Re: [PHP] going blind for looking...need eyes

2009-02-06 Thread Daniel Brown 
On Fri, Feb 6, 2009 at 12:44, Terion Miller webdev.ter...@gmail.com wrote:

 -
 $sql = INSERT INTO admin (UserName, Password, Name, Email, Property,
 Department, AddWorkOrder, ;
$sql .= ViewAllWorkOrders, ViewNewOrders, ViewNewArt,
 ViewPendingWorkOrders, ViewPendingArtwork, ViewCompletedArt, ;
$sql .= ViewCompletedWorkOrders, SearchWorkOrder, EditWorkOrder,
 DelWorkOrder, ChangeStatus, AddEditAdmin;
$sql .= ) VALUES(  '$UserName', '$Password', '$Name', '$Email',
 '$Property', '$Department', '$AddWorkOrder', ;
$sql .= '$ViewAllWorkOrders', '$ViewNewOrders', '$ViewNewArt',
 '$ViewPendingWorkOrders', '$ViewPendingArtwork', ;
$sql .= '$ViewCompletedArt', '$ViewCompletedWorkOrders',
 '$SearchWorkOrder', '$EditWorkOrder', '$DelWorkOrder',  ;
$sql .= '$ChangeStatus', '$AddEditAdmin', '$ViewMyOrders');
$result = mysql_query($sql);

1.) You have 19 columns named, but 20 values given.
2.) Make sure you use mysql_real_escape_string() or otherwise
sanitize the data.
3.) When you run into similar issues, use ?php mysql_query($sql)
or die(mysql_error()); ?

-- 
/Daniel P. Brown
daniel.br...@parasane.net || danbr...@php.net
http://www.parasane.net/ || http://www.pilotpig.net/
Unadvertised dedicated server deals, too low to print - email me to find out!

-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP] going blind for looking...need eyes

2009-02-06 Thread Jochem Maas 
Daniel Brown schreef:
 On Fri, Feb 6, 2009 at 12:44, Terion Miller webdev.ter...@gmail.com wrote:
 -
 $sql = INSERT INTO admin (UserName, Password, Name, Email, Property,
 Department, AddWorkOrder, ;
$sql .= ViewAllWorkOrders, ViewNewOrders, ViewNewArt,
 ViewPendingWorkOrders, ViewPendingArtwork, ViewCompletedArt, ;
$sql .= ViewCompletedWorkOrders, SearchWorkOrder, EditWorkOrder,
 DelWorkOrder, ChangeStatus, AddEditAdmin;
$sql .= ) VALUES(  '$UserName', '$Password', '$Name', '$Email',
   ^-- does the lack of space here screw things up?

 '$Property', '$Department', '$AddWorkOrder', ;
$sql .= '$ViewAllWorkOrders', '$ViewNewOrders', '$ViewNewArt',
 '$ViewPendingWorkOrders', '$ViewPendingArtwork', ;
$sql .= '$ViewCompletedArt', '$ViewCompletedWorkOrders',
 '$SearchWorkOrder', '$EditWorkOrder', '$DelWorkOrder',  ;
$sql .= '$ChangeStatus', '$AddEditAdmin', '$ViewMyOrders');
$result = mysql_query($sql);
 
 1.) You have 19 columns named, but 20 values given.
 2.) Make sure you use mysql_real_escape_string() or otherwise
 sanitize the data.
 3.) When you run into similar issues, use ?php mysql_query($sql)
 or die(mysql_error()); ?

good points from Dan, I suggest additionally something a little more
vague and possibly not to your taste ... but ... try making your
query a little more readable:

$sql = INSERT INTO admin (
 UserName, Password, Name, Email, Property, Department,
 AddWorkOrder, ViewAllWorkOrders, ViewNewOrders, ViewNewArt,
 ViewPendingWorkOrders, ViewPendingArtwork, ViewCompletedArt,
 ViewCompletedWorkOrders, SearchWorkOrder, EditWorkOrder,
 DelWorkOrder, ChangeStatus, AddEditAdmin
) VALUES (
 '$UserName', '$Password', '$Name', '$Email', '$Property', 
'$Department',
 '$AddWorkOrder', '$ViewAllWorkOrders', '$ViewNewOrders', 
'$ViewNewArt',
 '$ViewPendingWorkOrders', '$ViewPendingArtwork', 
'$ViewCompletedArt',
 '$ViewCompletedWorkOrders', '$SearchWorkOrder', 
'$EditWorkOrder',
 '$DelWorkOrder', '$ChangeStatus', '$AddEditAdmin', 
'$ViewMyOrders'
);

there are a zillion variations on this theme (e.g. using HEREDOC syntax and/or 
putting each field  value
on a single line, which is sometimes helpful in counting whether no. of fields 
matches no. of values)

 


-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP] going blind for looking...need eyes

2009-02-06 Thread Daniel Brown 
On Fri, Feb 6, 2009 at 13:03, Jochem Maas joc...@iamjochem.com wrote:

 there are a zillion variations on this theme (e.g. using HEREDOC syntax 
 and/or putting each field  value

That's right, when reading the OP's email, there was meant to be a
#4 as well.

4.) Use HEREDOC syntax:

?php
$sql =SQL
INSERT INTO table_name(column_a,column_b,column_c)
VALUES('{$value_a}','{$value_b}','{$value_c}')
SQL;
?

-- 
/Daniel P. Brown
daniel.br...@parasane.net || danbr...@php.net
http://www.parasane.net/ || http://www.pilotpig.net/
Unadvertised dedicated server deals, too low to print - email me to find out!

-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php