[PHP] MySQL query not working!
Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] MySQL query not working!
On Wed, 2010-03-31 at 16:20 +0430, Parham Doustdar wrote: Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? What is the output of $query? Thanks, Ash http://www.ashleysheridan.co.uk
Re: [PHP] MySQL query not working!
Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] MySQL query not working!
Andre, The @ operator is used for error catching statements. When you put: @mysql_connect('localhost', 'username', 'password') or die('Could not connect.'); If PHP fails to make a connection, the script execution is stopped, and the error message between the apostrophes is given. And, I found out what the problem was; I should have put: if (mysql_num_rows($result)) rather than just if ($result) Thanks! - Original Message - From: Andre Polykanine an...@oire.org To: Parham Doustdar parha...@gmail.com Cc: php-general@lists.php.net Sent: Wednesday, March 31, 2010 4:41 PM Subject: Re: [PHP] MySQL query not working! Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] MySQL query not working!
Hi! To view error: you must use mysql_query(). @ before mysql - error supression. next you can use the following: $result=.. if($result){ if(mysql_num_rows($result)){ /* you have record in table */ }else{ /* you haven't */ On Wed, Mar 31, 2010 at 4:11 PM, Andre Polykanine an...@oire.org wrote: Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- With regards, Alexei Bovanenko
Re[2]: [PHP] MySQL query not working!
Hello Parham, I know what the @ operator does (it stops PHP from reporting errors and makes it ignore error_reporting() or any INI directives) but I don't understand why to use it here, with mysql_query() function. -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: Andre Polykanine an...@oire.org Date: Wednesday, March 31, 2010, 3:20:54 PM Subject: [PHP] MySQL query not working! Andre, The @ operator is used for error catching statements. When you put: @mysql_connect('localhost', 'username', 'password') or die('Could not connect.'); If PHP fails to make a connection, the script execution is stopped, and the error message between the apostrophes is given. And, I found out what the problem was; I should have put: if (mysql_num_rows($result)) rather than just if ($result) Thanks! - Original Message - From: Andre Polykanine an...@oire.org To: Parham Doustdar parha...@gmail.com Cc: php-general@lists.php.net Sent: Wednesday, March 31, 2010 4:41 PM Subject: Re: [PHP] MySQL query not working! Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] MySQL query not working!
On Wed, 2010-03-31 at 16:50 +0430, Parham Doustdar wrote: Andre, The @ operator is used for error catching statements. When you put: @mysql_connect('localhost', 'username', 'password') or die('Could not connect.'); If PHP fails to make a connection, the script execution is stopped, and the error message between the apostrophes is given. And, I found out what the problem was; I should have put: if (mysql_num_rows($result)) rather than just if ($result) Thanks! - Original Message - From: Andre Polykanine an...@oire.org To: Parham Doustdar parha...@gmail.com Cc: php-general@lists.php.net Sent: Wednesday, March 31, 2010 4:41 PM Subject: Re: [PHP] MySQL query not working! Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php My understanding of the @ here would be that PHP won't register the error, so it won't ever die() Thanks, Ash http://www.ashleysheridan.co.uk
Re: [PHP] MySQL query not working!
Yes ash.. me too think the same... @ will supress any error which would have lead to die()... so die() wont come ever Midhun Girish On Wed, Mar 31, 2010 at 6:16 PM, Ashley Sheridan a...@ashleysheridan.co.ukwrote: On Wed, 2010-03-31 at 16:50 +0430, Parham Doustdar wrote: Andre, The @ operator is used for error catching statements. When you put: @mysql_connect('localhost', 'username', 'password') or die('Could not connect.'); If PHP fails to make a connection, the script execution is stopped, and the error message between the apostrophes is given. And, I found out what the problem was; I should have put: if (mysql_num_rows($result)) rather than just if ($result) Thanks! - Original Message - From: Andre Polykanine an...@oire.org To: Parham Doustdar parha...@gmail.com Cc: php-general@lists.php.net Sent: Wednesday, March 31, 2010 4:41 PM Subject: Re: [PHP] MySQL query not working! Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php My understanding of the @ here would be that PHP won't register the error, so it won't ever die() Thanks, Ash http://www.ashleysheridan.co.uk
Re: [PHP] MySQL query not working!
On Wed, Mar 31, 2010 at 8:46 AM, Ashley Sheridan a...@ashleysheridan.co.uk wrote: On Wed, 2010-03-31 at 16:50 +0430, Parham Doustdar wrote: Andre, The @ operator is used for error catching statements. When you put: @mysql_connect('localhost', 'username', 'password') or die('Could not connect.'); If PHP fails to make a connection, the script execution is stopped, and the error message between the apostrophes is given. And, I found out what the problem was; I should have put: if (mysql_num_rows($result)) rather than just if ($result) Thanks! - Original Message - From: Andre Polykanine an...@oire.org To: Parham Doustdar parha...@gmail.com Cc: php-general@lists.php.net Sent: Wednesday, March 31, 2010 4:41 PM Subject: Re: [PHP] MySQL query not working! Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php My understanding of the @ here would be that PHP won't register the error, so it won't ever die() Thanks, Ash http://www.ashleysheridan.co.uk Nope. All it does is suppress the error message. Just try it: ?php @mysql_connect('localhost', 'baduser', 'badpassword') or die('Could not connect'); ? Output: Could not connect ?php @mysql_connect('localhost', 'baduser', 'badpassword') or die('Could not connect'); ? Output: br / bWarning/b: mysql_connect() [a href='function.mysql-connect'function.mysql-connect/a]: Can't connect to MySQL server on 'localhost' (10061) in bPHPDocument1/b on line b3/bbr / Could not connect Andrew -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] MySQL query not working!
hey Andrew , you are correct thanks for pointing tht.. i should have checked it before so @ just prevents the warnings and errors from showing up Midhun Girish On Wed, Mar 31, 2010 at 6:38 PM, Andrew Ballard aball...@gmail.com wrote: On Wed, Mar 31, 2010 at 8:46 AM, Ashley Sheridan a...@ashleysheridan.co.uk wrote: On Wed, 2010-03-31 at 16:50 +0430, Parham Doustdar wrote: Andre, The @ operator is used for error catching statements. When you put: @mysql_connect('localhost', 'username', 'password') or die('Could not connect.'); If PHP fails to make a connection, the script execution is stopped, and the error message between the apostrophes is given. And, I found out what the problem was; I should have put: if (mysql_num_rows($result)) rather than just if ($result) Thanks! - Original Message - From: Andre Polykanine an...@oire.org To: Parham Doustdar parha...@gmail.com Cc: php-general@lists.php.net Sent: Wednesday, March 31, 2010 4:41 PM Subject: Re: [PHP] MySQL query not working! Hello Parham, Adding to Ash's question, why to use the @ operator before mysql_query? -- With best regards from Ukraine, Andre Skype: Francophile; WlmMSN: arthaelon @ yandex.ru; Jabber: arthaelon @ jabber.org Yahoo! messenger: andre.polykanine; ICQ: 191749952 Twitter: m_elensule - Original message - From: Parham Doustdar parha...@gmail.com To: php-general@lists.php.net php-general@lists.php.net Date: Wednesday, March 31, 2010, 2:50:07 PM Subject: [PHP] MySQL query not working! Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } ? -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php My understanding of the @ here would be that PHP won't register the error, so it won't ever die() Thanks, Ash http://www.ashleysheridan.co.uk Nope. All it does is suppress the error message. Just try it: ?php @mysql_connect('localhost', 'baduser', 'badpassword') or die('Could not connect'); ? Output: Could not connect ?php @mysql_connect('localhost', 'baduser', 'badpassword') or die('Could not connect'); ? Output: br / bWarning/b: mysql_connect() [a href='function.mysql-connect'function.mysql-connect/a]: Can't connect to MySQL server on 'localhost' (10061) in bPHPDocument1/b on line b3/bbr / Could not connect Andrew -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] MySQL query not working!
On Wed, Mar 31, 2010 at 9:08 AM, Andrew Ballard aball...@gmail.com wrote: Nope. All it does is suppress the error message. Just try it: ?php @mysql_connect('localhost', 'baduser', 'badpassword') or die('Could not connect'); ? Output: Could not connect ?php @mysql_connect('localhost', 'baduser', 'badpassword') or die('Could not connect'); ? Output: br / bWarning/b: mysql_connect() [a href='function.mysql-connect'function.mysql-connect/a]: Can't connect to MySQL server on 'localhost' (10061) in bPHPDocument1/b on line b3/bbr / Could not connect Andrew OK, for the sake of the archives, I wish there was an EDIT feature to this list. Copy/paste will get you every time; or, Insanity: doing the same thing over and over again and expecting different results. :-) At any rate, the point I was TRYING to make is correct, even if the example wasn't quite right. Andrew -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] MySQL query not working!
At 4:20 PM +0430 3/31/10, Parham Doustdar wrote: Hi there, Here is a snippet of code... that doesn't work for some reason. Please note that I have put some @mysql_query($query) or die(mysql_error()); statements, to see if MySQL gives an error. I receive nothing other than the file starting to download. This is supposed to be a file download counter: [code] ?php //connect to the DB mysql_connect() //There is no problem with the connection so I didn't include the complete code. //The table where the hits are stored. $table = files; $query = select * from . $table . where filename = ' . $_GET['file'] . '; $result = mysql_query($query); if ($result) //Has the file previously been added? { $query = update . $table . set hits = hits + 1 where filename = ' . $_GET['file'] . '; @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } else //it's the first time we're adding this file to the DB. { $query = insert into . $table . (filename, hits) values (' . $_GET['file'] . ', 1); @mysql_query($query) or die(mysql_error()); header('location:http://www.qwitter-client.net/' . $_GET['file']); } Hi Parham: Considering that no one made comment, let me say that using $_GET in such a fashion is dangerous. One should always clean/scrub all variables that makeup a db query. Doing what you did above is opening your database to possible SQL injection. This is not a secure thing to do. For example, let's say I provide the following string to your form (first GET): anything OR '1' = '1'; DROP TABLE customers If your database configuration allows for multiple statements, then any table named customers would be immediately dropped from your database. I'm sure you can see how you would not want to allow someone to drop tables from your database. In short, never trust anything coming from client-side. Here's a reference on the subject: http://en.wikipedia.org/wiki/SQL_injection There are many others. Cheers, tedd -- --- http://sperling.com http://ancientstones.com http://earthstones.com -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php