Re: [PHP] peer code review wanted

2002-04-15 Thread Erik Price
On Monday, April 15, 2002, at 04:58 PM, Robert Cummings wrote: > Well you don't return true anywhere... default return is false which is > what happens if the else statement is reached. EUREKA! Thanks so much Rob! I too busy wondering how the preg_match was failing to notice that I didn't e

Re: [PHP] peer code review wanted

2002-04-15 Thread Robert Cummings
Erik Price wrote: > > Hi, I am just not seeing what is wrong with my code. > > Can anyone tell me if there is anything wrong with the following > function? > > function set_material_id($material_id) > { > if (!preg_match('/^\d{1,3}$/', $material_id)) { >

[PHP] peer code review wanted

2002-04-15 Thread Erik Price
Hi, I am just not seeing what is wrong with my code. Can anyone tell me if there is anything wrong with the following function? function set_material_id($material_id) { if (!preg_match('/^\d{1,3}$/', $material_id)) { return false;