Hi Ulf:
On Thu, Jul 08, 2010 at 04:45:38PM +0200, Ulf Wendel wrote:
>
> I've drafted some initial documentation for PECL/mysqlnd_qc.
Excellent, thanks! I just took a very quick look and have some coding
standards feedback:
* Nesting is one space per level, you're generally using two, but some
places none and others a random number.
* Wrap long lines around 60-70 chars (not 80, to make translation
easier).
* Many lines have trailing whitespace, please remove them to avoid
inadvertent whitespace changes later.
* Use an active voice in the <refpurpose>'s and be brief. For example:
Existing: "Change current storage handler"
Suggestion: "Changes the current storage handler"
Existing: "Statistics collected by the core of the query cache"
Suggestion: "Obtains statistics collected by the query cache's core"
etc...
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409
