Hannes Magnusson wrote:
Awesome work.
One thing I would update: + Returns 0 on success, -1 if the color
table could not be allocated
(and all similar), use 0, -1..
it makes it more clear that these are actual return values.
-Hannes
Thanks Hannes! I've posted an updated patch with that change
On Sun, Apr 5, 2009 at 08:56, Keito Uchiyama wrote:
> Philip Olson wrote:
>>
>> Nice! :) But please post the patch as an attachment or a link online as it
>> gets altered in email. And if you're planning on documenting more then a CVS
>> account is appropriate:
>>
>> - http://php.net/cvs-php
>>
>
Philip Olson wrote:
Nice! :) But please post the patch as an attachment or a link online as
it gets altered in email. And if you're planning on documenting more
then a CVS account is appropriate:
- http://php.net/cvs-php
As for the markup, the only problems I see are whitespace issues becau
> Agreed, and I think it would be well worth it to document this
extension.
I've gone ahead and documented the color-related functions in the
ncurses extension, for starters.
Please let me know if there's anything I should fix!
Hello Keito,
Nice! :) But please post the patch as an atta
Philip Olson wrote:
> Agreed, and I think it would be well worth it to document this extension.
I've gone ahead and documented the color-related functions in the
ncurses extension, for starters.
Please let me know if there's anything I should fix!
Thanks,
Keito
Index: constants.xml
===
