On Thu, Jul 16, 2009 at 15:04, Moacir de
Oliveira wrote:
> Patch Explanation
[...]
Looks good to me :)
-Hannes
On Jul 16, 2009, at 2:04 PM, Moacir de Oliveira > wrote:
Patch Explanation
Outstanding explanation. Gave me some ideas for how to improve my own
code.
Ted Stresen-Reuter
Patch Explanation
Factory:
The last implementation of the class Format_Factory had a lot of creational
methods, one for each output format.
ex:
public function createXhtmlFormat() {
trigger_error("This format is not supported by this package",
E_USER_ERROR);
}
public functio
On Thu, Jul 16, 2009 at 05:37, Moacir de
Oliveira wrote:
> Hey guys,
>
> Some patches to improve the factory system and load the formats dynamically.
How does it improve the system?
Are there any performance differences? Readability changes? Extendability?
I know the answer (heck, I commented on
Hey guys,
Some patches to improve the factory system and load the formats dynamically.
what do you think?
--Moacir
Index: phpdotnet/phd/BuildOptionsParser.php
===
--- phpdotnet/phd/BuildOptionsParser.php(revision 284053)
++
In comment of some functions, there was written about "array"
parameter, but parameter of type array was named different (e.g.
output).
CVS comment for exec: Write about output parameter, not about array
CVS comment for mb*: Write about convmap parameter, not about array
Jakub Vrana
exec.xml.dif
