I'm really happy to hear from you again :) (for those who didn't follow , have a look at #26420).
For the patch, the best thing is to send a cvs diff -u of your work. Attached is a diff of what you have done, i'll commit it if nobody objects.
Thank you for your contribution and feel free to send other ones (to [EMAIL PROTECTED] this time ;))
Regards,
didou
PS : keep using reply-all
If you want to learn how to work with our documentation, read the whole
howto I've pointed you out in the bug report and have fun with CVS ;)
Hello!
It is recommended to send some patches before requesting a CVS account. So I'm sending you patch for openssl_csr_sign(). I don't know the format which you prefer (maybe diff), so I am sending you just a plain file. I'm sending it directly to you and not to the list because we know each other a bit so you know what to expect from me :-).
Comment for CVS: Added configargs and serial parameters.
Little note about "configargs": There is used "config_args" in sources but in other parts of documentation is "configargs", so I used it here too.
If it will be OK, I will send other patches.
Jakub Vrana
--- openssl-csr-sign.xml Sun Mar 30 16:35:24 2003
+++ openssl-csr-sign.xml.patched Thu Nov 27 10:08:42 2003
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="iso-8859-1"?>
-<!-- $Revision: 1.8 $ -->
+<!-- $Revision: 1.9 $ -->
<!-- splitted from ./en/functions/openssl.xml, last change in rev 1.19 -->
<refentry id="function.openssl-csr-sign">
<refnamediv>
@@ -14,6 +14,8 @@
<methodparam><type>mixed</type><parameter>cacert</parameter></methodparam>
<methodparam><type>mixed</type><parameter>priv_key</parameter></methodparam>
<methodparam><type>int</type><parameter>days</parameter></methodparam>
+ <methodparam
choice="opt"><type>array</type><parameter>configargs</parameter></methodparam>
+ <methodparam
choice="opt"><type>int</type><parameter>serial</parameter></methodparam>
</methodsynopsis>
<para>
<function>openssl_csr_sign</function> generates an x509 certificate
@@ -29,6 +31,11 @@
<parameter>cacert</parameter>.
<parameter>days</parameter> specifies the length of time for which the
generated certificate will be valid, in days.
+ You can finetune the CSR signing by <parameter>configargs</parameter>.
+ See <function>openssl_csr_new</function> for more information about
+ <parameter>configargs</parameter>.
+ Since PHP 4.3.3 you can specify the serial number of issued certificate by
+ <parameter>serial</parameter>. In earlier versions, it was always 0.
</para>
<para>
Returns an x509 certificate resource on success, &false; on failure.
