Jakub, I have committed your patch. It would be good if you could review
your code and fix the same errors you have fixed in the previous
magic_quotes/register_globals patch - since you submitted this patch
before the cleanup.
Here it is.
Thanks, committed.
Goba
Gabor Hojtsy wrote:
> Jakub, I have committed your patch. It would be good if you could review
> your code and fix the same errors you have fixed in the previous
> magic_quotes/register_globals patch - since you submitted this patch
> before the cleanup.
Here it is.
Jakub VranaIndex: user-notes
Here is the second step. It is the form to mass change sections of
notes. I think that moving Nuno's script to the server is not necessary.
It can be easily run locally and through the web interface only changes
can be done.
Then do a select on the notes db and check for non-valid IDs and do a
fore
Well, how should I interpret this? How can we move forward?
I wrote my code in the style of rest of the file. I think you can commit
it and nothing will brake. Then I (or someone else) can fix the file to
not rely on register_globals and good intentions of all users with CVS
account ;-).
OK, I am o
Gabor Hojtsy wrote:
> Well, how should I interpret this? How can we move forward?
I wrote my code in the style of rest of the file. I think you can commit
it and nothing will brake. Then I (or someone else) can fix the file to
not rely on register_globals and good intentions of all users with CVS
Then still I am conserned about the vulnerability of this code against
SQL injection in case magic_quotes is turned off, but AFAIK some other
code in the master module also relies on that setting. I would like to
ask the system guys first if we still should rely on it?
Relying on magic_quotes is no
Gabor Hojtsy wrote:
> Then still I am conserned about the vulnerability of this code against
> SQL injection in case magic_quotes is turned off, but AFAIK some other
> code in the master module also relies on that setting. I would like to
> ask the system guys first if we still should rely on it?
Here is the second step. It is the form to mass change sections of
notes. I think that moving Nuno's script to the server is not necessary.
It can be easily run locally and through the web interface only changes
can be done.
Then do a select on the notes db and check for non-valid IDs and do a
fore
Gabor Hojtsy wrote:
> It should have been updated already, but it has not done so, as it
> seems... I don't know what might be the problem.
There was some DNS change. Cannot be this caused by it?
Jakub Vrana
Here is the second step. It is the form to mass change sections of
notes. I think that moving Nuno's script to the server is not necessary.
It can be easily run locally and through the web interface only changes
can be done.
It seems good to me!
And what about a mail to the notes mailling list? I t
> Here is the second step. It is the form to mass change sections of
> notes. I think that moving Nuno's script to the server is not necessary.
> It can be easily run locally and through the web interface only changes
> can be done.
>
> Jakub Vrana
It seems good to me!
And what about a mail to t
Here is the second step. It is the form to mass change sections of
notes. I think that moving Nuno's script to the server is not necessary.
It can be easily run locally and through the web interface only changes
can be done.
> Then do a select on the notes db and check for non-valid IDs and do a
>
> Nuno, thanks for the script. It can be run locally and there will be
> only mass reassignment part on the server. My original idea was to
> have both parts on the server but it would be a bit harder as the list
> of IDs has to be readable on master.php.net somehow.
>
> Jakub Vrana
I think the m
> Jakub probably already has better experience with this, since he
> provided patches for php-master-web before. The code is in
> php-master-web/manage/user-notes.php, and that should be extended to
> offer an option to mass modify manual IDs (or sections are they are stored).
> UPDATE notes SET
Now it would
be nice if the person who gets on implementing the mass manual ID
reassigment in manage/user-notes.php would speak out, so no more than
one guy would be involved with this.
What do we need to do here?
Do you want a program to go to the master server, so that you type the old
ID and a n
> Seems like Nuno already completed this part. Would have been better if
> he would have noted he works on this, so duplicate work would not be
> possible (not that there was duplicate work in this case).
Sorry here, but I wasn't planning on working this, but as it was simple to
do...
> Now it w
Is there a list of existing IDs somewhere or should I extract them from
manual sources?
Seems like Nuno already completed this part. Would have been better if
he would have noted he works on this, so duplicate work would not be
possible (not that there was duplicate work in this case). Now it wou
Is there a list of existing IDs somewhere or should I extract them from
manual sources?
Jakub Vrana
First step is attached. I checked the notes distribution system and this
should not harm it.
Commited, great :)
Goba
First step is attached. I checked the notes distribution system and this
should not harm it.
Second step will be the mass processing - checking for orphans and
mass changing of IDs.
Jakub VranaIndex: user-notes.php
===
RCS file: /rep
20 matches
Mail list logo
