Re: [PHP-DOC] Make PhD work with new xml:id's for methods

2007-12-04 Thread Hannes Magnusson
Committed, thanks! -Hannes On Nov 26, 2007 3:09 AM, Edward Z. Yang <[EMAIL PROTECTED]> wrote: > The new OO skeletons mandate that methods be named as > xml:id="classname.methodname". Unfortunately, PhD hasn't been taught to > handle these new names properly (Thanks Hannes!) This patch fixes this.

Re: [PHP-DOC] Make PhD work with new xml:id's for methods

2007-11-26 Thread Hannes Magnusson
On Nov 26, 2007 10:17 PM, Edward Z. Yang <[EMAIL PROTECTED]> wrote: > Hannes Magnusson wrote: > > See bug#43416 > > Hmm... that's a nasty edge-case on an edge-case. According to the old > style, the non-OOP docs should be found at function.collator-asort, but > I can see why, for the dual style, pl

Re: [PHP-DOC] Make PhD work with new xml:id's for methods

2007-11-26 Thread Edward Z. Yang
Hannes Magnusson wrote: > See bug#43416 Hmm... that's a nasty edge-case on an edge-case. According to the old style, the non-OOP docs should be found at function.collator-asort, but I can see why, for the dual style, placing them both at collator.asort would be advantageous. There are two conside

Re: [PHP-DOC] Make PhD work with new xml:id's for methods

2007-11-26 Thread Hannes Magnusson
On Nov 26, 2007 6:59 PM, Edward Z. Yang <[EMAIL PROTECTED]> wrote: > Hannes Magnusson wrote: > > Shouldn't the underscore be replaced with dash? > > Granted that internal PHP methods are supposed to use camelCasedNames > > I bet some extension will break this convention at some point. > > Sure. We'

Re: [PHP-DOC] Make PhD work with new xml:id's for methods

2007-11-26 Thread Edward Z. Yang
Hannes Magnusson wrote: > Shouldn't the underscore be replaced with dash? > Granted that internal PHP methods are supposed to use camelCasedNames > I bet some extension will break this convention at some point. Sure. We'll get some weird names, however, such as class.-private or class.--magic, esp

Re: [PHP-DOC] Make PhD work with new xml:id's for methods

2007-11-26 Thread Hannes Magnusson
On Nov 26, 2007 3:09 AM, Edward Z. Yang <[EMAIL PROTECTED]> wrote: > The new OO skeletons mandate that methods be named as > xml:id="classname.methodname". Unfortunately, PhD hasn't been taught to > handle these new names properly (Thanks Hannes!) This patch fixes this. > We may want to consider fa