[phpsoa] Re: json rpc patch

2007-08-31 Thread simonslaws
On 7 Aug, 11:20, [EMAIL PROTECTED] wrote: On 7 Aug, 10:55, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: The patch I have uploaded includes a change to see whether the $content_type variable contains the string application/json-rpc rather than checking whether it is equal to it. The

[phpsoa] Re: Finer-grained control over service methods (Pecl Request #11944)

2007-08-31 Thread simonslaws
Hi Graham Some more comments in line... On 31 Aug, 11:26, Graham Charters [EMAIL PROTECTED] wrote: Hi Simon, thanks for the rapid comments. Here's my thoughts on the two issues you identified: 1/ What should SCA do if it finds a method without annotations, i.e. no type information

[phpsoa] Re: Finer-grained control over service methods (Pecl Request #11944)

2007-08-31 Thread Graham Charters
Comments inlined below... On 31 Aug, 11:35, [EMAIL PROTECTED] wrote: Hi Graham Some more comments in line... On 31 Aug, 11:26, Graham Charters [EMAIL PROTECTED] wrote: Hi Simon, thanks for the rapid comments. Here's my thoughts on the two issues you identified: 1/ What should

[phpsoa] Re: Finer-grained control over service methods (Pecl Request #11944)

2007-08-31 Thread Matthew Schultz
Actually after a second glance, I see all annotations are still set in the class. It probably wouldn't make any sense to have SCA parse annotations in the interface. Matt On 31 Aug, 06:20, Graham Charters [EMAIL PROTECTED] wrote: Comments inlined below... On 31 Aug, 11:35, [EMAIL