Making phptal_tales() a static methods could be a good idea, but static methods are a bit slower :\ To avoid namespace pollution it could be better if you use PHPTAL\phptal_tales() or better PHPTAL\tales() A simple find/replace should be able to fix that problem with code compatibility... or am I wrong? :\ I'm just talking about patterns that could be used, I never crawled your code in-depth, so it's just what I suppose... Avoid namespace pollution if possible...
2010/1/27 Kornel Lesiński <kor...@aardvarkmedia.co.uk> > Little background story: > > PHPTAL has been accepted as PEAR package, but PEAR requires change of class > names from PHPTAL_* to HTML_Template_PHPTAL_*, which would break all > existing code for IMHO not a good enough reason. > > Therefore I've decided that if I'm having to break existing code, at least > I'll make it for a better reason: migration to PHP 5.3 namespaces and PEAR2 > (don't worry, I'll maintain PHP 5.2/PEAR1 package for as long as it's > needed). > > > Here's my first try: > > http://phptal.org/files/PHPTAL-1.2.2-namespaced.tar.gz > > > *WARNING:* don't install this as a PEAR package! I haven't upgraded build > system yet. Just unpack it somewhere and include using absolute path. It's > not backwards compatible. Requires PHP 5.3 of course. > > > There are still some unresolved bugs, e.g. PluginLoader (that loads > prefilters) isn't namespace-aware yet and will fail. I've had some problems > with Phing and PHPUnit getting confused by namespaces. > > > Changes required in your code: > > use pear2\HTML\Template\PHPTAL; > > $tpl = new PHPTAL\PHPTAL(); > > > > Classes that were called PHPTAL_Foo_Bar_Baz are now PHPTAL\Foo\Bar\Baz > (assuming you add 'use' statement as above to _every_ file that refers to > them). Class PHPTAL became PHPTAL\PHPTAL. PHPTAL_VERSION is PHPTAL\VERSION. > > I'm not sure what to do with phptal_tales() function and function > modifiers. Currently they're in PHPTAL namespace (PHPTAL\phptal_tales()), > but it might make sense to move them to global namespace, so that existing > modifiers don't need any code changes. > > -- > regards, Kornel > > _______________________________________________ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal > -- Marco Pivetta - Ocramius Aethril
_______________________________________________ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
