[piccolo2d-dev] Issue 100 in piccolo2d: PInputEvent doesn't filter by modifier

2009-07-17 Thread codesite-noreply
Updates: Status: Fixed Comment #1 on issue 100 by allain.lalonde: PInputEvent doesn't filter by modifier http://code.google.com/p/piccolo2d/issues/detail?id=100 Fixed in r493 Plastered PInputEventFilter with Unit Tests and then made it consider the masks conditionally. andMask if

[piccolo2d-dev] Issue 74 in piccolo2d: Memory leak with PSwingRepaintManager

2009-07-17 Thread codesite-noreply
Comment #7 on issue 74 by allain.lalonde: Memory leak with PSwingRepaintManager http://code.google.com/p/piccolo2d/issues/detail?id=74 Although I think the memory leak identified above is a problem. It's not the only one. Turns out that the memory leak exists in PCanvas, not just

[piccolo2d-dev] [piccolo2d commit] r496 - Fixed a memory leak with PCanvas instances registering themselves with KeyboardFocus and n...

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 17:11:06 2009 New Revision: 496 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PCanvas.java Log: Fixed a memory leak with PCanvas instances registering themselves with KeyboardFocus and never unregistering themselves. Added a

[piccolo2d-dev] Issue 74 in piccolo2d: Memory leak with PSwingRepaintManager

2009-07-17 Thread codesite-noreply
Comment #8 on issue 74 by allain.lalonde: Memory leak with PSwingRepaintManager http://code.google.com/p/piccolo2d/issues/detail?id=74 heuermh's elegant solution I referred to above is attached. It basically amounts to removing the need for tracking PSwingCanvas.SwingWrapper instances in

[piccolo2d-dev] [piccolo2d commit] r497 - renamed test since PCanvas was redundant

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 17:32:04 2009 New Revision: 497 Modified: piccolo2d.java/trunk/core/src/test/java/edu/umd/cs/piccolo/PCanvasTest.java Log: renamed test since PCanvas was redundant Modified:

[piccolo2d-dev] [piccolo2d commit] r498 - Added PSwingCanvas Test for Memory Leak

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 17:35:13 2009 New Revision: 498 Added: piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingCanvasTest.java Log: Added PSwingCanvas Test for Memory Leak Added:

[piccolo2d-dev] [piccolo2d commit] r499 - Changed test name since it was incorrectly referring to PCanvas

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 17:39:55 2009 New Revision: 499 Modified: piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingCanvasTest.java Log: Changed test name since it was incorrectly referring to PCanvas Modified:

[piccolo2d-dev] [piccolo2d commit] r500 - Adding tests for PText and making it return empty string by default rather than null. More...

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 19:24:58 2009 New Revision: 500 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/nodes/PText.java piccolo2d.java/trunk/core/src/test/java/edu/umd/cs/piccolo/nodes/PTextTest.java Log: Adding tests for PText and making it

[piccolo2d-dev] [piccolo2d commit] r501 - Fixed Issue 74; removed the need to track PSwingCanvas.SwingWrapper instances in the PSwin...

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 19:36:16 2009 New Revision: 501 Modified: piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwingCanvas.java piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManager.java Log: Fixed Issue

[piccolo2d-dev] [piccolo2d commit] r502 - Adding tests for PText

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 20:04:59 2009 New Revision: 502 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/nodes/PText.java piccolo2d.java/trunk/core/src/test/java/edu/umd/cs/piccolo/nodes/PTextTest.java Log: Adding tests for PText Modified:

[piccolo2d-dev] [piccolo2d commit] r503 - Trying to get test to pass. Seems to get GC to run

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 20:19:24 2009 New Revision: 503 Modified: piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingCanvasTest.java Log: Trying to get test to pass. Seems to get GC to run Modified:

[piccolo2d-dev] Issue 74 in piccolo2d: Memory leak with PSwingRepaintManager

2009-07-17 Thread codesite-noreply
Comment #9 on issue 74 by allain.lalonde: Memory leak with PSwingRepaintManager http://code.google.com/p/piccolo2d/issues/detail?id=74 Committed changes, test passes in Eclipse, doesn't pass on the command line or when being run from Hudson. *Very stange* -- You received this message

[piccolo2d-dev] [piccolo2d commit] r505 - Issue 74 ; minor style and javadoc fixes

2009-07-17 Thread codesite-noreply
Author: heuermh Date: Fri Jul 17 21:00:42 2009 New Revision: 505 Modified: piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwingCanvas.java Log: Issue 74 ; minor style and javadoc fixes Modified:

[piccolo2d-dev] [piccolo2d commit] r506 - Commenting out assert since it doesn't work on all environments

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 21:16:16 2009 New Revision: 506 Modified: piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingCanvasTest.java Log: Commenting out assert since it doesn't work on all environments Modified:

[piccolo2d-dev] [piccolo2d commit] r507 - Issue 74 ; additional minor improvements for better UI responsiveness

2009-07-17 Thread codesite-noreply
Author: heuermh Date: Fri Jul 17 21:38:42 2009 New Revision: 507 Modified: piccolo2d.java/trunk/examples/src/main/java/edu/umd/cs/piccolo/examples/pswing/PSwingMemoryLeakExample.java Log: Issue 74 ; additional minor improvements for better UI responsiveness Modified:

[piccolo2d-dev] [piccolo2d commit] r508 - Some refactoring to make PSwingRepaintManager clearer, nothing too fancy

2009-07-17 Thread codesite-noreply
Author: allain.lalonde Date: Fri Jul 17 22:20:39 2009 New Revision: 508 Modified: piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwing.java piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwingCanvas.java

[piccolo2d-dev] [piccolo2d commit] r509 - Some Unit Tests for PInputEvent

2009-07-18 Thread codesite-noreply
Author: allain.lalonde Date: Sat Jul 18 05:08:49 2009 New Revision: 509 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/event/PInputEvent.java piccolo2d.java/trunk/core/src/test/java/edu/umd/cs/piccolo/event/PInputEventTest.java Log: Some Unit Tests for

[piccolo2d-dev] [piccolo2d commit] r510 - Unit Testing for PImage and removed a little cruft

2009-07-18 Thread codesite-noreply
Author: allain.lalonde Date: Sat Jul 18 05:27:47 2009 New Revision: 510 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/nodes/PImage.java piccolo2d.java/trunk/core/src/test/java/edu/umd/cs/piccolo/nodes/PImageTest.java Log: Unit Testing for PImage and removed a

[piccolo2d-dev] [piccolo2d commit] r513 - Sorry, IDE misusage

2009-07-18 Thread codesite-noreply
Author: mr0...@mro.name Date: Sat Jul 18 05:45:13 2009 New Revision: 513 Removed: Piccolo2D/ Log: Sorry, IDE misusage --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en

[piccolo2d-dev] Issue 101 in piccolo2d: Eliminate printStackTrace

2009-07-18 Thread codesite-noreply
Comment #1 on issue 101 by mr0...@mro.name: Eliminate printStackTrace http://code.google.com/p/piccolo2d/issues/detail?id=101 I'd like to replace them with throw new RuntimeException(e); - objections? -- You received this message because you are listed in the owner or CC fields of this issue,

[piccolo2d-dev] Issue 101 in piccolo2d: Eliminate printStackTrace

2009-07-18 Thread codesite-noreply
Comment #2 on issue 101 by allain.lalonde: Eliminate printStackTrace http://code.google.com/p/piccolo2d/issues/detail?id=101 wow that's a lot of them. Objection would be that RuntimeException is indistinguishable from a Divide by zero exception, or any number of other system level

[piccolo2d-dev] Issue 83 in piccolo2d: PSwing are fuzzy when scale!=1, due to buffering of the PSwing

2009-07-18 Thread codesite-noreply
Comment #15 on issue 83 by allain.lalonde: PSwing are fuzzy when scale!=1, due to buffering of the PSwing http://code.google.com/p/piccolo2d/issues/detail?id=83 PSwingExample1 in the examples project would do. -- You received this message because you are listed in the owner or CC fields of

[piccolo2d-dev] Issue 101 in piccolo2d: Eliminate printStackTrace

2009-07-18 Thread codesite-noreply
Comment #4 on issue 101 by allain.lalonde: Eliminate printStackTrace http://code.google.com/p/piccolo2d/issues/detail?id=101 It's considered an important enough code smell that it's part of PMD's default checklist. The context of the printStackTrace is important before replacing since the

[piccolo2d-dev] Issue 101 in piccolo2d: Eliminate printStackTrace

2009-07-18 Thread codesite-noreply
Comment #5 on issue 101 by mr0...@mro.name: Eliminate printStackTrace http://code.google.com/p/piccolo2d/issues/detail?id=101 I vote against a generic, non-abstract PPiccoloException - if required we should use fine-grained ones with clear semantic meaning (as discussed with the

[piccolo2d-dev] [piccolo2d commit] r516 - Removing some calls to printStackTrace(), replacing them with appropriate responses Issue 101

2009-07-18 Thread codesite-noreply
Author: allain.lalonde Date: Sat Jul 18 17:44:30 2009 New Revision: 516 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/util/PAffineTransform.java

[piccolo2d-dev] Issue 101 in piccolo2d: Eliminate printStackTrace

2009-07-18 Thread codesite-noreply
Comment #6 on issue 101 by allain.lalonde: Eliminate printStackTrace http://code.google.com/p/piccolo2d/issues/detail?id=101 It's a little shorter now as per r516 ./extras/src/main/java/edu/umd/cs/piccolox/event/PNotificationCenter.java: e.printStackTrace();

[piccolo2d-dev] Issue 102 in piccolo2d: PNode.print swallows failures

2009-07-18 Thread codesite-noreply
Status: Accepted Owner: allain.lalonde Labels: Type-Defect Priority-Medium Effort-Low OpSys-All Toolkit-Piccolo2D.Java Component-Core Milestone-2.0 New issue 102 by allain.lalonde: PNode.print swallows failures http://code.google.com/p/piccolo2d/issues/detail?id=102 What steps will reproduce

[piccolo2d-dev] Issue 45 in piccolo2d: deploy maven site,

2009-07-20 Thread codesite-noreply
Comment #11 on issue 45 by mr0...@mro.name: deploy maven site, http://code.google.com/p/piccolo2d/issues/detail?id=45 Just added the (past) committers to parent/pom.xml in r522 - feel free to correct your timezone. -- You received this message because you are listed in the owner or CC fields

[piccolo2d-dev] [piccolo2d commit] r524 - Refactored mousePressed and mouseReleased so that code common to each is now in a helper m...

2009-07-20 Thread codesite-noreply
Author: allain.lalonde Date: Mon Jul 20 08:02:56 2009 New Revision: 524 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PCanvas.java Log: Refactored mousePressed and mouseReleased so that code common to each is now in a helper method. Net result is a much lower

[piccolo2d-dev] [piccolo2d commit] r525 - Removed some unnecessary imports from PCanvas

2009-07-20 Thread codesite-noreply
Author: allain.lalonde Date: Mon Jul 20 08:10:51 2009 New Revision: 525 Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PCanvas.java Log: Removed some unnecessary imports from PCanvas Modified: piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PCanvas.java

[piccolo2d-dev] [piccolo2d commit] r523 - Just updated my contact info in the Maven Config File.

2009-07-20 Thread codesite-noreply
Author: allain.lalonde Date: Mon Jul 20 06:13:07 2009 New Revision: 523 Modified: piccolo2d.java/trunk/parent/pom.xml Log: Just updated my contact info in the Maven Config File. Modified: piccolo2d.java/trunk/parent/pom.xml

[piccolo2d-dev] [piccolo2d commit] r527 - Adding Coverage Ignore Rules for Examples Module

2009-07-20 Thread codesite-noreply
Author: allain.lalonde Date: Mon Jul 20 10:22:52 2009 New Revision: 527 Modified: piccolo2d.java/trunk/parent/pom.xml Log: Adding Coverage Ignore Rules for Examples Module Modified: piccolo2d.java/trunk/parent/pom.xml

[piccolo2d-dev] [piccolo2d] r528 commited - Removing unnecessary dependency to the findbugs plugin since it was al...

2009-07-20 Thread codesite-noreply
Revision: 528 Author: allain.lalonde Date: Mon Jul 20 12:39:58 2009 Log: Removing unnecessary dependency to the findbugs plugin since it was already defined in the reports element. http://code.google.com/p/piccolo2d/source/detail?r=528 Modified: /piccolo2d.java/trunk/parent/pom.xml

[piccolo2d-dev] Issue 103 in piccolo2d: PInputEventFilter is Overly Complex

2009-07-20 Thread codesite-noreply
Status: Accepted Owner: allain.lalonde Labels: Type-Enhancement Priority-High Effort-Medium OpSys-All Toolkit-Piccolo2D.Java Component-Core Milestone-2.0 Usability New issue 103 by allain.lalonde: PInputEventFilter is Overly Complex http://code.google.com/p/piccolo2d/issues/detail?id=103

[piccolo2d-dev] [piccolo2d] r530 commited - Added back in check for modifiers applying to input events. Turns out...

2009-07-20 Thread codesite-noreply
Revision: 530 Author: allain.lalonde Date: Mon Jul 20 14:32:09 2009 Log: Added back in check for modifiers applying to input events. Turns out some of the examples expect this behaviour (NavigationExample being one). http://code.google.com/p/piccolo2d/source/detail?r=530 Modified:

[piccolo2d-dev] Issue 24 in piccolo2d: Keyboard focus doesn't work for multiple cameras

2009-07-20 Thread codesite-noreply
Comment #4 on issue 24 by allain.lalonde: Keyboard focus doesn't work for multiple cameras http://code.google.com/p/piccolo2d/issues/detail?id=24 I'm not entire sure I understand this Issue. When using a regular user interface, there can only be 1 keyboard focus, why would a zoomable one be

[piccolo2d-dev] Issue 72 in piccolo2d: PSelectionEventHandler grip points do not scale with zoom

2009-07-20 Thread codesite-noreply
Comment #4 on issue 72 by allain.lalonde: PSelectionEventHandler grip points do not scale with zoom http://code.google.com/p/piccolo2d/issues/detail?id=72 I agree that the element should resize, but I think there whould be a minimum size to it. Maybe after it reaches that size making the

[piccolo2d-dev] Issue 13 in piccolo2d: PSwing components cause extraneous redraws

2009-07-20 Thread codesite-noreply
Comment #5 on issue 13 by allain.lalonde: PSwing components cause extraneous redraws http://code.google.com/p/piccolo2d/issues/detail?id=13 Why the delay on this one? Seems like a pretty trivial change. Repaint bounds originating in the component can't be larger than the component. Makes

[piccolo2d-dev] [piccolo2d] r532 commited - Fixed Issue 71; made resulting PStyledText take the camera's scale int...

2009-07-20 Thread codesite-noreply
Revision: 532 Author: allain.lalonde Date: Mon Jul 20 19:57:42 2009 Log: Fixed Issue 71; made resulting PStyledText take the camera's scale into account. Also, made right click call stopEditing, so that the input field was always the same size as the resulting text would be, was weird

[piccolo2d-dev] Issue 71 in piccolo2d: PStyledTextEventHandler does not scale

2009-07-20 Thread codesite-noreply
Updates: Status: Fixed Comment #4 on issue 71 by allain.lalonde: PStyledTextEventHandler does not scale http://code.google.com/p/piccolo2d/issues/detail?id=71 Fixed in r532; made resulting PStyledText take the camera's scale into account. Also, made right click call stopEditing, so

[piccolo2d-dev] Issue 21 in piccolo2d: Cannot turn off interacting at the PRoot level

2009-07-20 Thread codesite-noreply
Comment #5 on issue 21 by allain.lalonde: Cannot turn off interacting at the PRoot level http://code.google.com/p/piccolo2d/issues/detail?id=21 I like this change. Seems logical to mark all cameras viewing the same root to interacting in one place. If the scene is complex, you'd have to

[piccolo2d-dev] Issue 99 in piccolo2d: PNode.toString refactoring

2009-07-20 Thread codesite-noreply
Comment #2 on issue 99 by heuermh: PNode.toString refactoring http://code.google.com/p/piccolo2d/issues/detail?id=99 My opinion would be to @deprecate all the paramString methods and remove them in the next released version. I would rather not add the new class PParamStringBuilder to core.

[piccolo2d-dev] Issue 99 in piccolo2d: PNode.toString refactoring

2009-07-20 Thread codesite-noreply
Comment #3 on issue 99 by allain.lalonde: PNode.toString refactoring http://code.google.com/p/piccolo2d/issues/detail?id=99 Sure. Of course we'd be adding an external dependency for something rather trivial. -- You received this message because you are listed in the owner or CC fields of

[piccolo2d-dev] Issue 99 in piccolo2d: PNode.toString refactoring

2009-07-21 Thread codesite-noreply
Comment #6 on issue 99 by allain.lalonde: PNode.toString refactoring http://code.google.com/p/piccolo2d/issues/detail?id=99 Very strange, majority rules I guess. PParamStringBuilder is basically the same thing as the ToStringBuilder class, and the change is binary compatible to the current

[piccolo2d-dev] [piccolo2d] r533 commited - Edited wiki page through web user interface.

2009-07-21 Thread codesite-noreply
Revision: 533 Author: mr0...@mro.name Date: Tue Jul 21 04:42:23 2009 Log: Edited wiki page through web user interface. http://code.google.com/p/piccolo2d/source/detail?r=533 Modified: /wiki/SvgSupport.wiki === --- /wiki/SvgSupport.wiki Tue Apr 14

[piccolo2d-dev] [piccolo2d] r534 commited - Edited wiki page through web user interface.

2009-07-21 Thread codesite-noreply
Revision: 534 Author: mr0...@mro.name Date: Tue Jul 21 04:46:59 2009 Log: Edited wiki page through web user interface. http://code.google.com/p/piccolo2d/source/detail?r=534 Modified: /wiki/SvgSupport.wiki === --- /wiki/SvgSupport.wiki Tue Jul 21

[piccolo2d-dev] [piccolo2d] r536 commited - issue 42 - clarified README and --help.

2009-07-21 Thread codesite-noreply
Revision: 536 Author: mr0...@mro.name Date: Tue Jul 21 05:13:23 2009 Log: issue 42 - clarified README and --help. http://code.google.com/p/piccolo2d/source/detail?r=536 Modified: /site/README.txt /site/tools/inject_navigation.rb === --- /site/README.txt

[piccolo2d-dev] [piccolo2d] r537 commited - Marked ALL_MODIFIERS_MASK as final

2009-07-21 Thread codesite-noreply
Revision: 537 Author: allain.lalonde Date: Tue Jul 21 06:30:07 2009 Log: Marked ALL_MODIFIERS_MASK as final http://code.google.com/p/piccolo2d/source/detail?r=537 Modified: /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/event/PInputEventFilter.java

[piccolo2d-dev] [piccolo2d] r539 commited - fixed possible bug with double[].toString() preferred way of doing thi...

2009-07-21 Thread codesite-noreply
Revision: 539 Author: allain.lalonde Date: Tue Jul 21 06:44:08 2009 Log: fixed possible bug with double[].toString() preferred way of doing this is to use the Arrays.toString() method http://code.google.com/p/piccolo2d/source/detail?r=539 Modified:

[piccolo2d-dev] [piccolo2d] r540 commited - Fixing NotificationTarget and NotificationKey equals methods so that t...

2009-07-21 Thread codesite-noreply
Revision: 540 Author: allain.lalonde Date: Tue Jul 21 07:24:46 2009 Log: Fixing NotificationTarget and NotificationKey equals methods so that they conform to the equals contract. http://code.google.com/p/piccolo2d/source/detail?r=540 Modified:

[piccolo2d-dev] [piccolo2d] r541 commited - Made PNotificationCenter matchingKeys use NotificationKey.equals as op...

2009-07-21 Thread codesite-noreply
Revision: 541 Author: allain.lalonde Date: Tue Jul 21 07:33:17 2009 Log: Made PNotificationCenter matchingKeys use NotificationKey.equals as opposed to reproducing the logic. http://code.google.com/p/piccolo2d/source/detail?r=541 Modified:

[piccolo2d-dev] [piccolo2d] r542 commited - Removing unused imports

2009-07-21 Thread codesite-noreply
Revision: 542 Author: allain.lalonde Date: Tue Jul 21 07:46:08 2009 Log: Removing unused imports http://code.google.com/p/piccolo2d/source/detail?r=542 Modified: /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PCamera.java

[piccolo2d-dev] [piccolo2d] r543 commited - removed static from before what amounted to instance variables.

2009-07-21 Thread codesite-noreply
Revision: 543 Author: allain.lalonde Date: Tue Jul 21 07:59:29 2009 Log: removed static from before what amounted to instance variables. http://code.google.com/p/piccolo2d/source/detail?r=543 Modified: /piccolo2d.java/trunk/examples/src/main/java/edu/umd/cs/piccolo/examples/GridExample.java

[piccolo2d-dev] Issue 99 in piccolo2d: PNode.toString refactoring

2009-07-21 Thread codesite-noreply
Comment #8 on issue 99 by heuermh: PNode.toString refactoring http://code.google.com/p/piccolo2d/issues/detail?id=99 I agree with Allain in that paramString methods smell bad. I also see them of little-to-no utility. If someone wants to debug, use a debugger. My full suggestion is to 1.

[piccolo2d-dev] Issue 72 in piccolo2d: PSelectionEventHandler grip points do not scale with zoom

2009-07-21 Thread codesite-noreply
Comment #5 on issue 72 by mr0...@mro.name: PSelectionEventHandler grip points do not scale with zoom http://code.google.com/p/piccolo2d/issues/detail?id=72 Can this effect bei achieved with a custom PSelectionEventHandler? If this is the case, the current semantics should remain unchanged.

[piccolo2d-dev] Issue 19 in piccolo2d: PInputEvent does not have camera information for keyboard events.

2009-07-23 Thread codesite-noreply
Comment #6 on issue 19 by allain.lalonde: PInputEvent does not have camera information for keyboard events. http://code.google.com/p/piccolo2d/issues/detail?id=19 With mouse events it makes sense that they are done through a PCamera, does the same hold for keyboard events? I guess I don't

[piccolo2d-dev] Issue 83 in piccolo2d: PSwing are fuzzy when scale!=1, due to buffering of the PSwing

2009-07-23 Thread codesite-noreply
Comment #18 on issue 83 by allain.lalonde: PSwing are fuzzy when scale!=1, due to buffering of the PSwing http://code.google.com/p/piccolo2d/issues/detail?id=83 Fixed in r550 (hopefully for the last time... grumble grumble) -- You received this message because you are listed in the owner or

[piccolo2d-dev] Issue 19 in piccolo2d: PInputEvent does not have camera information for keyboard events.

2009-07-23 Thread codesite-noreply
Comment #7 on issue 19 by s...@browsecode.org: PInputEvent does not have camera information for keyboard events. http://code.google.com/p/piccolo2d/issues/detail?id=19 The reason for this is that when you receive a mouse event you can always guarantee that a camera will be provided to use

[piccolo2d-dev] Issue 13 in piccolo2d: PSwing components cause extraneous redraws

2009-07-23 Thread codesite-noreply
Comment #6 on issue 13 by s...@browsecode.org: PSwing components cause extraneous redraws http://code.google.com/p/piccolo2d/issues/detail?id=13 Please go ahead. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue.

[piccolo2d-dev] Issue 99 in piccolo2d: PNode.toString refactoring

2009-07-23 Thread codesite-noreply
Updates: Owner: mr0...@mro.name Comment #10 on issue 99 by mr0...@mro.name: PNode.toString refactoring http://code.google.com/p/piccolo2d/issues/detail?id=99 I'll do the job on Saturday, expect some commit activity between 12:00-14:00 UTC. -- You received this message because you are

[piccolo2d-dev] Issue 22 in piccolo2d: Name property for PNodes

2009-07-23 Thread codesite-noreply
Comment #12 on issue 22 by allain.lalonde: Name property for PNodes http://code.google.com/p/piccolo2d/issues/detail?id=22 I vote yes for this too. Might consider delegating getName and setName to the to the client property methods so that the actual size of a PNode in memory doesn't grown

[piccolo2d-dev] [piccolo2d] r552 commited - Very strange slider behaviour in mac. Trying a fix.

2009-07-23 Thread codesite-noreply
Revision: 552 Author: allain.lalonde Date: Thu Jul 23 14:47:33 2009 Log: Very strange slider behaviour in mac. Trying a fix. http://code.google.com/p/piccolo2d/source/detail?r=552 Modified: /piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwing.java

[piccolo2d-dev] Issue 88 in piccolo2d: toImage doesn't return an image of the proper size

2009-07-23 Thread codesite-noreply
Comment #4 on issue 88 by allain.lalonde: toImage doesn't return an image of the proper size http://code.google.com/p/piccolo2d/issues/detail?id=88 Good idea. I'd probably write it to have the default be #1 and have another overloaded method that accepts a parameter, since #1 it retains

[piccolo2d-dev] Issue 106 in piccolo2d: toImage array is too simple in its fill behaviour

2009-07-23 Thread codesite-noreply
Status: Accepted Owner: allain.lalonde Labels: Type-Enhancement Priority-Medium Effort-Low OpSys-All Toolkit-Piccolo2D.Java Component-Core Milestone-1.3 Usability New issue 106 by allain.lalonde: toImage array is too simple in its fill behaviour

[piccolo2d-dev] Issue 21 in piccolo2d: Cannot turn off interacting at the PRoot level

2009-07-23 Thread codesite-noreply
Updates: Status: Fixed Comment #7 on issue 21 by allain.lalonde: Cannot turn off interacting at the PRoot level http://code.google.com/p/piccolo2d/issues/detail?id=21 these changes were applied in r553 -- You received this message because you are listed in the owner or CC fields of

[piccolo2d-dev] [piccolo2d] r554 commited - Fixed Issue 13; Added the clipping for the paint region as suggested b...

2009-07-23 Thread codesite-noreply
Revision: 554 Author: allain.lalonde Date: Thu Jul 23 19:11:20 2009 Log: Fixed Issue 13; Added the clipping for the paint region as suggested by Sam http://code.google.com/p/piccolo2d/source/detail?r=554 Modified:

[piccolo2d-dev] Issue 13 in piccolo2d: PSwing components cause extraneous redraws

2009-07-23 Thread codesite-noreply
Updates: Status: Fixed Comment #8 on issue 13 by allain.lalonde: PSwing components cause extraneous redraws http://code.google.com/p/piccolo2d/issues/detail?id=13 Fixed in r554 as suggested above. Not entire sure it's clipping as much as it can, but I haven't thought it out

[piccolo2d-dev] Issue 45 in piccolo2d: deploy maven site,

2009-07-23 Thread codesite-noreply
Comment #13 on issue 45 by allain.lalonde: deploy maven site, http://code.google.com/p/piccolo2d/issues/detail?id=45 It'd be extremely handly to have a maven repo somewhere. Right now I'm stuck deploying the jar files to a local repository. Since I was learning maven when I had to do so,

[piccolo2d-dev] Issue 101 in piccolo2d: Eliminate printStackTrace

2009-07-23 Thread codesite-noreply
Comment #8 on issue 101 by allain.lalonde: Eliminate printStackTrace http://code.google.com/p/piccolo2d/issues/detail?id=101 The first two are the topmost spot in an event dispatch loop, Swing using the printStackTrace behaviour when exceptions bubble up to the top, so I think this is one

[piccolo2d-dev] [piccolo2d] r555 commited - Removing unnecessary import

2009-07-23 Thread codesite-noreply
Revision: 555 Author: allain.lalonde Date: Thu Jul 23 19:24:54 2009 Log: Removing unnecessary import http://code.google.com/p/piccolo2d/source/detail?r=555 Modified: /piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManager.java

[piccolo2d-dev] Issue 101 in piccolo2d: Eliminate printStackTrace

2009-07-23 Thread codesite-noreply
Comment #9 on issue 101 by allain.lalonde: Eliminate printStackTrace http://code.google.com/p/piccolo2d/issues/detail?id=101 Wow, grammar on that last one was terrible. And that's my cue to stop coding. 'nite. -- You received this message because you are listed in the owner or CC fields of

[piccolo2d-dev] Issue 22 in piccolo2d: Name property for PNodes

2009-07-23 Thread codesite-noreply
Comment #14 on issue 22 by mr0...@mro.name: Name property for PNodes http://code.google.com/p/piccolo2d/issues/detail?id=22 using the client properties as backing storage makes the value check senseless. Also opens the door to name clashes for this important property with special meaning.

[piccolo2d-dev] [piccolo2d] r559 commited - Fixed bug with refactoring. copy and paste. dang.

2009-07-24 Thread codesite-noreply
Revision: 559 Author: allain.lalonde Date: Fri Jul 24 07:36:10 2009 Log: Fixed bug with refactoring. copy and paste. dang. http://code.google.com/p/piccolo2d/source/detail?r=559 Modified: /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PCanvas.java

[piccolo2d-dev] [piccolo2d] r560 commited - Moving helper method to bottom of MouseListener to be consistent.

2009-07-24 Thread codesite-noreply
Revision: 560 Author: allain.lalonde Date: Fri Jul 24 07:37:07 2009 Log: Moving helper method to bottom of MouseListener to be consistent. http://code.google.com/p/piccolo2d/source/detail?r=560 Modified: /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PCanvas.java

[piccolo2d-dev] [piccolo2d] r567 commited - Commenting out developer activity plugin in reports. Could not autogen...

2009-07-26 Thread codesite-noreply
Revision: 567 Author: allain.lalonde Date: Sun Jul 26 11:04:24 2009 Log: Commenting out developer activity plugin in reports. Could not autogenerate report from hudson http://code.google.com/p/piccolo2d/source/detail?r=567 Modified: /piccolo2d.java/trunk/parent/pom.xml

[piccolo2d-dev] Issue 108 in piccolo2d: Set up hudson CI build

2009-07-27 Thread codesite-noreply
Comment #7 on issue 108 by allain.lalonde: Set up hudson CI build http://code.google.com/p/piccolo2d/issues/detail?id=108 fixed in r584 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue

[piccolo2d-dev] [piccolo2d] r583 commited - issue#108 help hudson pick up the findbugs trends.

2009-07-27 Thread codesite-noreply
Revision: 583 Author: mr0...@mro.name Date: Mon Jul 27 10:53:50 2009 Log: issue#108 help hudson pick up the findbugs trends. http://code.google.com/p/piccolo2d/source/detail?r=583 Modified: /piccolo2d.java/branches/mvn4hudson/parent/pom.xml === ---

[piccolo2d-dev] [piccolo2d] r589 commited - Fixing implicit integer conversion by specifying that division is bein...

2009-07-27 Thread codesite-noreply
Revision: 589 Author: allain.lalonde Date: Mon Jul 27 14:24:39 2009 Log: Fixing implicit integer conversion by specifying that division is being done on an double. http://code.google.com/p/piccolo2d/source/detail?r=589 Modified:

[piccolo2d-dev] [piccolo2d] r590 commited - Making findbugs a little happier.

2009-07-27 Thread codesite-noreply
Revision: 590 Author: allain.lalonde Date: Mon Jul 27 15:02:47 2009 Log: Making findbugs a little happier. http://code.google.com/p/piccolo2d/source/detail?r=590 Modified: /piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/event/PSelectionEventHandler.java

[piccolo2d-dev] Issue 100 in piccolo2d: PInputEvent doesn't filter by modifier

2009-07-27 Thread codesite-noreply
Updates: Status: Verified Comment #2 on issue 100 by heuermh: PInputEvent doesn't filter by modifier http://code.google.com/p/piccolo2d/issues/detail?id=100 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this

[piccolo2d-dev] Issue 108 in piccolo2d: Set up hudson CI build

2009-07-27 Thread codesite-noreply
Updates: Status: Verified Comment #9 on issue 108 by heuermh: Set up hudson CI build http://code.google.com/p/piccolo2d/issues/detail?id=108 Looks great, nice work Allain and Marcus. -- You received this message because you are listed in the owner or CC fields of this issue, or because

[piccolo2d-dev] Issue 89 in piccolo2d: Low Test Coverage of PNode

2009-07-27 Thread codesite-noreply
Updates: Status: Verified Labels: Type-Enhancement Priority-Medium Effort-Medium Toolkit-Piccolo2D.Java OpSys-All Component-Core Milestone-1.3 Comment #4 on issue 89 by heuermh: Low Test Coverage of PNode http://code.google.com/p/piccolo2d/issues/detail?id=89 Test coverage has

[piccolo2d-dev] Issue 53 in piccolo2d: Headless build failure

2009-07-27 Thread codesite-noreply
Updates: Status: Accepted Comment #2 on issue 53 by heuermh: Headless build failure http://code.google.com/p/piccolo2d/issues/detail?id=53 See also Issue 108 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue.

[piccolo2d-dev] Issue 13 in piccolo2d: PSwing components cause extraneous redraws

2009-07-27 Thread codesite-noreply
Updates: Status: Started Comment #9 on issue 13 by heuermh: PSwing components cause extraneous redraws http://code.google.com/p/piccolo2d/issues/detail?id=13 Moving this one back to status Started, since work is still ongoing. -- You received this message because you are listed in

[piccolo2d-dev] Issue 21 in piccolo2d: Cannot turn off interacting at the PRoot level

2009-07-27 Thread codesite-noreply
Updates: Status: Verified Comment #8 on issue 21 by heuermh: Cannot turn off interacting at the PRoot level http://code.google.com/p/piccolo2d/issues/detail?id=21 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields

[piccolo2d-dev] Issue 82 in piccolo2d: JComboBox visibility doesn't affect visiblity of PSwing node

2009-07-27 Thread codesite-noreply
Updates: Status: Verified Comment #4 on issue 82 by heuermh: JComboBox visibility doesn't affect visiblity of PSwing node http://code.google.com/p/piccolo2d/issues/detail?id=82 (No comment was entered for this change.) -- You received this message because you are listed in the owner

[piccolo2d-dev] Issue 88 in piccolo2d: toImage doesn't return an image of the proper size

2009-07-27 Thread codesite-noreply
Updates: Status: Started Comment #5 on issue 88 by heuermh: toImage doesn't return an image of the proper size http://code.google.com/p/piccolo2d/issues/detail?id=88 Moving this one back to status Started, since work is still ongoing. -- You received this message because you are

[piccolo2d-dev] Issue 109 in piccolo2d: examples module should create a runnable jar

2009-07-27 Thread codesite-noreply
Status: New Owner: Labels: Type-Enhancement Priority-Medium OpSys-All Toolkit-Piccolo2D.Java Component-Examples New issue 109 by heuermh: examples module should create a runnable jar http://code.google.com/p/piccolo2d/issues/detail?id=109 The examples module should create a runnable jar

[piccolo2d-dev] [piccolo2d] r592 commited - Issue 19, Issue 90 ; rolling back changes made in r395

2009-07-27 Thread codesite-noreply
Revision: 592 Author: heuermh Date: Mon Jul 27 19:27:36 2009 Log: Issue 19, Issue 90 ; rolling back changes made in r395 http://code.google.com/p/piccolo2d/source/detail?r=592 Modified: /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PInputManager.java

[piccolo2d-dev] Issue 19 in piccolo2d: PInputEvent does not have camera information for keyboard events.

2009-07-27 Thread codesite-noreply
Comment #10 on issue 19 by heuermh: PInputEvent does not have camera information for keyboard events. http://code.google.com/p/piccolo2d/issues/detail?id=19 I'd like to go back to the drawing board on this one, so I am rolling back r395 to fix Issue 90 and await further comment. $ svn

[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent

2009-07-27 Thread codesite-noreply
Updates: Status: Fixed Comment #6 on issue 90 by heuermh: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 I am rolling back r395 to fix Issue 90 and await further comment on Issue 19. $ svn commit -m Issue 19, Issue 90 ;

[piccolo2d-dev] Issue 102 in piccolo2d: PNode.print swallows failures

2009-07-27 Thread codesite-noreply
Comment #1 on issue 102 by heuermh: PNode.print swallows failures http://code.google.com/p/piccolo2d/issues/detail?id=102 r562 changed this to throw RuntimeException, is that sufficient? -- You received this message because you are listed in the owner or CC fields of this issue, or because you

[piccolo2d-dev] Issue 53 in piccolo2d: Headless build failure

2009-07-27 Thread codesite-noreply
Updates: Status: Verified Comment #3 on issue 53 by heuermh: Headless build failure http://code.google.com/p/piccolo2d/issues/detail?id=53 Sorry, that should have been a change to status Verified. -- You received this message because you are listed in the owner or CC fields of this

[piccolo2d-dev] Issue 72 in piccolo2d: PSelectionEventHandler grip points do not scale with zoom

2009-07-27 Thread codesite-noreply
Comment #10 on issue 72 by heuermh: PSelectionEventHandler grip points do not scale with zoom http://code.google.com/p/piccolo2d/issues/detail?id=72 The method PSelectionEventHandler#decorateSelectedNode(PNode) is already public, so why need a different factory? Users are free to override

[piccolo2d-dev] Issue 19 in piccolo2d: PInputEvent does not have camera information for keyboard events.

2009-07-27 Thread codesite-noreply
Updates: Owner: s...@browsecode.org Comment #11 on issue 19 by heuermh: PInputEvent does not have camera information for keyboard events. http://code.google.com/p/piccolo2d/issues/detail?id=19 (No comment was entered for this change.) -- You received this message because you are

[piccolo2d-dev] Issue 71 in piccolo2d: PStyledTextEventHandler does not scale

2009-07-27 Thread codesite-noreply
Comment #6 on issue 71 by allain.lalonde: PStyledTextEventHandler does not scale http://code.google.com/p/piccolo2d/issues/detail?id=71 I think so. Seems more logical. I'll make the change. -- You received this message because you are listed in the owner or CC fields of this issue, or

[piccolo2d-dev] Issue 71 in piccolo2d: PStyledTextEventHandler does not scale

2009-07-27 Thread codesite-noreply
Updates: Status: Started Comment #7 on issue 71 by allain.lalonde: PStyledTextEventHandler does not scale http://code.google.com/p/piccolo2d/issues/detail?id=71 I think so. Seems more logical. I'll make the change. re-opening. -- You received this message because you are listed in

[piccolo2d-dev] Issue 13 in piccolo2d: PSwing components cause extraneous redraws

2009-07-27 Thread codesite-noreply
Comment #10 on issue 13 by allain.lalonde: PSwing components cause extraneous redraws http://code.google.com/p/piccolo2d/issues/detail?id=13 No further work will be done since the suggested fix was implemented. -- You received this message because you are listed in the owner or CC fields of

[piccolo2d-dev] Issue 110 in piccolo2d: Syntactical code clean

2009-07-28 Thread codesite-noreply
Comment #2 on issue 110 by mr0...@mro.name: Syntactical code clean http://code.google.com/p/piccolo2d/issues/detail?id=110 Let me refer to

[piccolo2d-dev] Issue 110 in piccolo2d: Syntactical code clean

2009-07-28 Thread codesite-noreply
Comment #3 on issue 110 by samrreid: Syntactical code clean http://code.google.com/p/piccolo2d/issues/detail?id=110 I presume that (3) doesn't entail making any classes or non-private methods final (none should be). What reasons has allain.lalonde given for not using 'final' where

<    1   2   3   4   5   6   >