[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Updates: Status: WontFix Comment #10 on issue 164 by heue...@gmail.com: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #9 on issue 164 by allain.lalonde: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 agreed -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #8 on issue 164 by heue...@gmail.com: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 OK if we mark as WontFix then? -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #7 on issue 164 by allain.lalonde: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 Agreed that if a client is directly manipulating the reference, their code will break, but since getChildReference is documented explicitly as "do not touch", I think that's ok. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #6 on issue 164 by samrreid: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 Immutability would be safest, but since the method is named getChildrenReference, it is possible that some client code is relying on the ability to directly manipulate the list of children. Therefore, it could be confusing to have this return a defensive list copy. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Updates: Owner: allain.lalonde Comment #5 on issue 164 by allain.lalonde: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 Should I modify getChildrenReference to user Collections.unmodifiableList ? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #4 on issue 164 by mr0...@mro.name: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 immutable? love this idea. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en To unsubscribe, reply using "remove me" as the subject.
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #3 on issue 164 by allain.lalonde: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 Alternative is to return the child collection using Collection.unmodifiableList wouldn't require a complete copy. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en To unsubscribe, reply using "remove me" as the subject.
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #2 on issue 164 by heue...@gmail.com: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 See also Issue 166. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en To unsubscribe, reply using "remove me" as the subject.
[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException
Comment #1 on issue 164 by heue...@gmail.com: PNode#moveToFront change to
avoid java.util.ConcurrentModificationException
http://code.google.com/p/piccolo2d/issues/detail?id=164
I vote to mark this as WontFix.
The method is throwing ConcurrentModificationException because that's what
is
happening, you are trying to modify the list as you are iterating over it.
The javadoc for PNode.getChildrenReference() reads "This list should not be
modified."
http://www.piccolo2d.org/doc/piccolo2d.java/release-1.2.1/apidocs/edu/umd/cs/piccolo/PNode.html#getChildrenReference%28%29
A workaround would be to copy the children list into a new ArrayList
List children = new ArrayList(node.getChildrenReference());
for (Iterator iterator = children.iterator(); iterator.hasNext(); )
{
PNode child = (PNode) iterator.next();
child.moveToFront();
}
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
