[piccolo2d-dev] Issue 134 in piccolo2d: PTransformActivity can throw null pointer exception
Comment #1 on issue 134 by heuermh: PTransformActivity can throw null pointer exception http://code.google.com/p/piccolo2d/issues/detail?id=134 Should setDestinationTransform throw NPE or IllegalArgumentException when passed in null? That seems better to me than throwing a NPE later or doing nothing after a null check. The Piccolo2D API is not very consistent when it comes to null parameters though. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 134 in piccolo2d: PTransformActivity can throw null pointer exception
Updates: Labels: -Milestone-1.3 Milestone-2.0 Comment #3 on issue 134 by heuermh: PTransformActivity can throw null pointer exception http://code.google.com/p/piccolo2d/issues/detail?id=134 The reference I often consult says that adding unchecked exceptions is ok http://wiki.eclipse.org/Evolving_Java-based_APIs_2 Add unchecked exceptions thrown - Binary compatible I agree on pushing to 2.0. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 134 in piccolo2d: PTransformActivity can throw null pointer exception
Status: Accepted Owner: allain.lalonde Labels: Type-Defect Priority-Medium Effort-Low Toolkit-Piccolo2D.Java Component-Core Milestone-1.3 New issue 134 by allain.lalonde: PTransformActivity can throw null pointer exception http://code.google.com/p/piccolo2d/issues/detail?id=134 What steps will reproduce the problem? 1. Create a new PTransformActivity 2. call setDestinationTransform(null) 3. Schedule the activity What is the expected output? What do you see instead? I'd expect that without a destination transform, it would do nothing with the target's transform, rather than throw a NPE. In the setRelativeTargetValue method, it makes reference to destination wihout first checking it for null (which is can clearly be). Under most circumstances, this should never happen, but the class makes it too easy to setup an impossible situation. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
