[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Updates: Status: Verified Comment #15 on issue 185 by atdi...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Updates: Status: Fixed Comment #14 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Applied patch on release-1.3 branch. $ svn commit -m "Issue 185 ; applying patch issue185fix.patch" . Committed revision 1087. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Updates: Blockedon: 195 Comment #13 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #12 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Applied patch on trunk. $ svn commit -m "Issue 185 ; applying patch issue185fix.patch" . Committed revision 1085. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #11 on issue 185 by nlskrg: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 The ArrayList activities may be modified while iterating over processingActivities, e.g., a finished activity is removed. I think, this isn't a problem when iterating in reverse, since it is always the last element that is removed. However, possibly other modification may occur triggered by activity delegates. Possibly such modifications should be supported by this temporary copy of the ArrayList activities? -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #10 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Is there any reason that ArrayList processingActivities needs to exist at all? Cannot processActivities iterate in reverse over the activities in activities directly? -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Updates: Status: Started Comment #9 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Reopening per comments 7 & 8. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #8 on issue 185 by atdixon: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Thanks, nlskrg, I agree. I code read your patch and it looks correct to me. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #7 on issue 185 by nlskrg: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 The patch renders the first call of processingActivities.clear(); redundant (in the same procedure the patch was applied to). I think the first line thus should be removed to keep the code clear. Furthermore the example uses piccolo from a thread other than the event dispatch thread. This possibly does not affect the issue demonstrated by the example, but is not the right way to go as piccolo is not thread-safe. Attachments: issue185fix.patch 2.1 KB -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Updates: Status: Verified Comment #6 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #5 on issue 185 by atdixon: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Verified in trunk and release-1.3. Thanks! -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Updates: Status: Fixed Comment #4 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Applied to trunk $ svn commit -m "Issue 185 ; applying patch from atdixon with minor changes, list of activities is cleared after activities are processed" . Sending core/src/main/java/org/piccolo2d/activities/PActivityScheduler.java Adding examples/src/main/java/org/piccolo2d/examples/ActivityMemoryLeakBugExample.java Sendingparent/pom.xml Transmitting file data ... Committed revision 1038. and release-1.3 branch $ svn commit -m "Issue 185 ; applying patch from atdixon with minor changes, list of activities is cleared after activities are processed" . Sending core/src/main/java/edu/umd/cs/piccolo/activities/PActivityScheduler.java Adding examples/src/main/java/edu/umd/cs/piccolo/examples/ActivityMemoryLeakBugExample.java Sendingparent/pom.xml Transmitting file data ... Committed revision 1039. Thanks again for your patch, please verify. Created a new issue 186 for the org.piccolo2d.examples.bugs package idea. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #3 on issue 185 by atdixon: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Patch attached which includes both: - parent/pom.xml (contributors update) - examples/src/main/java/org/piccolo2d/examples/ActivityMemoryLeakBugExample.java What do you think of putting "bug" examples in separate package (e.g., org.piccolo2d.examples.bugs)? Attachments: ActivityMemoryLeakBugExample.patch 5.0 KB -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Updates: Status: Accepted Owner: heuermh Labels: Type-Defect Priority-High Effort-Medium OpSys-All Toolkit-Piccolo2D.Java Component-Core Milestone-1.3.1 Comment #2 on issue 185 by heue...@gmail.com: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Thank you for the patch. Would it be ok to include your example in the Piccolo2D source tree? The standard Piccolo2D license header http://code.google.com/p/piccolo2d/source/browse/piccolo2d.java/trunk/license-piccolo.txt would need to be added. Best yet would be if you might include that as an attachment to this issue along with a patch to the section of the Piccolo2D parent pom http://code.google.com/p/piccolo2d/source/browse/piccolo2d.java/trunk/parent/pom.xml to mark your contribution. I could then apply the patch to trunk and with minor changes (remove java 1.5+ syntax) to the release-1.3 branch. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 185 in piccolo2d: Memory leak - PActivityScheduler keeps processed activities in reference
Comment #1 on issue 185 by atdixon: Memory leak - PActivityScheduler keeps processed activities in reference http://code.google.com/p/piccolo2d/issues/detail?id=185 Attaching patch that fixes 185. Attachments: Piccolo2D_Java_185.patch 542 bytes -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
