Author: gates
Date: Fri Apr 18 15:11:59 2008
New Revision: 649710
URL: http://svn.apache.org/viewvc?rev=649710&view=rev
Log:
PIG-213: Remove non-static references to logger from data bags and tuples, as
it causes significant overhead.
Modified:
incubator/pig/trunk/CHANGES.txt
incubator/pig/trunk/src/org/apache/pig/data/DataBag.java
incubator/pig/trunk/src/org/apache/pig/data/DefaultDataBag.java
incubator/pig/trunk/src/org/apache/pig/data/DistinctDataBag.java
incubator/pig/trunk/src/org/apache/pig/data/SortedDataBag.java
incubator/pig/trunk/src/org/apache/pig/data/TimestampedTuple.java
incubator/pig/trunk/src/org/apache/pig/data/Tuple.java
Modified: incubator/pig/trunk/CHANGES.txt
URL:
http://svn.apache.org/viewvc/incubator/pig/trunk/CHANGES.txt?rev=649710&r1=649709&r2=649710&view=diff
==============================================================================
--- incubator/pig/trunk/CHANGES.txt (original)
+++ incubator/pig/trunk/CHANGES.txt Fri Apr 18 15:11:59 2008
@@ -240,3 +240,6 @@
PIG-114: store one alias/logicalPlan twice leads to instantiation of
StoreFunc as LoadFunc (pi_song via gates).
+
+ PIG-213: Remove non-static references to logger from data bags and
tuples,
+ as it causes significant overhead (vgeschel via gates).
Modified: incubator/pig/trunk/src/org/apache/pig/data/DataBag.java
URL:
http://svn.apache.org/viewvc/incubator/pig/trunk/src/org/apache/pig/data/DataBag.java?rev=649710&r1=649709&r2=649710&view=diff
==============================================================================
--- incubator/pig/trunk/src/org/apache/pig/data/DataBag.java (original)
+++ incubator/pig/trunk/src/org/apache/pig/data/DataBag.java Fri Apr 18
15:11:59 2008
@@ -69,7 +69,7 @@
*/
public abstract class DataBag extends Datum implements Spillable,
Iterable<Tuple> {
- private final Log log = LogFactory.getLog(getClass());
+ private static final Log log = LogFactory.getLog(DataBag.class);
// Container that holds the tuples. Actual object instantiated by
// subclasses.
Modified: incubator/pig/trunk/src/org/apache/pig/data/DefaultDataBag.java
URL:
http://svn.apache.org/viewvc/incubator/pig/trunk/src/org/apache/pig/data/DefaultDataBag.java?rev=649710&r1=649709&r2=649710&view=diff
==============================================================================
--- incubator/pig/trunk/src/org/apache/pig/data/DefaultDataBag.java (original)
+++ incubator/pig/trunk/src/org/apache/pig/data/DefaultDataBag.java Fri Apr 18
15:11:59 2008
@@ -38,7 +38,7 @@
*/
public class DefaultDataBag extends DataBag {
- private final Log log = LogFactory.getLog(getClass());
+ private static final Log log = LogFactory.getLog(DefaultDataBag.class);
public DefaultDataBag() {
mContents = new ArrayList<Tuple>();
Modified: incubator/pig/trunk/src/org/apache/pig/data/DistinctDataBag.java
URL:
http://svn.apache.org/viewvc/incubator/pig/trunk/src/org/apache/pig/data/DistinctDataBag.java?rev=649710&r1=649709&r2=649710&view=diff
==============================================================================
--- incubator/pig/trunk/src/org/apache/pig/data/DistinctDataBag.java (original)
+++ incubator/pig/trunk/src/org/apache/pig/data/DistinctDataBag.java Fri Apr 18
15:11:59 2008
@@ -51,7 +51,7 @@
*/
public class DistinctDataBag extends DataBag {
- private final Log log = LogFactory.getLog(getClass());
+ private static final Log log = LogFactory.getLog(DistinctDataBag.class);
public DistinctDataBag() {
mContents = new HashSet<Tuple>();
Modified: incubator/pig/trunk/src/org/apache/pig/data/SortedDataBag.java
URL:
http://svn.apache.org/viewvc/incubator/pig/trunk/src/org/apache/pig/data/SortedDataBag.java?rev=649710&r1=649709&r2=649710&view=diff
==============================================================================
--- incubator/pig/trunk/src/org/apache/pig/data/SortedDataBag.java (original)
+++ incubator/pig/trunk/src/org/apache/pig/data/SortedDataBag.java Fri Apr 18
15:11:59 2008
@@ -51,7 +51,7 @@
*/
public class SortedDataBag extends DataBag {
- private final Log log = LogFactory.getLog(getClass());
+ private static final Log log = LogFactory.getLog(SortedDataBag.class);
private Comparator<Tuple> mComp;
private boolean mReadStarted = false;
Modified: incubator/pig/trunk/src/org/apache/pig/data/TimestampedTuple.java
URL:
http://svn.apache.org/viewvc/incubator/pig/trunk/src/org/apache/pig/data/TimestampedTuple.java?rev=649710&r1=649709&r2=649710&view=diff
==============================================================================
--- incubator/pig/trunk/src/org/apache/pig/data/TimestampedTuple.java (original)
+++ incubator/pig/trunk/src/org/apache/pig/data/TimestampedTuple.java Fri Apr
18 15:11:59 2008
@@ -26,7 +26,7 @@
public class TimestampedTuple extends Tuple {
- private final Log log = LogFactory.getLog(getClass());
+ private static final Log log = LogFactory.getLog(TimestampedTuple.class);
protected double timestamp = 0; // timestamp of this tuple
protected boolean heartbeat = false; // true iff this is a heartbeat
(i.e. purpose is just to convey new timestamp; carries no data)
Modified: incubator/pig/trunk/src/org/apache/pig/data/Tuple.java
URL:
http://svn.apache.org/viewvc/incubator/pig/trunk/src/org/apache/pig/data/Tuple.java?rev=649710&r1=649709&r2=649710&view=diff
==============================================================================
--- incubator/pig/trunk/src/org/apache/pig/data/Tuple.java (original)
+++ incubator/pig/trunk/src/org/apache/pig/data/Tuple.java Fri Apr 18 15:11:59
2008
@@ -34,7 +34,7 @@
*/
public class Tuple extends Datum implements WritableComparable {
- private final Log log = LogFactory.getLog(getClass());
+ private static final Log log = LogFactory.getLog(Tuple.class);
protected ArrayList<Datum> fields;
static String defaultDelimiter = "[,\t]";
