Author: pisong
Date: Fri Jul 11 05:13:37 2008
New Revision: 675927

URL: http://svn.apache.org/viewvc?rev=675927&view=rev
Log:
PIG-295 Shravan's fix to unit test that hides error

Modified:
    incubator/pig/branches/types/test/org/apache/pig/test/TestEvalPipeline.java

Modified: 
incubator/pig/branches/types/test/org/apache/pig/test/TestEvalPipeline.java
URL: 
http://svn.apache.org/viewvc/incubator/pig/branches/types/test/org/apache/pig/test/TestEvalPipeline.java?rev=675927&r1=675926&r2=675927&view=diff
==============================================================================
--- incubator/pig/branches/types/test/org/apache/pig/test/TestEvalPipeline.java 
(original)
+++ incubator/pig/branches/types/test/org/apache/pig/test/TestEvalPipeline.java 
Fri Jul 11 05:13:37 2008
@@ -24,6 +24,7 @@
 import java.io.PrintWriter;
 import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
@@ -323,14 +324,20 @@
         
         pig.registerQuery("A = load '" + tmpOutputFile + "';");
         Iterator<Tuple> iter = pig.openIterator("A");
-        int last = -1;
+        String last = "";
+        HashSet<Integer> seen = new HashSet<Integer>();
+        if(!iter.hasNext()) fail("No Results obtained");
         while (iter.hasNext()){
             Tuple t = iter.next();
+            System.out.println(t.get(0).toString());
             if (eliminateDuplicates){
-                assertTrue(last < Integer.valueOf(t.get(0).toString()));
+                Integer act = Integer.parseInt(t.get(0).toString());
+                assertFalse(seen.contains(act));
+                seen.add(act);
             }else{
-                assertTrue(last <= DataType.toDouble(t.get(0)));
+                assertTrue(last.compareTo(t.get(0).toString())<=0);
                 assertEquals(t.size(), 2);
+                last = t.get(0).toString();
             }
         }
         


Reply via email to