[jira] Commented: (PIG-963) Join in local mode matches null keys
[ https://issues.apache.org/jira/browse/PIG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756166#action_12756166 ] Daniel Dai commented on PIG-963: +1 Join in local mode matches null keys Key: PIG-963 URL: https://issues.apache.org/jira/browse/PIG-963 Project: Pig Issue Type: Bug Affects Versions: 0.4.0 Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-963-2.patch, PIG-963.patch Semantics of join and cogroup dictate that null values for the keys from different inputs are NOT supposed to match. This is true in map reduce mode but local mode incorrectly matches these records. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-963) Join in local mode matches null keys
[ https://issues.apache.org/jira/browse/PIG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756168#action_12756168 ] Pradeep Kamath commented on PIG-963: This patch does not address the case where the join key is more than one column and hence represented as a tuple. In this case if one of the key's value is null, join will still use Tuple.compare() which will treat two null fields as equals. This is a known issue in map reduce mode also and should be fixed for both map reduce and local mode through https://issues.apache.org/jira/browse/PIG-927 Join in local mode matches null keys Key: PIG-963 URL: https://issues.apache.org/jira/browse/PIG-963 Project: Pig Issue Type: Bug Affects Versions: 0.4.0 Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-963-2.patch, PIG-963.patch Semantics of join and cogroup dictate that null values for the keys from different inputs are NOT supposed to match. This is true in map reduce mode but local mode incorrectly matches these records. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-963) Join in local mode matches null keys
[ https://issues.apache.org/jira/browse/PIG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756204#action_12756204 ] Hadoop QA commented on PIG-963: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419719/PIG-963.patch against trunk revision 815571. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/33/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/33/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/33/console This message is automatically generated. Join in local mode matches null keys Key: PIG-963 URL: https://issues.apache.org/jira/browse/PIG-963 Project: Pig Issue Type: Bug Affects Versions: 0.4.0 Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-963-2.patch, PIG-963.patch Semantics of join and cogroup dictate that null values for the keys from different inputs are NOT supposed to match. This is true in map reduce mode but local mode incorrectly matches these records. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-963) Join in local mode matches null keys
[ https://issues.apache.org/jira/browse/PIG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756256#action_12756256 ] Hadoop QA commented on PIG-963: --- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419802/PIG-963-2.patch against trunk revision 815934. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/34/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/34/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/34/console This message is automatically generated. Join in local mode matches null keys Key: PIG-963 URL: https://issues.apache.org/jira/browse/PIG-963 Project: Pig Issue Type: Bug Affects Versions: 0.4.0 Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-963-2.patch, PIG-963.patch Semantics of join and cogroup dictate that null values for the keys from different inputs are NOT supposed to match. This is true in map reduce mode but local mode incorrectly matches these records. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-963) Join in local mode matches null keys
[ https://issues.apache.org/jira/browse/PIG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756306#action_12756306 ] Hadoop QA commented on PIG-963: --- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419802/PIG-963-2.patch against trunk revision 815934. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/35/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/35/console This message is automatically generated. Join in local mode matches null keys Key: PIG-963 URL: https://issues.apache.org/jira/browse/PIG-963 Project: Pig Issue Type: Bug Affects Versions: 0.4.0 Reporter: Pradeep Kamath Assignee: Pradeep Kamath Fix For: 0.5.0 Attachments: PIG-963-2.patch, PIG-963.patch Semantics of join and cogroup dictate that null values for the keys from different inputs are NOT supposed to match. This is true in map reduce mode but local mode incorrectly matches these records. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-963) Join in local mode matches null keys
[ https://issues.apache.org/jira/browse/PIG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12755868#action_12755868 ] Hadoop QA commented on PIG-963: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419719/PIG-963.patch against trunk revision 815571. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/30/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/30/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/30/console This message is automatically generated. Join in local mode matches null keys Key: PIG-963 URL: https://issues.apache.org/jira/browse/PIG-963 Project: Pig Issue Type: Bug Affects Versions: 0.4.0 Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-963.patch Semantics of join and cogroup dictate that null values for the keys from different inputs are NOT supposed to match. This is true in map reduce mode but local mode incorrectly matches these records. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
