[jira] Updated: (PIG-1040) FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be

2009-10-30 Thread Olga Natkovich (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1040:


Resolution: Fixed
Status: Resolved  (was: Patch Available)

patch committed

 FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be
 -

 Key: PIG-1040
 URL: https://issues.apache.org/jira/browse/PIG-1040
 Project: Pig
  Issue Type: Improvement
Reporter: Olga Natkovich
Assignee: Olga Natkovich
 Attachments: PIG-1040.patch


 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.USER_COMPARATOR_MARKER
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.WeightedRangePartitioner.weightedParts
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce.sJobConf
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.POProject.bagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.reporter
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.pigLogger
  should be package protected
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBag
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBool
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDBA
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDouble
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyFloat
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyInt
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyLong
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyMap
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyString
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyTuple
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POLocalRearrange.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mBagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPreCombinerLocalRearrange.mTupleFactory
  isn't final but should be
 MSorg.apache.pig.builtin.PigDump.recordDelimiter isn't final but should be
 MSorg.apache.pig.impl.builtin.GFCross.DEFAULT_PARALLELISM isn't final but 
 should be
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanBuilder.classloader isn't 
 final and can't be protected from malicious code
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper.mOpToCloneMap 
 should be package protected
 MS
 org.apache.pig.impl.logicalLayer.schema.Schema$FieldSchema.canonicalNamer 
 isn't final but should be
 MS
 org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.castLookup 
 isn't final but should be
 MSorg.apache.pig.impl.plan.OperatorPlan.log isn't final but should be

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-1040) FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be

2009-10-29 Thread Olga Natkovich (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1040:


Status: Patch Available  (was: Open)

 FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be
 -

 Key: PIG-1040
 URL: https://issues.apache.org/jira/browse/PIG-1040
 Project: Pig
  Issue Type: Improvement
Reporter: Olga Natkovich
Assignee: Olga Natkovich
 Attachments: PIG-1040.patch


 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.USER_COMPARATOR_MARKER
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.WeightedRangePartitioner.weightedParts
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce.sJobConf
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.POProject.bagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.reporter
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.pigLogger
  should be package protected
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBag
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBool
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDBA
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDouble
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyFloat
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyInt
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyLong
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyMap
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyString
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyTuple
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POLocalRearrange.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mBagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPreCombinerLocalRearrange.mTupleFactory
  isn't final but should be
 MSorg.apache.pig.builtin.PigDump.recordDelimiter isn't final but should be
 MSorg.apache.pig.impl.builtin.GFCross.DEFAULT_PARALLELISM isn't final but 
 should be
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanBuilder.classloader isn't 
 final and can't be protected from malicious code
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper.mOpToCloneMap 
 should be package protected
 MS
 org.apache.pig.impl.logicalLayer.schema.Schema$FieldSchema.canonicalNamer 
 isn't final but should be
 MS
 org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.castLookup 
 isn't final but should be
 MSorg.apache.pig.impl.plan.OperatorPlan.log isn't final but should be

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-1040) FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be

2009-10-23 Thread Olga Natkovich (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1040:


Attachment: PIG-1040.patch

I ran all unit tests. can one of the committers please review.

 FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be
 -

 Key: PIG-1040
 URL: https://issues.apache.org/jira/browse/PIG-1040
 Project: Pig
  Issue Type: Improvement
Reporter: Olga Natkovich
Assignee: Olga Natkovich
 Attachments: PIG-1040.patch


 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.USER_COMPARATOR_MARKER
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.WeightedRangePartitioner.weightedParts
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce.sJobConf
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.POProject.bagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.reporter
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.pigLogger
  should be package protected
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBag
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBool
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDBA
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDouble
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyFloat
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyInt
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyLong
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyMap
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyString
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyTuple
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POLocalRearrange.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mBagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPreCombinerLocalRearrange.mTupleFactory
  isn't final but should be
 MSorg.apache.pig.builtin.PigDump.recordDelimiter isn't final but should be
 MSorg.apache.pig.impl.builtin.GFCross.DEFAULT_PARALLELISM isn't final but 
 should be
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanBuilder.classloader isn't 
 final and can't be protected from malicious code
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper.mOpToCloneMap 
 should be package protected
 MS
 org.apache.pig.impl.logicalLayer.schema.Schema$FieldSchema.canonicalNamer 
 isn't final but should be
 MS
 org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.castLookup 
 isn't final but should be
 MSorg.apache.pig.impl.plan.OperatorPlan.log isn't final but should be

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-1040) FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be

2009-10-23 Thread Olga Natkovich (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1040:


Comment: was deleted

(was: I ran all unit tests. can one of the committers please review.)

 FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be
 -

 Key: PIG-1040
 URL: https://issues.apache.org/jira/browse/PIG-1040
 Project: Pig
  Issue Type: Improvement
Reporter: Olga Natkovich
Assignee: Olga Natkovich

 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.USER_COMPARATOR_MARKER
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.WeightedRangePartitioner.weightedParts
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce.sJobConf
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.POProject.bagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.reporter
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.pigLogger
  should be package protected
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBag
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBool
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDBA
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDouble
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyFloat
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyInt
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyLong
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyMap
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyString
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyTuple
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POLocalRearrange.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mBagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPreCombinerLocalRearrange.mTupleFactory
  isn't final but should be
 MSorg.apache.pig.builtin.PigDump.recordDelimiter isn't final but should be
 MSorg.apache.pig.impl.builtin.GFCross.DEFAULT_PARALLELISM isn't final but 
 should be
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanBuilder.classloader isn't 
 final and can't be protected from malicious code
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper.mOpToCloneMap 
 should be package protected
 MS
 org.apache.pig.impl.logicalLayer.schema.Schema$FieldSchema.canonicalNamer 
 isn't final but should be
 MS
 org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.castLookup 
 isn't final but should be
 MSorg.apache.pig.impl.plan.OperatorPlan.log isn't final but should be

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-1040) FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be

2009-10-23 Thread Olga Natkovich (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1040:


Attachment: (was: PIG-1040.patch)

 FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be
 -

 Key: PIG-1040
 URL: https://issues.apache.org/jira/browse/PIG-1040
 Project: Pig
  Issue Type: Improvement
Reporter: Olga Natkovich
Assignee: Olga Natkovich

 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.USER_COMPARATOR_MARKER
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.WeightedRangePartitioner.weightedParts
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce.sJobConf
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.POProject.bagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.reporter
  isn't final and can't be protected from malicious code
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.pigLogger
  should be package protected
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBag
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBool
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDBA
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDouble
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyFloat
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyInt
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyLong
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyMap
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyString
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyTuple
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POLocalRearrange.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mBagFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mTupleFactory
  isn't final but should be
 MS
 org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPreCombinerLocalRearrange.mTupleFactory
  isn't final but should be
 MSorg.apache.pig.builtin.PigDump.recordDelimiter isn't final but should be
 MSorg.apache.pig.impl.builtin.GFCross.DEFAULT_PARALLELISM isn't final but 
 should be
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanBuilder.classloader isn't 
 final and can't be protected from malicious code
 MSorg.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper.mOpToCloneMap 
 should be package protected
 MS
 org.apache.pig.impl.logicalLayer.schema.Schema$FieldSchema.canonicalNamer 
 isn't final but should be
 MS
 org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.castLookup 
 isn't final but should be
 MSorg.apache.pig.impl.plan.OperatorPlan.log isn't final but should be

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.