Bug in new logical optimizer framework?

2010-06-27 Thread Swati Jain
Folks, Posting on the dev since this is regarding the new logical plan optimization framework which is not enabled yet. I was interested in playing around with the new optimization framework and try adding some simple rules to it. I have attached two simple programs which do not work when the

PIG Logical Optimization: Use CNF in SplitFilter

2010-07-05 Thread Swati Jain
Hi, I am interested in implementing logical optimization rules and to target this I have studied currently implemented logical rules and the rule framework. In particular, I felt that rules dealing with LOfilter are not able to handle complicated boolean expressions. I would like to share

Re: PIG Logical Optimization: Use CNF in SplitFilter

2010-07-10 Thread Swati Jain
-expressions. Thanks, Yan -Original Message- From: Swati Jain [mailto:swat...@aggiemail.usu.edu] Sent: Monday, July 05, 2010 2:34 AM To: pig-dev@hadoop.apache.org Cc: Daniel Dai Subject: PIG Logical Optimization: Use CNF in SplitFilter Hi, I am interested in implementing logical

Re: PIG Logical Optimization: Use CNF in SplitFilter

2010-07-12 Thread Swati Jain
, Yan -- *From:* Swati Jain [mailto:swat...@aggiemail.usu.edu] *Sent:* Friday, July 09, 2010 11:00 PM *To:* Yan Zhou *Cc:* pig-dev@hadoop.apache.org *Subject:* Re: PIG Logical Optimization: Use CNF in SplitFilter Hi Yan, I agree that the first scenario

PIG Logical Optimization: Use CNF in SplitFilter

2010-07-12 Thread Swati Jain
. Thanks, Yan -- *From:* Swati Jain [mailto:swat...@aggiemail.usu.edu] *Sent:* Monday, July 12, 2010 11:52 AM *To:* Yan Zhou *Cc:* pig-dev@hadoop.apache.org *Subject:* Re: PIG Logical Optimization: Use CNF in SplitFilter I was wondering if you are not going

Re: PIG Logical Optimization: Use CNF in SplitFilter

2010-07-12 Thread Swati Jain
to support scenario 1, which will push up all possible filters closer to source and have all benefits on pruned I/O, we should not use CNF. Thanks, Yan -Original Message- From: Swati Jain [mailto:swat...@aggiemail.usu.edu] Sent: Monday, July 12, 2010 4:04 PM To: pig-dev

Add deepCopy in LogicalExpression

2010-07-13 Thread Swati Jain
Hi, I am working on ticket PIG -1494 ( https://issues.apache.org/jira/browse/PIG-1494 ). While implementing this functionality (conversion of logical expression into CNF), I need to construct the OperatorPlan for the base expressions of the CNF. For example, given an expression (c1 10) AND

Re: Add deepCopy in LogicalExpression

2010-07-13 Thread Swati Jain
? Alan. On Jul 12, 2010, at 11:19 PM, Swati Jain wrote: Hi, I am working on ticket PIG -1494 ( https://issues.apache.org/jira/browse/PIG-1494 ). While implementing this functionality (conversion of logical expression into CNF), I need to construct the OperatorPlan for the base expressions

Multiple successors

2010-07-20 Thread Swati Jain
I noticed a number of places in the code where the successors of a LogicalRelationalOperator is accessed as op.successors.get(0). Is it always the case that logical relational operators (in the new logical optimizer framework) have only 1 successor? Why dont the rules iterate over the successors

[jira] Commented: (PIG-1494) PIG Logical Optimization: Use CNF in PushUpFilter

2010-07-12 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887425#action_12887425 ] Swati Jain commented on PIG-1494: - Reply from Yan Zhou: The filter logic split problem can

[jira] Created: (PIG-1494) PIG Logical Optimization: Use CNF in PushUpFilter

2010-07-12 Thread Swati Jain (JIRA)
Affects Versions: 0.7.0 Reporter: Swati Jain Priority: Minor Fix For: 0.8.0 The PushUpFilter rule is not able to handle complicated boolean expressions. For example, SplitFilter rule is splitting one LOFilter into two by AND. However it will not be able to split

[jira] Created: (PIG-1510) Add `deepCopy` for LogicalExpressions

2010-07-21 Thread Swati Jain (JIRA)
Reporter: Swati Jain Assignee: Swati Jain Fix For: 0.8.0 It would be useful to have a way to `deepCopy` an expression. `deepCopy` will create a new object so that changes made to one object will not reflect in the copy. There are 2 reasons why we don't override

[jira] Assigned: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain reassigned PIG-1512: --- Assignee: Swati Jain PlanPrinter does not print LOJoin operator in the new logical optimization

[jira] Updated: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1512: Attachment: printJoin.patch PlanPrinter does not print LOJoin operator in the new logical optimization

[jira] Updated: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1512: Attachment: printJoin.patch Fix tab character PlanPrinter does not print LOJoin operator in the new

[jira] Updated: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1512: Attachment: printJoin.patch Attach the right file, final upload. PlanPrinter does not print LOJoin

[jira] Work started: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on PIG-1512 started by Swati Jain. PlanPrinter does not print LOJoin operator in the new logical optimization framework

[jira] Created: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
Issue Type: Bug Affects Versions: 0.8.0 Reporter: Swati Jain Fix For: 0.8.0 Attachments: printJoin.patch PlanPrinter does not print LOJoin relational operator. As such, the LOJoin operator would not get printed when we do an explain

[jira] Updated: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1512: Attachment: (was: printJoin.patch) PlanPrinter does not print LOJoin operator in the new logical

[jira] Updated: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1512: Attachment: (was: printJoin.patch) PlanPrinter does not print LOJoin operator in the new logical

[jira] Updated: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1512: Patch Info: [Patch Available] PlanPrinter does not print LOJoin operator in the new logical optimization

[jira] Updated: (PIG-1512) PlanPrinter does not print LOJoin operator in the new logical optimization framework

2010-07-22 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1512: Status: Patch Available (was: In Progress) PlanPrinter does not print LOJoin operator in the new logical

[jira] Created: (PIG-1530) PIG Logical Optimization: Push LOFilter above LOCogroup

2010-07-31 Thread Swati Jain (JIRA)
: impl Reporter: Swati Jain Assignee: Swati Jain Priority: Minor Fix For: 0.8.0 Consider the following: {noformat} A = load 'any file' USING PigStorage(',') as (a1:int,a2:int,a3:int); B = load 'any file' USING PigStorage(',') as (b1:int,b2:int,b3:int

[jira] Commented: (PIG-1530) PIG Logical Optimization: Push LOFilter above LOCogroup

2010-08-01 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894467#action_12894467 ] Swati Jain commented on PIG-1530: - a) This is not a developer coding issue. The example I

[jira] Updated: (PIG-1510) Add `deepCopy` for LogicalExpressions

2010-08-15 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1510: Patch Info: [Patch Available] Add `deepCopy` for LogicalExpressions

[jira] Updated: (PIG-1510) Add `deepCopy` for LogicalExpressions

2010-08-15 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1510: Attachment: deepCopy.patch Revised patch after merging changes. Also wrote a unit test. Add `deepCopy

[jira] Updated: (PIG-1510) Add `deepCopy` for LogicalExpressions

2010-08-15 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1510: Status: Patch Available (was: In Progress) Add `deepCopy` for LogicalExpressions

[jira] Updated: (PIG-1510) Add `deepCopy` for LogicalExpressions

2010-08-15 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1510: Status: In Progress (was: Patch Available) Add `deepCopy` for LogicalExpressions

[jira] Commented: (PIG-1510) Add `deepCopy` for LogicalExpressions

2010-08-16 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899282#action_12899282 ] Swati Jain commented on PIG-1510: - We make a copy of all instance variables, including

[jira] Created: (PIG-1549) Provide utility to construct CNF form of predicates

2010-08-18 Thread Swati Jain (JIRA)
Affects Versions: 0.8.0 Reporter: Swati Jain Assignee: Swati Jain Fix For: 0.8.0 Provide utility to construct CNF form of predicates -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

[jira] Commented: (PIG-1549) Provide utility to construct CNF form of predicates

2010-08-18 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899785#action_12899785 ] Swati Jain commented on PIG-1549: - Details about the benefits are listed in PIG-1494

[jira] Updated: (PIG-1549) Provide utility to construct CNF form of predicates

2010-08-18 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1549: Attachment: 0001-Add-CNF-utility-class.patch Added the patch file generated by git. Provide utility

[jira] Updated: (PIG-1549) Provide utility to construct CNF form of predicates

2010-08-18 Thread Swati Jain (JIRA)
[ https://issues.apache.org/jira/browse/PIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swati Jain updated PIG-1549: Status: Patch Available (was: Open) Provide utility to construct CNF form of predicates