[jira] Commented: (PIG-1008) FINDBUGS: NP_TOSTRING_COULD_RETURN_NULL

2009-10-15 Thread Daniel Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766149#action_12766149
 ] 

Daniel Dai commented on PIG-1008:
-

+1. Two target findbugs warnings suppressed.

> FINDBUGS: NP_TOSTRING_COULD_RETURN_NULL
> ---
>
> Key: PIG-1008
> URL: https://issues.apache.org/jira/browse/PIG-1008
> Project: Pig
>  Issue Type: Bug
>Reporter: Olga Natkovich
> Attachments: PIG-1008.patch
>
>
> NPorg.apache.pig.data.DataByteArray.toString() may return null
> NP
> org.apache.pig.impl.streaming.StreamingCommand$HandleSpec.equals(Object) does 
> not check for null argument

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1008) FINDBUGS: NP_TOSTRING_COULD_RETURN_NULL

2009-10-14 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765901#action_12765901
 ] 

Hadoop QA commented on PIG-1008:


-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12422155/PIG-1008.patch
  against trunk revision 825308.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/27/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/27/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/27/console

This message is automatically generated.

> FINDBUGS: NP_TOSTRING_COULD_RETURN_NULL
> ---
>
> Key: PIG-1008
> URL: https://issues.apache.org/jira/browse/PIG-1008
> Project: Pig
>  Issue Type: Bug
>Reporter: Olga Natkovich
> Attachments: PIG-1008.patch
>
>
> NPorg.apache.pig.data.DataByteArray.toString() may return null
> NP
> org.apache.pig.impl.streaming.StreamingCommand$HandleSpec.equals(Object) does 
> not check for null argument

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.