[jira] Commented: (PIG-1019) FINDBUGS: add exclude file

2009-10-13 Thread Alan Gates (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765131#action_12765131
 ] 

Alan Gates commented on PIG-1019:
-

+1

> FINDBUGS: add exclude file
> --
>
> Key: PIG-1019
> URL: https://issues.apache.org/jira/browse/PIG-1019
> Project: Pig
>  Issue Type: Bug
>Reporter: Olga Natkovich
>Assignee: Olga Natkovich
> Attachments: PIG-1019.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1019) FINDBUGS: add exclude file

2009-10-13 Thread Olga Natkovich (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765116#action_12765116
 ] 

Olga Natkovich commented on PIG-1019:
-

-1 on tests is ok since this is not a code related patch
-1 on release audit is also ok - it is due to exclude file not having a header

can one of the committers review the patch, please.

> FINDBUGS: add exclude file
> --
>
> Key: PIG-1019
> URL: https://issues.apache.org/jira/browse/PIG-1019
> Project: Pig
>  Issue Type: Bug
>Reporter: Olga Natkovich
>Assignee: Olga Natkovich
> Attachments: PIG-1019.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1019) FINDBUGS: add exclude file

2009-10-12 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764945#action_12764945
 ] 

Hadoop QA commented on PIG-1019:


-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12421933/PIG-1019.patch
  against trunk revision 824446.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

-1 release audit.  The applied patch generated 292 release audit warnings 
(more than the trunk's current 291 warnings).

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/20/testReport/
Release audit warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/20/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/20/console

This message is automatically generated.

> FINDBUGS: add exclude file
> --
>
> Key: PIG-1019
> URL: https://issues.apache.org/jira/browse/PIG-1019
> Project: Pig
>  Issue Type: Bug
>Reporter: Olga Natkovich
>Assignee: Olga Natkovich
> Attachments: PIG-1019.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.