[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768456#action_12768456 ] Hadoop QA commented on PIG-1025: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422834/TEST-org.apache.pig.test.TestFRJoin.txt against trunk revision 828213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 415 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/107/console This message is automatically generated. > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch, PIG-1025_2.patch, > TEST-org.apache.pig.test.TestFRJoin.txt > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768435#action_12768435 ] Alan Gates commented on PIG-1025: - Alright, I'll wait for Daniel to get that patch checked in, then I'll update and rerun the tests. > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch, PIG-1025_2.patch, > TEST-org.apache.pig.test.TestFRJoin.txt > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768370#action_12768370 ] Dmitriy V. Ryaboy commented on PIG-1025: Sounds like Ashutosh and Tejal found the cause of TestFRJoin failures, it's in PIG-1012 and unrelated to this patch. -D > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch, PIG-1025_2.patch, > TEST-org.apache.pig.test.TestFRJoin.txt > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767514#action_12767514 ] Alan Gates commented on PIG-1025: - I'll rerun the tests manually and review the patch. > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767142#action_12767142 ] Kevin Weil commented on PIG-1025: - Looks like there was a cascading set of test failures unrelated to the patch. If I was somehow to blame here, let me know. > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767085#action_12767085 ] Hadoop QA commented on PIG-1025: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422399/PIG-1025.patch against trunk revision 826110. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/97/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/97/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/97/console This message is automatically generated. > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766838#action_12766838 ] Kevin Weil commented on PIG-1025: - I very much agree that the test case is weak. I followed the model for the rest of the grunt tests, which are similarly weak :) > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1025) Should be able to set job priority through Pig Latin
[ https://issues.apache.org/jira/browse/PIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766771#action_12766771 ] Ashutosh Chauhan commented on PIG-1025: --- Useful feature. Patch looks straightforward. In your test case you are only testing whether it parses it correctly or not, I will suggest to also test whether priority is actually set in the jobconf or not. > Should be able to set job priority through Pig Latin > > > Key: PIG-1025 > URL: https://issues.apache.org/jira/browse/PIG-1025 > Project: Pig > Issue Type: New Feature > Components: grunt >Affects Versions: 0.4.0 >Reporter: Kevin Weil >Priority: Minor > Fix For: 0.6.0 > > Attachments: PIG-1025.patch > > > Currently users can set the job name through Pig Latin by saying > set job.name 'my job name' > The ability to set the priority would also be nice, and the patch should be > small. The goal is to be able to say > set job.priority 'high' > and throw a JobCreationException in the JobControlCompiler if the priority is > not one of the allowed string values from the o.a.h.mapred.JobPriority enum: > very_low, low, normal, high, very_high. Case insensitivity makes this a > little nicer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
