[jira] Commented: (PIG-1095) [zebra] Schema support of anonymous fields in COLECTION fails

2009-11-25 Thread Yan Zhou (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782551#action_12782551
 ] 

Yan Zhou commented on PIG-1095:
---

There is no generic concepts or implementations in terms of schema. All 
projection needs is just a different way to construct a  schema. After 
construction, the schema behaves exactly the same with no sepcial methods for 
projection.
The difference in construction is because that projection allows for duplicate 
column names, and null names. In other words, the restriction is a bit relaxed 
at construction.

 [zebra] Schema support of anonymous fields in COLECTION fails
 -

 Key: PIG-1095
 URL: https://issues.apache.org/jira/browse/PIG-1095
 Project: Pig
  Issue Type: Bug
Reporter: Yan Zhou
Assignee: Yan Zhou
Priority: Minor
 Fix For: 0.6.0, 0.7.0

 Attachments: PIG-1095.patch


 The schema parser fails on schemas of COLLECTION columns like 
 c:collection(int).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1095) [zebra] Schema support of anonymous fields in COLECTION fails

2009-11-25 Thread Yan Zhou (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782553#action_12782553
 ] 

Yan Zhou commented on PIG-1095:
---

Note that this patch does not change any class design at all on schema as used 
by storage or projection.

 [zebra] Schema support of anonymous fields in COLECTION fails
 -

 Key: PIG-1095
 URL: https://issues.apache.org/jira/browse/PIG-1095
 Project: Pig
  Issue Type: Bug
Reporter: Yan Zhou
Assignee: Yan Zhou
Priority: Minor
 Fix For: 0.6.0, 0.7.0

 Attachments: PIG-1095.patch


 The schema parser fails on schemas of COLLECTION columns like 
 c:collection(int).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1095) [zebra] Schema support of anonymous fields in COLECTION fails

2009-11-25 Thread Alan Gates (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782706#action_12782706
 ] 

Alan Gates commented on PIG-1095:
-

Patch checked into 0.6 branch as well.

 [zebra] Schema support of anonymous fields in COLECTION fails
 -

 Key: PIG-1095
 URL: https://issues.apache.org/jira/browse/PIG-1095
 Project: Pig
  Issue Type: Bug
Reporter: Yan Zhou
Assignee: Yan Zhou
Priority: Minor
 Fix For: 0.6.0, 0.7.0

 Attachments: PIG-1095.patch


 The schema parser fails on schemas of COLLECTION columns like 
 c:collection(int).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1095) [zebra] Schema support of anonymous fields in COLECTION fails

2009-11-24 Thread Gaurav Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782264#action_12782264
 ] 

Gaurav Jain commented on PIG-1095:
--


+1

Ideally, specific references/implementations should not be made in generic 
concepts. In this case I did not like the idea of handling projection specially 
 in Schema class.

However, given the dev explanation, I am giving a +1



 [zebra] Schema support of anonymous fields in COLECTION fails
 -

 Key: PIG-1095
 URL: https://issues.apache.org/jira/browse/PIG-1095
 Project: Pig
  Issue Type: Bug
Reporter: Yan Zhou
Assignee: Yan Zhou
Priority: Minor
 Fix For: 0.6.0, 0.7.0

 Attachments: PIG-1095.patch


 The schema parser fails on schemas of COLLECTION columns like 
 c:collection(int).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1095) [zebra] Schema support of anonymous fields in COLECTION fails

2009-11-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781781#action_12781781
 ] 

Hadoop QA commented on PIG-1095:


+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12425897/PIG-1095.patch
  against trunk revision 883515.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 5 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/53/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/53/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/53/console

This message is automatically generated.

 [zebra] Schema support of anonymous fields in COLECTION fails
 -

 Key: PIG-1095
 URL: https://issues.apache.org/jira/browse/PIG-1095
 Project: Pig
  Issue Type: Bug
Reporter: Yan Zhou
Assignee: Yan Zhou
Priority: Minor
 Fix For: 0.6.0, 0.7.0

 Attachments: PIG-1095.patch


 The schema parser fails on schemas of COLLECTION columns like 
 c:collection(int).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1095) [zebra] Schema support of anonymous fields in COLECTION fails

2009-11-20 Thread Yan Zhou (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12780742#action_12780742
 ] 

Yan Zhou commented on PIG-1095:
---

This pacth is also targeted for the 0.6 release so it needs to be on the 0.6 
branch too. 

 [zebra] Schema support of anonymous fields in COLECTION fails
 -

 Key: PIG-1095
 URL: https://issues.apache.org/jira/browse/PIG-1095
 Project: Pig
  Issue Type: Bug
Reporter: Yan Zhou
Assignee: Yan Zhou
Priority: Minor

 The schema parser fails on schemas of COLLECTION columns like 
 c:collection(int).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.