[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898845#action_12898845 ] Gianmarco De Francisci Morales commented on PIG-1295: - Thanks for your

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897922#action_12897922 ] Thejas M Nair commented on PIG-1295: Comments about PIG-1295_0.14.patch - - The

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897958#action_12897958 ] Thejas M Nair commented on PIG-1295: bq. Conceptually comparator is in the logic of

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12896339#action_12896339 ] Gianmarco De Francisci Morales commented on PIG-1295: - I performed a some

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12896390#action_12896390 ] Daniel Dai commented on PIG-1295: - That is terrific! I will review your patch shortly.

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894841#action_12894841 ] Daniel Dai commented on PIG-1295: - Hi, Gianmarco, When you do an explain, you will see

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894961#action_12894961 ] Gianmarco De Francisci Morales commented on PIG-1295: - Thanks for the

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12895093#action_12895093 ] Daniel Dai commented on PIG-1295: - Hi, Gianmarco, 1. Notice currently PigTupleRawComparator

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894382#action_12894382 ] Gianmarco De Francisci Morales commented on PIG-1295: - I have some

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892417#action_12892417 ] Gianmarco De Francisci Morales commented on PIG-1295: - Thanks, here my

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12890384#action_12890384 ] Daniel Dai commented on PIG-1295: - Patch looks pretty good. Thanks Gianmarco! Couple of

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12889231#action_12889231 ] Gianmarco De Francisci Morales commented on PIG-1295: - In DataType the

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12889236#action_12889236 ] Daniel Dai commented on PIG-1295: - Hi, Gianmarco, I think it's better not to assume INTEGER

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12889334#action_12889334 ] Gianmarco De Francisci Morales commented on PIG-1295: - To follow a

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12889368#action_12889368 ] Daniel Dai commented on PIG-1295: - We need to compare a category of data type, not data type

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888517#action_12888517 ] Thejas M Nair commented on PIG-1295: This sounds fine. In case of

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888529#action_12888529 ] Daniel Dai commented on PIG-1295: - If pig.data.tuple.factory.name is BinSedesTupleFactory, we

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887420#action_12887420 ] Daniel Dai commented on PIG-1295: - More clarification for custom Tuple. There two cases for

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887270#action_12887270 ] Daniel Dai commented on PIG-1295: - With the change of PIG-1472, we need to change raw

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12885831#action_12885831 ] Thejas M Nair commented on PIG-1295: 1. If utf8 encoded ordering is same as java string

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883486#action_12883486 ] Hadoop QA commented on PIG-1295: -1 overall. Here are the results of testing the latest

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883361#action_12883361 ] Daniel Dai commented on PIG-1295: - Thanks, is the patch ready for review? Binary comparator

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883367#action_12883367 ] Gianmarco De Francisci Morales commented on PIG-1295: - I think it is

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12879576#action_12879576 ] Daniel Dai commented on PIG-1295: - I run your main problem. It also counts the tuple bytes

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12878120#action_12878120 ] Gianmarco De Francisci Morales commented on PIG-1295: - I did some more

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12878127#action_12878127 ] Daniel Dai commented on PIG-1295: - the new comparator takes between 8 and 10 seconds. The old

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12878130#action_12878130 ] Daniel Dai commented on PIG-1295: - Can you also attach performance test code? I want to take

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876354#action_12876354 ] Daniel Dai commented on PIG-1295: - I briefly review the patch, looks good. This is the

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854607#action_12854607 ] Gianmarco De Francisci Morales commented on PIG-1295: - I have drafted my

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854649#action_12854649 ] Daniel Dai commented on PIG-1295: - Thanks Gianmarco, Proposal looks good. Besides unit test,

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851736#action_12851736 ] Daniel Dai commented on PIG-1295: - Thanks Gianmarco, My suggestion is to divide it into two

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851453#action_12851453 ] Gianmarco De Francisci Morales commented on PIG-1295: - Hi, I have been

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849645#action_12849645 ] Gianmarco De Francisci Morales commented on PIG-1295: - I will start to

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849730#action_12849730 ] Dmitriy V. Ryaboy commented on PIG-1295: Gianmarco, the ticket for Avro loader

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849817#action_12849817 ] Daniel Dai commented on PIG-1295: - Hi, Gianmarco, Mailing list and Jira should be a good

[jira] Commented: (PIG-1295) Binary comparator for secondary sort

[ https://issues.apache.org/jira/browse/PIG-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12848809#action_12848809 ] Gianmarco De Francisci Morales commented on PIG-1295: - Avro provides