[ 
https://issues.apache.org/jira/browse/PIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888952#action_12888952
 ] 

Hadoop QA commented on PIG-1492:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449531/PIG-1492.1.patch
  against trunk revision 964182.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/370/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/370/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/370/console

This message is automatically generated.

> DefaultTuple and DefaultMemory understimate their memory footprint
> ------------------------------------------------------------------
>
>                 Key: PIG-1492
>                 URL: https://issues.apache.org/jira/browse/PIG-1492
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>             Fix For: 0.8.0
>
>         Attachments: PIG-1492.1.patch
>
>
> There are several places where we highly underestimate the memory footprint . 
> For example, for map datatypes, we don't account for the per entry cost for 
> the map container data structures. The estimated size of a tuple having map 
> with 100 integer key-value entries , as per current version of code is 3260 
> bytes, while what is observed is around 6775 bytes .  To verify the memory 
> footprint, i checked free memory before and after creating multiple instances 
> of the object , using code on the lines of 
> http://www.javaspecialists.eu/archive/Issue029.html . 
> In PIG-1443 similar change was done to fix this for CHARARRAY .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to