[jira] Commented: (PIG-578) join ... outer, ... outer semantics are a no-ops, should produce corresponding null values
[ https://issues.apache.org/jira/browse/PIG-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12751834#action_12751834 ] Daniel Dai commented on PIG-578: One minor comment: there are tabs in LogToPhyTranslationVisitor.java and QueryParser.jjt. We shall change it to space. Other part looks good to me. join ... outer, ... outer semantics are a no-ops, should produce corresponding null values -- Key: PIG-578 URL: https://issues.apache.org/jira/browse/PIG-578 Project: Pig Issue Type: Improvement Components: impl Affects Versions: 0.2.0 Reporter: David Ciemiewicz Assignee: Pradeep Kamath Fix For: 0.4.0 Attachments: PIG-578-2.patch, PIG-578.patch Currently using the OUTER modifier in the JOIN statement is a no-op. The resuls of JOIN are always an INNER join. Now that the Pig types branch supports null values proper, the semantics of JOIN ... OUTER, ... OUTER should be corrected to do proper outer joins and populating the corresponding empty values with nulls. Here's the example: A = load 'a.txt' using PigStorage() as ( comment, value ); B = load 'b.txt' using PigStorage() as ( comment, value ); -- -- OUTER clause is ignored in JOIN statement and does not populat tuple with -- null values as it should. Otherwise OUTER is a meaningless no-op modifier. -- ABOuterJoin = join A by ( comment ) outer, B by ( comment ) outer; describe ABOuterJoin; dump ABOuterJoin; The file a contains: a-only 1 ab-both 2 The file b contains: ab-both 2 b-only 3 When you execute the script today, the dump results are: (ab-both,2,ab-both,2) The expected dump results should be: (a-only,1,,) (ab-both,2,ab-both,2) (,,b-only,3) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-578) join ... outer, ... outer semantics are a no-ops, should produce corresponding null values
[ https://issues.apache.org/jira/browse/PIG-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12751136#action_12751136 ] Hadoop QA commented on PIG-578: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418521/PIG-578.patch against trunk revision 810742. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 5 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/11/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/11/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/11/console This message is automatically generated. join ... outer, ... outer semantics are a no-ops, should produce corresponding null values -- Key: PIG-578 URL: https://issues.apache.org/jira/browse/PIG-578 Project: Pig Issue Type: Improvement Components: impl Affects Versions: 0.2.0 Reporter: David Ciemiewicz Assignee: Pradeep Kamath Fix For: 0.4.0 Attachments: PIG-578.patch Currently using the OUTER modifier in the JOIN statement is a no-op. The resuls of JOIN are always an INNER join. Now that the Pig types branch supports null values proper, the semantics of JOIN ... OUTER, ... OUTER should be corrected to do proper outer joins and populating the corresponding empty values with nulls. Here's the example: A = load 'a.txt' using PigStorage() as ( comment, value ); B = load 'b.txt' using PigStorage() as ( comment, value ); -- -- OUTER clause is ignored in JOIN statement and does not populat tuple with -- null values as it should. Otherwise OUTER is a meaningless no-op modifier. -- ABOuterJoin = join A by ( comment ) outer, B by ( comment ) outer; describe ABOuterJoin; dump ABOuterJoin; The file a contains: a-only 1 ab-both 2 The file b contains: ab-both 2 b-only 3 When you execute the script today, the dump results are: (ab-both,2,ab-both,2) The expected dump results should be: (a-only,1,,) (ab-both,2,ab-both,2) (,,b-only,3) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-578) join ... outer, ... outer semantics are a no-ops, should produce corresponding null values
[ https://issues.apache.org/jira/browse/PIG-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12751224#action_12751224 ] Pradeep Kamath commented on PIG-578: Correction to previous comment: At some point we should rename all filenames to be lowercase. should read At some point we should rename all method names to be lowercase. join ... outer, ... outer semantics are a no-ops, should produce corresponding null values -- Key: PIG-578 URL: https://issues.apache.org/jira/browse/PIG-578 Project: Pig Issue Type: Improvement Components: impl Affects Versions: 0.2.0 Reporter: David Ciemiewicz Assignee: Pradeep Kamath Fix For: 0.4.0 Attachments: PIG-578-2.patch, PIG-578.patch Currently using the OUTER modifier in the JOIN statement is a no-op. The resuls of JOIN are always an INNER join. Now that the Pig types branch supports null values proper, the semantics of JOIN ... OUTER, ... OUTER should be corrected to do proper outer joins and populating the corresponding empty values with nulls. Here's the example: A = load 'a.txt' using PigStorage() as ( comment, value ); B = load 'b.txt' using PigStorage() as ( comment, value ); -- -- OUTER clause is ignored in JOIN statement and does not populat tuple with -- null values as it should. Otherwise OUTER is a meaningless no-op modifier. -- ABOuterJoin = join A by ( comment ) outer, B by ( comment ) outer; describe ABOuterJoin; dump ABOuterJoin; The file a contains: a-only 1 ab-both 2 The file b contains: ab-both 2 b-only 3 When you execute the script today, the dump results are: (ab-both,2,ab-both,2) The expected dump results should be: (a-only,1,,) (ab-both,2,ab-both,2) (,,b-only,3) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-578) join ... outer, ... outer semantics are a no-ops, should produce corresponding null values
[ https://issues.apache.org/jira/browse/PIG-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12751263#action_12751263 ] Hadoop QA commented on PIG-578: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418558/PIG-578-2.patch against trunk revision 810742. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/12/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/12/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/12/console This message is automatically generated. join ... outer, ... outer semantics are a no-ops, should produce corresponding null values -- Key: PIG-578 URL: https://issues.apache.org/jira/browse/PIG-578 Project: Pig Issue Type: Improvement Components: impl Affects Versions: 0.2.0 Reporter: David Ciemiewicz Assignee: Pradeep Kamath Fix For: 0.4.0 Attachments: PIG-578-2.patch, PIG-578.patch Currently using the OUTER modifier in the JOIN statement is a no-op. The resuls of JOIN are always an INNER join. Now that the Pig types branch supports null values proper, the semantics of JOIN ... OUTER, ... OUTER should be corrected to do proper outer joins and populating the corresponding empty values with nulls. Here's the example: A = load 'a.txt' using PigStorage() as ( comment, value ); B = load 'b.txt' using PigStorage() as ( comment, value ); -- -- OUTER clause is ignored in JOIN statement and does not populat tuple with -- null values as it should. Otherwise OUTER is a meaningless no-op modifier. -- ABOuterJoin = join A by ( comment ) outer, B by ( comment ) outer; describe ABOuterJoin; dump ABOuterJoin; The file a contains: a-only 1 ab-both 2 The file b contains: ab-both 2 b-only 3 When you execute the script today, the dump results are: (ab-both,2,ab-both,2) The expected dump results should be: (a-only,1,,) (ab-both,2,ab-both,2) (,,b-only,3) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
