[jira] Commented: (PIG-852) pig -version or pig -help returns exit code of 1
[
https://issues.apache.org/jira/browse/PIG-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720510#action_12720510
]
Hudson commented on PIG-852:
Integrated in Pig-trunk #476 (See
[http://hudson.zones.apache.org/hudson/job/Pig-trunk/476/])
: pig -version or pig -help returns exit code of 1 (milindb via
olgan)
> pig -version or pig -help returns exit code of 1
>
>
> Key: PIG-852
> URL: https://issues.apache.org/jira/browse/PIG-852
> Project: Pig
> Issue Type: Bug
> Components: grunt
>Affects Versions: 0.3.0
> Environment: All
>Reporter: Milind Bhandarkar
>Assignee: Milind Bhandarkar
> Attachments: rc.patch
>
>
> {code}
> java -jar pig.jar -x local [-version|-help]
> {code}
> returns an exit code of 1 to the shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-852) pig -version or pig -help returns exit code of 1
[
https://issues.apache.org/jira/browse/PIG-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719942#action_12719942
]
Milind Bhandarkar commented on PIG-852:
---
Note that JUnit tests that test the return code of a completely different JVM
are kludgy at best. Therefore writing a test case of checking the System.exit()
return value is insane. Hadoop folks have *mostly* fixed this issue by having a
static public run() method that can be invoked directly in the tests, and can
have it's return value (which is what main() uses as an exit code) checked.
So, committers, please ignore the "no-tests" warning.
> pig -version or pig -help returns exit code of 1
>
>
> Key: PIG-852
> URL: https://issues.apache.org/jira/browse/PIG-852
> Project: Pig
> Issue Type: Bug
> Components: grunt
>Affects Versions: 0.3.0
> Environment: All
>Reporter: Milind Bhandarkar
>Assignee: Milind Bhandarkar
> Attachments: rc.patch
>
>
> {code}
> java -jar pig.jar -x local [-version|-help]
> {code}
> returns an exit code of 1 to the shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-852) pig -version or pig -help returns exit code of 1
[
https://issues.apache.org/jira/browse/PIG-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719939#action_12719939
]
Hadoop QA commented on PIG-852:
---
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12410752/rc.patch
against trunk revision 784333.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/83/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/83/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/83/console
This message is automatically generated.
> pig -version or pig -help returns exit code of 1
>
>
> Key: PIG-852
> URL: https://issues.apache.org/jira/browse/PIG-852
> Project: Pig
> Issue Type: Bug
> Components: grunt
>Affects Versions: 0.3.0
> Environment: All
>Reporter: Milind Bhandarkar
>Assignee: Milind Bhandarkar
> Attachments: rc.patch
>
>
> {code}
> java -jar pig.jar -x local [-version|-help]
> {code}
> returns an exit code of 1 to the shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
