[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849230#action_12849230 ] Jeff Zhang commented on PIG-915: Olga, sorry for reply you late. This feature has been included in Pig-1205, so I think it is no need to track this jira item. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.8.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847467#action_12847467 ] Olga Natkovich commented on PIG-915: Jeff, are you still planning to get this patch for 0.7.0? We are planning to branch on Monday and need to get it in before that. Otherwise, we can postpone it till 0.8.0 release. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791572#action_12791572 ] Alan Gates commented on PIG-915: I talked to one of our build guru's here. He says the logs of the build that gave you a -1 looked all messed up. I'm going to run another patch test locally and see if I get better results. bq. I add a new Constructor for HBaseStorage, and change the Constructor of HBaseSlice That looks fine. Sorry I misread the patch file and thought you changed the constructor for HBaseStorage rather than adding a new one. bq. Does the pig build system set up some audit rule that do not allow to change the constructor of public class ? no. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791688#action_12791688 ] Alan Gates commented on PIG-915: Alright, I think we figured out the problem. When you changed the HBaseSlice constructor you didn't change the associated javadoc. I think that's what it's complaining about. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791086#action_12791086 ] Alan Gates commented on PIG-915: You're right. I assumed based on the message that you had added some html files, but you didn't. I do not know what it's complaining about. I'll dig around a bit more and see what I can figure out. Does this patch change the required constructor arguments for HBaseStorage? That wouldn't be good. Adding a second constructor that allows a second argument seems fine. But if I read this patch correctly it changes the only constructor to require a second argument. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791099#action_12791099 ] Jeff Zhang commented on PIG-915: Alan, I add a new Constructor for HBaseStorage, and change the Constructor of HBaseSlice. I think it's OK to change HBaseSlice's Constructor, because it is used internally by HBaseStorage, and won't been used by users. Does the pig build system set up some audit rule that do not allow to change the constructor of public class ? Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786919#action_12786919 ] Jeff Zhang commented on PIG-915: Anybody know what does the -1 release audit mean ? I check the warning, it looks like it related to the javadoc. Does it matter I add some comments in this patch ? Thank you for any help. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[
https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787080#action_12787080
]
Alan Gates commented on PIG-915:
It's complaining that there isn't the Apache license header in the new html
files. If you add the following immediately after your html tag it should quit
complaining:
{code}
!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the License); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an AS IS BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
--
{code}
Load row names in HBase loader
--
Key: PIG-915
URL: https://issues.apache.org/jira/browse/PIG-915
Project: Pig
Issue Type: Improvement
Affects Versions: 0.6.0
Reporter: Alex Newman
Assignee: Jeff Zhang
Priority: Minor
Fix For: 0.7.0
Attachments: Pig_915.Patch
Currently their is no way to get the Row names when doing a query from HBase,
we should probably remedy this as important data may be stored there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787220#action_12787220 ] Jeff Zhang commented on PIG-915: Alan, but I didn't add new class in this patch. I just add some new methods and comments on these methods. And these files I modified have license headers. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-915) Load row names in HBase loader
[ https://issues.apache.org/jira/browse/PIG-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785703#action_12785703 ] Hadoop QA commented on PIG-915: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426785/Pig_915.Patch against trunk revision 886875. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 365 release audit warnings (more than the trunk's current 362 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/84/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/84/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/84/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/84/console This message is automatically generated. Load row names in HBase loader -- Key: PIG-915 URL: https://issues.apache.org/jira/browse/PIG-915 Project: Pig Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Alex Newman Assignee: Jeff Zhang Priority: Minor Fix For: 0.7.0 Attachments: Pig_915.Patch Currently their is no way to get the Row names when doing a query from HBase, we should probably remedy this as important data may be stored there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
