FINDBUGS: remaining performance warnings
----------------------------------------
Key: PIG-1052
URL: https://issues.apache.org/jira/browse/PIG-1052
Project: Pig
Issue Type: Improvement
Reporter: Olga Natkovich
SBSC Method
org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.Launcher.getStackTraceElement(String)
concatenates strings using + in a loop
SBSC Method org.apache.pig.impl.logicalLayer.LOCross.getSchema()
concatenates strings using + in a loop
SBSC Method org.apache.pig.impl.logicalLayer.LOForEach.getSchema()
concatenates strings using + in a loop
SBSC Method org.apache.pig.PigServer.locateJarFromResources(String)
concatenates strings using + in a loop
SBSC Method org.apache.pig.tools.parameters.ParseException.initialise(Token,
int[][], String[]) concatenates strings using + in a loop
SBSC Method
org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String)
concatenates strings using + in a loop
SS Unread field:
org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.Launcher.OOM_ERR;
should this field be static?
SS Unread field:
org.apache.pig.impl.io.BufferedPositionedInputStream.bufSize; should this field
be static?
UPM Private method
org.apache.pig.impl.plan.optimizer.RulePlanPrinter.planString(List) is never
called
UPM Private method org.apache.pig.impl.plan.PlanPrinter.planString(List) is
never called
WMI Method org.apache.pig.builtin.PigStorage.putField(Object) makes
inefficient use of keySet iterator instead of entrySet iterator
WMI Method org.apache.pig.data.DataType.mapToString(Map) makes inefficient
use of keySet iterator instead of entrySet iterator
WMI Method org.apache.pig.impl.logicalLayer.LOCross.getSchema() makes
inefficient use of keySet iterator instead of entrySet iterator
WMI Method org.apache.pig.impl.logicalLayer.LOForEach.getSchema() makes
inefficient use of keySet iterator instead of entrySet iterator
WMI Method
org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.getLoadFuncSpec(Schema$FieldSchema,
String) makes inefficient use of keySet iterator instead of entrySet iterator
WMI Method
org.apache.pig.impl.plan.CompilationMessageCollector.logAggregate(Map,
CompilationMessageCollector$MessageType, Log) makes inefficient use of keySet
iterator instead of entrySet iterator
WMI Method org.apache.pig.StandAloneParser.tryParse(String) makes
inefficient use of keySet iterator instead of entrySet iterator
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
