[ https://issues.apache.org/jira/browse/PIG-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677603#action_12677603 ]
pkamath edited comment on PIG-652 at 2/27/09 4:06 PM: ------------------------------------------------------------- Attaching new patch - the only difference is: (old code is the first input in the diff below) {code} < --- src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java (revision 747112) --- > --- > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java > (revision 748740) 146c146 < + if(sPrepClass != null && sPrepClass.isInstance(OutputFormat.class)) { --- > + if(sPrepClass != null && > OutputFormat.class.isAssignableFrom(sPrepClass)) { {code} The code achives checking whether the class supplied by the Storefunc is of type OutputFormat was (Author: pkamath): Attaching new patch - the only difference is: (old code is the first input in the diff below) {code} < --- src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java (revision 747112) --- > --- > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java > (revision 748740) 146c146 < + if(sPrepClass != null && sPrepClass.isInstance(OutputFormat.class)) { --- > + if(sPrepClass != null && > OutputFormat.class.isAssignableFrom(sPrepClass)) { {code} The code achives checking whether the class supplied by the Loader is of type OutputFormat > Need to give user control of OutputFormat > ----------------------------------------- > > Key: PIG-652 > URL: https://issues.apache.org/jira/browse/PIG-652 > Project: Pig > Issue Type: New Feature > Components: impl > Affects Versions: types_branch > Reporter: Alan Gates > Assignee: Pradeep Kamath > Fix For: types_branch > > Attachments: PIG-652-v2.patch, PIG-652-v3.patch, PIG-652-v4.patch, > PIG-652.patch > > > Pig currently allows users some control over InputFormat via the Slicer and > Slice interfaces. It does not allow any control over OutputFormat and > RecordWriter interfaces. It just allows the user to implement a storage > function that controls how the data is serialized. For hadoop tables, we > will need to allow custom OutputFormats that prepare output information and > objects needed by a Table store function. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.