Re: [Piglit] [PATCH V2 1/2] ext_framebuffer_multisample: skip negative-max-samples

2013-03-28 Thread Kenneth Graunke
On 03/15/2013 02:13 AM, Chris Forbes wrote: If ARB_texture_multisample or ARB_internalformat_query are supported, the limits and/or errors generated are different, so skip this test. V2: - Emit a useful message when skipping. Signed-off-by: Chris Forbes chr...@ijw.co.nz ---

Re: [Piglit] [PATCH V2 2/2] arb_texture_multisample: add new negative-max-samples test

2013-03-28 Thread Kenneth Graunke
On 03/15/2013 02:13 AM, Chris Forbes wrote: This covers the sample count limits for both renderbuffers and multisample textures, when ARB_texture_multisample is supported. Skips if ARB_internalformat_query is supported, since that extension allows the overall sample count limits to be exceeded

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-28 Thread Jose Fonseca
Me too FWIW Jose - Original Message - The patch seems to be too large for a mailing list. It's here: http://cgit.freedesktop.org/~mareko/piglit/commit/?id=8fa85790a3e5a3caba3a6eba912e7858c893363b Marek On Wed, Mar 27, 2013 at 11:39 PM, Brian Paul bri...@vmware.com wrote: On

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-28 Thread Chris Forbes
Looks good to me. I've fallen in this trap at least once, so it's great to see it go away. Feel free to add my R-b. -- Chris On Wed, Mar 27, 2013 at 6:13 AM, Marek Olšák mar...@gmail.com wrote: Hi, would anyone like to comment on this? Or is it still stuck in the moderation queue? Marek

[Piglit] Feature request: indirect rendering

2013-03-28 Thread Brian Paul
I happened to find a bug in NVIDIA's driver with indirect GLX rendering. I was going to write a piglit test for it but found that we have no way to request an indirect GLX context in piglit. We could either: 1. add a PIGLIT_GL_VISUAL_INDIRECT bit/flag 2. add a bol

[Piglit] [PATCH 1/3] piglit util: new functions piglit_program_pipeline_check_status/quiet

2013-03-28 Thread gregory hainaut
Equivalent to piglit_link_check_status/quiet but with program object pipeline --- tests/util/piglit-shader.c | 50 tests/util/piglit-shader.h |2 ++ 2 files changed, 52 insertions(+) diff --git a/tests/util/piglit-shader.c

[Piglit] [PATCH 1/3] piglit util: new functions piglit_program_pipeline_check_status/quiet

2013-03-28 Thread gregory hainaut
Equivalent to piglit_link_check_status/quiet but with program object pipeline --- tests/util/piglit-shader.c | 50 tests/util/piglit-shader.h |2 ++ 2 files changed, 52 insertions(+) diff --git a/tests/util/piglit-shader.c

[Piglit] [PATCH 2/3] add 3 news tests for arb_separate_shader_objects

2013-03-28 Thread gregory hainaut
* new test IsProgramPipeline: check the Pipeline object state creation. GenPipeline only reserved name. I also take the opportunity to test negative value on glGenProgramPipelines and glDeleteProgramPipelines. Note: FGLRX don't follow the spec besides crash on glGenProgramPipelines because of

[Piglit] [PATCH 3/3] update EXT_transform_feedback error detection

2013-03-28 Thread gregory hainaut
program pipeline add new INVALID_OPERATION (spec chapter 13.2.2) Note: FGLRX don't report any of the expected errors... --- tests/all.tests|4 +- tests/spec/ext_transform_feedback/api-errors.c | 84 +++- 2 files changed, 85 insertions(+),

Re: [Piglit] [PATCH 1/3] piglit util: new functions piglit_program_pipeline_check_status/quiet

2013-03-28 Thread gregory hainaut
Sorry I did a forward which wrap my line. I resend it but it appears before... Discard this patch please. On Thu, 28 Mar 2013 18:45:33 +0100 gregory hainaut gregory.hain...@gmail.com wrote: Equivalent to piglit_link_check_status/quiet but with program object pipeline ---

Re: [Piglit] [PATCH 1/1] glsl-es-1.00: sanity.shader_test fragment needs default precision

2013-03-28 Thread Stuart Abercrombie
Reviewed-by: Stuart Abercrombie sabercrom...@chromium.org On Wed, Mar 20, 2013 at 11:30 AM, Tom Gall tom.g...@linaro.org wrote: GLSL ES 1.00 spec 4.5.3 page 36: The fragment language has no default precision qualifier for floating point types. Adding default precision for float in the

Re: [Piglit] [PATCH 2/2] variable-index-write.sh: extend to support glsl es 1.00

2013-03-28 Thread Stuart Abercrombie
The content looks good. I'm just not sure if supplying 100 as a parameter should be the trigger for GLES GLSL 1.00. It doesn't seem particularly obvious, although I know there is no regular GL GLSL version 1.00. A separate preexisting issue is the location of the file, which is again

Re: [Piglit] [PATCH 2/2] variable-index-write.sh: extend to support glsl es 1.00

2013-03-28 Thread Tom Gall
On Thu, Mar 28, 2013 at 1:50 PM, Stuart Abercrombie sabercrom...@google.com wrote: The content looks good. I'm just not sure if supplying 100 as a parameter should be the trigger for GLES GLSL 1.00. It doesn't seem particularly obvious, although I know there is no regular GL GLSL version