Re: [Piglit] [PATCH 2/2] cl: Add generated tests for global and local stores

2013-08-01 Thread Dylan Baker
On Wed, Jul 31, 2013 at 11:37 PM, Dylan Baker baker.dyla...@gmail.comwrote: I have some python comments for you, they're mainly style type comments, but some of them should help your code readability a lot. On Wed, Jul 31, 2013 at 7:16 PM, Tom Stellard t...@stellard.net wrote: From: Tom

Re: [Piglit] glx-multithread-shader-compile hung

2013-08-01 Thread Mathias Fröhlich
On Wednesday, July 31, 2013 08:16:25 Jose Fonseca wrote: FYI, I twice now got deadlock on glx-multithread-shader-compile on my continuous testing of Mesa: ... [Sat Jul 20 01:18:20 2013] :: running :: glx/glx-multithread-shader-compile -- last piglit message Build timed out (after 120

Re: [Piglit] Piglit 'changes' page no longer showing all tests that are 'Not Run'

2013-08-01 Thread Dylan Baker
This change has already landed On Thu, Aug 1, 2013 at 10:27 AM, Chad Versace chad.vers...@linux.intel.comwrote: Would it be possible to restore the old piglit behavior or at least come up with another solution? I second this change. I need to see skipped tests.

Re: [Piglit] [PATCH 2/2] cl: Add generated tests for global and local stores

2013-08-01 Thread Tom Stellard
On Wed, Jul 31, 2013 at 11:37:16PM -0700, Dylan Baker wrote: Hi Dylan, Thanks for your comments. I have some python comments for you, they're mainly style type comments, but some of them should help your code readability a lot. On Wed, Jul 31, 2013 at 7:16 PM, Tom Stellard

Re: [Piglit] [PATCH 2/2] cl: Add generated tests for global and local stores

2013-08-01 Thread Dylan Baker
Ah, that makes sense. I have no further complaints and I'm not sure what the most approriate tag is, since I'm not a CL expert. I'm guessing acked-by, but feel free to use something else if it's more appropriate. Acked-by: Dylan Baker baker.dyla...@gmail.com On Thu, Aug 1, 2013 at 7:34 PM, Tom