Re: [Piglit] [PATCH 1/4] glslparsertest: Add complementary shaders to link GLSL ES 3.00 shaders too

On 9 August 2013 15:40, Ian Romanick wrote: > From: Ian Romanick > > Fixes failures in ES3 --check-link tests > default-precision-sampler.frag and default-precision-sampler.vert. It > also makes "glsl-es-3.00 compiler no-default-float-precision.frag" > correctly fail. > > Signed-off-by: Ian Rom

Re: [Piglit] [PATCH 1/2] gen_texture_query_lod_tests.py: Put function name in test filename.

On 6 August 2013 21:33, Matt Turner wrote: > --- > generated_tests/gen_texture_query_lod_tests.py | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > A quick note in the commit message explaining the rationale for this patch would be nice. (I assume you're doing this because wit

Re: [Piglit] [PATCH 2/2] summary: Include traceback in the summary files.

Looks good. Reviewed-by: Dylan Baker On Mon, Aug 12, 2013 at 2:54 PM, Kenneth Graunke wrote: > If the Python framework fails to run a program for some reason, it'll > record a 'fail' status. It also records a 'traceback' key in the > dictionary. > > The new summary code missed this when writi

Re: [Piglit] [PATCH v2] gs: Test rules related to geometry shader input sizes.

On 9 August 2013 11:59, Ian Romanick wrote: > This would have been easier to review if it had been broken up. It's a > pretty huge patch. > Yeah, sorry about that. I have an idea for how to split it into 8 patches, so v2 should probably be a lot easier to review. > > In addition to the comme